From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Michael Timmons Newsgroups: gmane.emacs.bugs Subject: bug#38867: 27.0.60; fileloop-initialize-replace misses occurrences to be replaced Date: Thu, 2 Jan 2020 05:08:25 +0000 Message-ID: <1577941704945.15167@mit.edu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="_002_157794170494515167mitedu_" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="14899"; mail-complaints-to="usenet@blaine.gmane.org" To: 38867@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 02 06:35:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1imt8Y-0003jJ-Qx for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Jan 2020 06:35:10 +0100 Original-Received: from localhost ([::1]:36938 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1imt8X-00052l-Mr for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Jan 2020 00:35:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46439) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1imt8R-00052f-DY for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2020 00:35:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1imt8Q-0006pF-3y for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2020 00:35:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60260) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1imt8Q-0006oi-0c for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2020 00:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1imt8P-0006D9-To for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2020 00:35:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Michael Timmons Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Jan 2020 05:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 38867 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: "bug-gnu-emacs@gnu.org" Original-Received: via spool by submit@debbugs.gnu.org id=B.157794327723833 (code B ref -1); Thu, 02 Jan 2020 05:35:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Jan 2020 05:34:37 +0000 Original-Received: from localhost ([127.0.0.1]:38000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imt81-0006CK-7c for submit@debbugs.gnu.org; Thu, 02 Jan 2020 00:34:37 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:40576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imsik-0005ZV-Vd for submit@debbugs.gnu.org; Thu, 02 Jan 2020 00:08:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43893) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1imsij-0000ui-Dj for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2020 00:08:30 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1imsih-0002EQ-Vq for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2020 00:08:29 -0500 Original-Received: from outgoing-exchange-3.mit.edu ([18.9.28.13]:56196) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1imsih-0002Cc-R2 for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2020 00:08:27 -0500 Original-Received: from w92exedge3.exchange.mit.edu (W92EXEDGE3.EXCHANGE.MIT.EDU [18.7.73.15]) by outgoing-exchange-3.mit.edu (8.14.7/8.12.4) with ESMTP id 00258Dxj019452 for ; Thu, 2 Jan 2020 00:08:13 -0500 Original-Received: from w92expo10.exchange.mit.edu (18.7.74.64) by w92exedge3.exchange.mit.edu (18.7.73.15) with Microsoft SMTP Server (TLS) id 15.0.1293.2; Thu, 2 Jan 2020 00:07:15 -0500 Original-Received: from oc11expo10.exchange.mit.edu (18.9.4.15) by w92expo10.exchange.mit.edu (18.7.74.64) with Microsoft SMTP Server (TLS) id 15.0.1365.1; Thu, 2 Jan 2020 00:08:25 -0500 Original-Received: from oc11expo10.exchange.mit.edu ([18.9.4.15]) by oc11expo10.exchange.mit.edu ([18.9.4.15]) with mapi id 15.00.1365.000; Thu, 2 Jan 2020 00:08:25 -0500 Thread-Topic: 27.0.60; fileloop-initialize-replace misses occurrences to be replaced Thread-Index: AQHVwSp4jQoTG+J9zEungTeX7PZewQ== Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [184.19.53.43] X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Mailman-Approved-At: Thu, 02 Jan 2020 00:34:36 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:174062 Archived-At: --_002_157794170494515167mitedu_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Severity: normal=0A= Tags: patch=0A= =0A= When using fileloop-initialize-replace on files that already have open=0A= buffers and points in arbitrary locations, occurrences of the regex to=0A= replace can be missed. This appears to happen on my setup when=0A= switch-to-buffer-preserve-window-point is non-nil. The call to=0A= switch-buffer between the invocation of the scan- and operate-functions=0A= can then cause the point to change to a different location than the=0A= scan-function left it.=0A= =0A= This can manifest itself by either missing occurrences of the regex in=0A= the open files where point is beyond some occurrences or it can=0A= completely miss files if some file early on in the iteration has its=0A= point beyond all occurrences of the regex, causing the operate-function=0A= to return nil, aborting the rest of the operation.=0A= =0A= In GNU Emacs 27.0.60 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.13, c= airo version 1.16.0)=0A= of 2019-12-27 built on rocinante=0A= Repository revision: 8224ed7d406e8654a163b05c0c647a5d44c090ed=0A= Repository branch: emacs-27=0A= Windowing system distributor 'The X.Org Foundation', version 11.0.12006000= =0A= System Description: Gentoo/Linux=0A= =0A= --_002_157794170494515167mitedu_ Content-Type: text/x-patch; name="0001-Fix-fileloop-initialize-replace-with-buffers-that-ar.patch" Content-Description: 0001-Fix-fileloop-initialize-replace-with-buffers-that-ar.patch Content-Disposition: attachment; filename="0001-Fix-fileloop-initialize-replace-with-buffers-that-ar.patch"; size=1810; creation-date="Thu, 02 Jan 2020 05:04:37 GMT"; modification-date="Thu, 02 Jan 2020 05:04:37 GMT" Content-Transfer-Encoding: base64 RnJvbSA3NGVjMjg2N2FhMjFiMzEyOGUyNjAwMDQ4Zjk4ZjNlNzc4MmZlMGFkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFcmljIFRpbW1vbnMgPGV0aW1tb25zQG1pdC5lZHU+CkRhdGU6 IFdlZCwgMSBKYW4gMjAyMCAyMjozMzo0NyAtMDYwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeCBmaWxl bG9vcC1pbml0aWFsaXplLXJlcGxhY2Ugd2l0aCBidWZmZXJzIHRoYXQgYXJlIGFscmVhZHkKIG9w ZW4KClRoZSBvcGVyYXRlLWZ1bmN0aW9uIHVzZWQgaW4gZmlsZWxvb3AtaW5pdGlhbGl6ZS1yZXBs YWNlIGFzc3VtZWQgdGhhdAp0aGUgcG9pbnQgZG9lcyBub3QgY2hhbmdlIGJldHdlZW4gdGhlIGlu dm9jYXRpb24gb2YgdGhlIHNjYW4tZnVuY3Rpb24KYW5kIG9wZXJhdGUtZnVuY3Rpb24uIFRoaXMg YXNzdW1wdGlvbiBpcyB2aW9sYXRlZCwgaG93ZXZlciwgaWYgdGhlCmZpbGUgYmVpbmcgb3BlcmF0 ZWQgb24gaGFzIGFscmVhZHkgYmVlbiBvcGVuZWQgaW4gYSB3aW5kb3cgYW5kCmBzd2l0Y2gtdG8t YnVmZmVyLXByZXNlcnZlLXdpbmRvdy1wb2ludCcgaXMgbm9uLW5pbC4KCkZpeCBieSB0ZWxsaW5n IGBwZXJmb3JtLXJlcGxhY2UnIHRvIG9wZXJhdGUgb3ZlciB0aGUgZW50aXJlCmJ1ZmZlci4gQ291 bGQgcG90ZW50aWFsbHkgYmUgZnVydGhlciBiZSBvcHRpbWl6ZWQgYnkgc2F2aW5nIHRoZSBwb2lu dAppbiB0aGUgc2Nhbi1mdW5jdGlvbiBhbmQgdXNpbmcgaXQgYXMgdGhlIHN0YXJ0IHBvaW50IGlu IHRoZQpvcGVyYXRlLWZ1bmN0aW9uLgotLS0KIGxpc3AvZmlsZWxvb3AuZWwgfCAxMCArKysrLS0t LS0tCiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL2xpc3AvZmlsZWxvb3AuZWwgYi9saXNwL2ZpbGVsb29wLmVsCmluZGV4IDU0Mzk2 M2ZlYWYuLjBjOGVjNWI4ZTAgMTAwNjQ0Ci0tLSBhL2xpc3AvZmlsZWxvb3AuZWwKKysrIGIvbGlz cC9maWxlbG9vcC5lbApAQCAtMjA1LDEzICsyMDUsMTEgQEAgREVMSU1JVEVEIGlmIG5vbi1uaWwg bWVhbnMgcmVwbGFjZSBvbmx5IHdvcmQtZGVsaW1pdGVkIG1hdGNoZXMuIgogICAgKGxhbWJkYSAo KQogICAgICAobGV0ICgoY2FzZS1mb2xkLXNlYXJjaAogICAgICAgICAgICAgKGlmIChtZW1xbCBj YXNlLWZvbGQgJyhuaWwgdCkpIGNhc2UtZm9sZCBjYXNlLWZvbGQtc2VhcmNoKSkpCi0gICAgICAg KGlmIChyZS1zZWFyY2gtZm9yd2FyZCBmcm9tIG5pbCB0KQotCSAgIDs7IFdoZW4gd2UgZmluZCBh IG1hdGNoLCBtb3ZlIGJhY2sKLQkgICA7OyB0byB0aGUgYmVnaW5uaW5nIG9mIGl0IHNvIHBlcmZv cm0tcmVwbGFjZQotCSAgIDs7IHdpbGwgc2VlIGl0LgotCSAgIChnb3RvLWNoYXIgKG1hdGNoLWJl Z2lubmluZyAwKSkpKSkKKyAgICAgICAocmUtc2VhcmNoLWZvcndhcmQgZnJvbSBuaWwgdCkpKQog ICAgKGxhbWJkYSAoKQotICAgICAocGVyZm9ybS1yZXBsYWNlIGZyb20gdG8gdCB0IGRlbGltaXRl ZCBuaWwgbXVsdGktcXVlcnktcmVwbGFjZS1tYXApKSkpCisgICAgIDs7IFdlIHByb3ZpZGUgU1RB UlQgYW5kIEVORCBiZWNhdXNlIHRoZSBidWZmZXIgaXMgbm90IGd1YXJhbnRlZWQKKyAgICAgOzsg dG8gYmUgYXQgYW55IHBhcnRpY3VsYXIgcG9pbnQgd2hlbiB0aGlzIGlzIGNhbGxlZC4KKyAgICAg KHBlcmZvcm0tcmVwbGFjZSBmcm9tIHRvIHQgdCBkZWxpbWl0ZWQgbmlsIG11bHRpLXF1ZXJ5LXJl cGxhY2UtbWFwIChwb2ludC1taW4pIChwb2ludC1tYXgpKSkpKQogCiAocHJvdmlkZSAnZmlsZWxv b3ApCiA7OzsgZmlsZWxvb3AuZWwgZW5kcyBoZXJlCi0tIAoyLjI0LjEKCg== --_002_157794170494515167mitedu_--