Re: tool-bar-setup overwrites local tool-bar-map

[Bill Wohler <wohler@newt.com>]

Richard Stallman <rms@gnu.org> wrote:

>     If one runs tool-bar-mode first, and then MH-E, one sees the one pair of
>     Preferences/Help buttons (the ones defined by MH-E). If vice-versa, one
>     sees *two* pairs of Preferences/Help buttons (the ones defined by MH-E
>     plus the ones defined by tool-bar).
> 
> Now I understand the point of your patch.
> But it seems to me that ALL the standard tool-bar items
> ought to be added to the standard tool-bar map.
> Not just Help and Preferences.
> 
> Ah, now I see.  All the rest are added using
> tool-bar-add-item-from-menu, which uses (default-value 'tool-bar-map).
> 
> So I believe your patch is correct.  But I think this is cleaner.
> Does it work?

I agree. Your patch is cleaner and is closer to the documented usage.
And it works (for me). I'd be happy if you checked it in. Thanks.

-- 
Bill Wohler <wohler@newt.com>  http://www.newt.com/wohler/  GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.