From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#35277: 26.1.90; Non-assigned variable used in condition Date: Mon, 15 Apr 2019 20:58:04 -0700 Organization: UCLA Computer Science Department Message-ID: <156ca2d6-22c1-993c-4210-fc797096ddc2@cs.ucla.edu> References: <875zrgv6xh.fsf@telefonica.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------CE7C89789C8491497B2A1B5C" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="118802"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Cc: 35277-done@debbugs.gnu.org To: =?UTF-8?Q?=C3=93scar?= Fuentes Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 16 05:59:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hGFFX-000UkQ-8g for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Apr 2019 05:59:11 +0200 Original-Received: from localhost ([127.0.0.1]:58889 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGFFW-0003D0-3y for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Apr 2019 23:59:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33875) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGFFP-0003Ct-E0 for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 23:59:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGFFO-0004Lx-C6 for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 23:59:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50804) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hGFFO-0004Lm-0D for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 23:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hGFFN-0006I4-Vc for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 23:59:01 -0400 In-Reply-To: <875zrgv6xh.fsf@telefonica.net> Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Apr 2019 03:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 35277 X-GNU-PR-Package: emacs Mail-Followup-To: 35277@debbugs.gnu.org, eggert@cs.ucla.edu, ofv@wanadoo.es Original-Received: via spool by 35277-done@debbugs.gnu.org id=D35277.155538709424110 (code D ref 35277); Tue, 16 Apr 2019 03:59:01 +0000 Original-Received: (at 35277-done) by debbugs.gnu.org; 16 Apr 2019 03:58:14 +0000 Original-Received: from localhost ([127.0.0.1]:36115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGFEb-0006Gn-KW for submit@debbugs.gnu.org; Mon, 15 Apr 2019 23:58:13 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:45678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGFEa-0006GX-4I for 35277-done@debbugs.gnu.org; Mon, 15 Apr 2019 23:58:12 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D331E1616ED; Mon, 15 Apr 2019 20:58:05 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id DfxVH3wK2VvK; Mon, 15 Apr 2019 20:58:05 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 0853216174E; Mon, 15 Apr 2019 20:58:05 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id LNxaC2COowQ4; Mon, 15 Apr 2019 20:58:04 -0700 (PDT) Original-Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id BF1EB1616DA; Mon, 15 Apr 2019 20:58:04 -0700 (PDT) Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157699 Archived-At: This is a multi-part message in MIME format. --------------CE7C89789C8491497B2A1B5C Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for reporting that. I installed the attached patch into Emacs master. --------------CE7C89789C8491497B2A1B5C Content-Type: text/x-patch; name="0001-Fix-uninit-var-in-widget.c.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Fix-uninit-var-in-widget.c.patch" >From debaa72dd89eee0dffc930a7ccff742ca5a81d88 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Mon, 15 Apr 2019 20:53:13 -0700 Subject: [PATCH] Fix uninit var in widget.c * src/widget.c (EmacsFrameQueryGeometry): Avoid use of uninitialized variables ok_width, ok_height (Bug#35277). --- src/widget.c | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/src/widget.c b/src/widget.c index 508974dd46..e662dd3ecd 100644 --- a/src/widget.c +++ b/src/widget.c @@ -434,21 +434,20 @@ EmacsFrameResize (Widget widget) } static XtGeometryResult -EmacsFrameQueryGeometry (Widget widget, XtWidgetGeometry *request, XtWidgetGeometry *result) +EmacsFrameQueryGeometry (Widget widget, XtWidgetGeometry *request, + XtWidgetGeometry *result) { - EmacsFrame ew = (EmacsFrame) widget; - int mask = request->request_mode; - Dimension ok_width, ok_height; - if (mask & (CWWidth | CWHeight)) + if (mask & (CWWidth | CWHeight) && !frame_resize_pixelwise) { - if (!frame_resize_pixelwise) - round_size_to_char (ew, - (mask & CWWidth) ? request->width : ew->core.width, - ((mask & CWHeight) ? request->height - : ew->core.height), - &ok_width, &ok_height); + EmacsFrame ew = (EmacsFrame) widget; + Dimension ok_width, ok_height; + + round_size_to_char (ew, + mask & CWWidth ? request->width : ew->core.width, + mask & CWHeight ? request->height : ew->core.height, + &ok_width, &ok_height); if ((mask & CWWidth) && (ok_width != request->width)) { result->request_mode |= CWWidth; -- 2.17.1 --------------CE7C89789C8491497B2A1B5C--