all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jim Porter <jporterbugs@gmail.com>
To: 55204@debbugs.gnu.org
Subject: bug#55204: 29.0.50; Improve quoting consistency in Eshell predicates/modifiers
Date: Sat, 30 Apr 2022 21:37:20 -0700	[thread overview]
Message-ID: <155d0ab6-fe59-940d-23ad-34a6d066fc46@gmail.com> (raw)

Currently, there are some inconsistencies with how string parameters 
should be quoted in Eshell argument predicates/modifiers (hereafter just 
"predicates"). First, the possible delimiters for a given predicate vary 
based on which predicate is used. Currently, the allowed delimiters are:

Any non-digit character:
   u (user)
   g (group)
   a (access time)
   m (modification time)
   c (change time)
Any character:
   :i (include)
   :x (exclude)
   :s (substitute)
"'" or "/":
   :j (join)
   :S (split)

Relatedly, although the string parameters are parsed so that you can 
escape the delimiter with "\", the backslash isn't actually removed 
before using the parameter. For example, from "emacs -Q --eval '(eshell)':

   ~ $ echo $(list "foo" "bar")(:j'\'')
   foo\'bar

That should print "foo'bar" instead. Similarly, when redirecting output 
to a buffer, escapes aren't properly removed. Again, from "emacs -Q 
--eval '(eshell)'":

   ~ $ echo hi > #<foo\>bar>
   ;; Writes to the buffer "foo\>bar"

Patch forthcoming shortly (just getting a bug number first).





             reply	other threads:[~2022-05-01  4:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-01  4:37 Jim Porter [this message]
2022-05-01  4:50 ` bug#55204: [PATCH] 29.0.50; Improve quoting consistency in Eshell predicates/modifiers Jim Porter
2022-05-01  8:40   ` bug#55204: " Lars Ingebrigtsen
2022-05-01 18:18     ` bug#55204: [PATCH v2] " Jim Porter
2022-05-01 18:22       ` Lars Ingebrigtsen
2022-05-01 18:36         ` Jim Porter
2022-05-01 18:40           ` Lars Ingebrigtsen
2022-05-01 18:41             ` Lars Ingebrigtsen
2022-05-01 18:42               ` Lars Ingebrigtsen
2022-05-01 23:55                 ` Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=155d0ab6-fe59-940d-23ad-34a6d066fc46@gmail.com \
    --to=jporterbugs@gmail.com \
    --cc=55204@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.