From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.bugs Subject: bug#35368: [PATCH v3] Do potentially destructive operations in prepare-commit-msg Date: Thu, 16 May 2019 00:28:58 +0300 Message-ID: <1557955738.20091.0@yandex.ru> References: <87k1esg02j.fsf@gmail.com> <20190514222647.4799-1-Hi-Angel@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="55494"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35368@debbugs.gnu.org To: npostavs@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 15 23:30:33 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hR1Ts-000ELu-U6 for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 May 2019 23:30:33 +0200 Original-Received: from localhost ([127.0.0.1]:43057 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hR1Tr-0006NK-V7 for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 May 2019 17:30:31 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hR1TQ-000653-FJ for bug-gnu-emacs@gnu.org; Wed, 15 May 2019 17:30:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hR1TP-0003pA-CZ for bug-gnu-emacs@gnu.org; Wed, 15 May 2019 17:30:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39978) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hR1TO-0003mt-Gi for bug-gnu-emacs@gnu.org; Wed, 15 May 2019 17:30:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hR1TO-0002Kn-2G for bug-gnu-emacs@gnu.org; Wed, 15 May 2019 17:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 May 2019 21:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35368 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35368-submit@debbugs.gnu.org id=B35368.15579557498877 (code B ref 35368); Wed, 15 May 2019 21:30:01 +0000 Original-Received: (at 35368) by debbugs.gnu.org; 15 May 2019 21:29:09 +0000 Original-Received: from localhost ([127.0.0.1]:53522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hR1SW-0002J7-RT for submit@debbugs.gnu.org; Wed, 15 May 2019 17:29:09 -0400 Original-Received: from forward103j.mail.yandex.net ([5.45.198.246]:58086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hR1SV-0002IX-50 for 35368@debbugs.gnu.org; Wed, 15 May 2019 17:29:07 -0400 Original-Received: from mxback18o.mail.yandex.net (mxback18o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::69]) by forward103j.mail.yandex.net (Yandex) with ESMTP id 97E2C674045E; Thu, 16 May 2019 00:28:59 +0300 (MSK) Original-Received: from smtp4j.mail.yandex.net (smtp4j.mail.yandex.net [2a02:6b8:0:1619::15:6]) by mxback18o.mail.yandex.net (nwsmtp/Yandex) with ESMTP id CpuYLywXYu-Sx40J1oo; Thu, 16 May 2019 00:28:59 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1557955739; bh=LJEJMsqF2MumVcEV51zT1VtzKDHXnNUWDheBAV1WeOk=; h=In-Reply-To:Cc:To:Subject:From:References:Date:Message-Id; b=Du6zt1pstD01EEtw+PPNrMjfPlRoObvl0KH7yW7evJqORgYXCAKDEda5I8wSE3IkH 7K67eiawZQYInukBYQJ7FfLmOsnm7SWsXmsJiUVyAtzRB6T041QefcvbDvC0IzbruY 1+2oXYDY+J3GUYeUIulAvevoXgBQ2xRj/6BLRAt4= Authentication-Results: mxback18o.mail.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: by smtp4j.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id NTkHBcfIqW-SwZq8vff; Thu, 16 May 2019 00:28:58 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) In-Reply-To: <85k1erwr8r.fsf@gmail.com> X-Mailer: geary/3.33.1 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159359 Archived-At: =F7 =F3=D2, =CD=C1=D1 15, 2019 at 13:40, npostavs@gmail.com =CE=C1=D0=C9=D3= =C1=CC: > Konstantin Kharlamov writes: >=20 >> * build-aux/git-hooks/prepare-commit-msg: if someone occasionally=20 >> puts >> Signed-off line, it will likely get there through -s option of git. >> Exploit this fact to abort before a user got a chance to type commit >> message. >=20 > Thanks, looks good, but I think it would be helpful to explain that=20 > this > is about catching git commit -s ... in the comments of the file too. >=20 >> --- a/autogen.sh >> +++ b/autogen.sh >> @@ -1,4 +1,4 @@ >> -#!/bin/sh >> + #!/bin/sh >=20 > This is a typo or something, right? Oh, right, sorry about that. It wasn't supposed to get into the commit.=20 I was testing the hook by adding this space, and apparently it leaked=20 through to my local commit. Thanks for your comments, I resent a v4 with a comment added, and the=20 stray space removed. =