From: Konstantin Kharlamov <hi-angel@yandex.ru>
To: npostavs@gmail.com
Cc: 35368@debbugs.gnu.org
Subject: bug#35368: [PATCH v2] Do potentially destructive operations in prepare-commit-msg
Date: Wed, 15 May 2019 00:22:02 +0300 [thread overview]
Message-ID: <1557868922.32614.0@yandex.ru> (raw)
In-Reply-To: <85pnolvt4d.fsf@gmail.com>
В Вт, мая 14, 2019 at 13:33, npostavs@gmail.com написал:
> Konstantin Kharlamov <Hi-Angel@yandex.ru> writes:
>
>> +# Use a UTF-8 locale if available, so that the UTF-8 check works.
>> +# Use U+00A2 CENT SIGN to test whether the locale works.
>> +cent_sign_utf8_format='\302\242\n'
>> +cent_sign=`printf "$cent_sign_utf8_format"`
>> +print_at_sign='BEGIN {print substr("'$cent_sign'@", 2)}'
>> +at_sign=`$awk "$print_at_sign" </dev/null 2>/dev/null`
>> +if test "$at_sign" != @; then
>> + at_sign=`LC_ALL=en_US.UTF-8 $awk "$print_at_sign" </dev/null
>> 2>/dev/null`
>> + if test "$at_sign" = @; then
>> + LC_ALL=en_US.UTF-8
>> + else
>> + LC_ALL=C
>> + fi
>> + export LC_ALL
>> +fi
>> +
>> +exec $awk -v at_sign="$at_sign" -v cent_sign="$cent_sign" -v
>> file="$COMMIT_MSG_FILE" '
>
> You don't actually need any of this at_sign and cent_sign stuff here,
> right?
Well, I honestly don't know. I didn't want to break some odd emacs
development usecase, so I took that part of code from the current
`commit-msg`. And if you think it's unnecessary, then it's unnecessary
as well in the current `commit-msg`.
next prev parent reply other threads:[~2019-05-14 21:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-21 20:03 bug#35368: [PATCH] Do potentially destructive operations in prepare-commit-msg Konstantin Kharlamov
2019-04-21 20:17 ` bug#35368: [PATCH v2] " Konstantin Kharlamov
2019-05-14 17:33 ` npostavs
2019-05-14 21:22 ` Konstantin Kharlamov [this message]
2019-05-14 22:09 ` Noam Postavsky
2019-05-14 22:15 ` Konstantin Kharlamov
2019-05-14 22:26 ` bug#35368: [PATCH v3] " Konstantin Kharlamov
2019-05-15 17:40 ` npostavs
2019-05-15 21:25 ` bug#35368: [PATCH v4] " Konstantin Kharlamov
2019-05-17 0:35 ` Noam Postavsky
2019-05-17 0:39 ` Konstantin Kharlamov
2019-05-15 21:28 ` bug#35368: [PATCH v3] " Konstantin Kharlamov
[not found] ` <handler.35368.B.155587702222113.ack@debbugs.gnu.org>
2019-04-23 9:57 ` bug#35368: Acknowledgement ([PATCH] Do potentially destructive operations in prepare-commit-msg) Konstantin Kharlamov
2019-04-23 10:40 ` Eli Zaretskii
2019-04-23 10:43 ` Basil L. Contovounesios
2019-04-23 11:00 ` Konstantin Kharlamov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1557868922.32614.0@yandex.ru \
--to=hi-angel@yandex.ru \
--cc=35368@debbugs.gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.