From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.bugs Subject: bug#35062: [PATCH v3 2/3] constify a bit of xterm.c Date: Sat, 20 Apr 2019 13:31:44 +0300 Message-ID: <1555756304.18656.0@yandex.ru> References: <20190407021331.948-1-Hi-Angel@yandex.ru> <20190407021331.948-2-Hi-Angel@yandex.ru> <8336mml3s7.fsf@gnu.org> <1f700b05-16a8-1159-e2e3-61f9699981a1@cs.ucla.edu> <1555722559.16908.0@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="263530"; mail-complaints-to="usenet@blaine.gmane.org" Cc: eggert@cs.ucla.edu, 35062@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 20 12:32:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hHnI7-0016Qj-1D for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Apr 2019 12:32:15 +0200 Original-Received: from localhost ([127.0.0.1]:39695 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHnI5-0001jP-Q2 for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Apr 2019 06:32:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39561) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHnHv-0001i3-6Y for bug-gnu-emacs@gnu.org; Sat, 20 Apr 2019 06:32:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHnHu-0000aV-9Z for bug-gnu-emacs@gnu.org; Sat, 20 Apr 2019 06:32:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60519) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hHnHu-0000aF-6U for bug-gnu-emacs@gnu.org; Sat, 20 Apr 2019 06:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hHnHt-0003t6-UH for bug-gnu-emacs@gnu.org; Sat, 20 Apr 2019 06:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Apr 2019 10:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35062 X-GNU-PR-Package: emacs Original-Received: via spool by 35062-submit@debbugs.gnu.org id=B35062.155575631814935 (code B ref 35062); Sat, 20 Apr 2019 10:32:01 +0000 Original-Received: (at 35062) by debbugs.gnu.org; 20 Apr 2019 10:31:58 +0000 Original-Received: from localhost ([127.0.0.1]:45830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHnHq-0003sp-85 for submit@debbugs.gnu.org; Sat, 20 Apr 2019 06:31:58 -0400 Original-Received: from forward105j.mail.yandex.net ([5.45.198.248]:38189) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHnHm-0003sW-GI for 35062@debbugs.gnu.org; Sat, 20 Apr 2019 06:31:56 -0400 Original-Received: from mxback9g.mail.yandex.net (mxback9g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:170]) by forward105j.mail.yandex.net (Yandex) with ESMTP id 7BC4EB21E8B; Sat, 20 Apr 2019 13:31:46 +0300 (MSK) Original-Received: from smtp1o.mail.yandex.net (smtp1o.mail.yandex.net [2a02:6b8:0:1a2d::25]) by mxback9g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id Yj44XsVvp7-Vkua86P6; Sat, 20 Apr 2019 13:31:46 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1555756306; bh=iJUhfXshI+VVYMP4H4KAijMuDIRcQtfw6DAJFTY90d8=; h=In-Reply-To:Cc:To:Subject:From:References:Date:Message-Id; b=vqiCg5ng7rrqTZSHTpPHbk1e783YjTUM7gJiFG7juQtZlyHpUg67lf0tuhPwRS0H/ CXXeYKhGd1LhOKdfenUibbUcZjvNOTF29rOWOnNE7vKPjvhzUKQZmsRA9Uc+rhAvE0 m4NUEoj2rEqxQnFiMUDXnTwqnhemchOVysYcTe/s= Authentication-Results: mxback9g.mail.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: by smtp1o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id 2nE5Qh46Aa-Vi9auJFK; Sat, 20 Apr 2019 13:31:45 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) In-Reply-To: <83muklb20w.fsf@gnu.org> X-Mailer: geary/emphasize-participated-in~g736c62cb-dirty X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157888 Archived-At: On =F3=C2, Apr 20, 2019 at 09:53, Eli Zaretskii wrote: >> Date: Sat, 20 Apr 2019 04:09:19 +0300 >> From: Konstantin Kharlamov >> Cc: Eli Zaretskii , 35062@debbugs.gnu.org >>=20 >> And btw, current workflow with searching through the body doesn't=20 >> work >> well in vanilla Emacs. While other editors allow you to highlight >> matches by putting a caret over a symbol, Emacs requires either >> manually making it highlight/unhighlight, or installing a separate >> package highlight-symbol.el which is a bit buggy and wasn't updated >> since 2016. That is to say, having non-modified things declared with >> "const" may help an average Emacs developer. >=20 > I don't think I follow: Emacs's search commands do highlight the > matches, and we also have symbol-search commands ("M-s _" etc.), so > what exactly is missing? See: to any search a word in Emacs you have to either type it manually=20 or copy-paste it. And then if you get unlucky to have next match=20 offscreen, the search gonna carry currently visible portion of text=20 away. In other editors and IDEs it's implemented instead by selecting a word,=20 which makes the editor to highlight matches. That's similar to what=20 highlight-symbol.el is doing: you put a caret over a text, and after a=20 short timeout (IIRC you can't set timeout to 0 as it introduces lags to=20 Emacs) it highlights visible matches of the symbol under the caret. And=20 then, if you want to, you can press a hotkey to lock the highlight. =