From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.bugs Subject: bug#35062: [PATCH v3 1/3] Remove redundant comparison Date: Mon, 15 Apr 2019 20:29:03 +0300 Message-ID: <1555349343.24195.1@yandex.ru> References: <1554071761.31929.0@yandex.ru> <20190407021331.948-1-Hi-Angel@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="173852"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35062@debbugs.gnu.org, rms@gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 15 19:30:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hG5Qp-000j6P-SW for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Apr 2019 19:30:11 +0200 Original-Received: from localhost ([127.0.0.1]:53610 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG5Qo-0002jh-S0 for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Apr 2019 13:30:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42855) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG5Qh-0002jY-Oo for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 13:30:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hG5Qg-0000k8-Sa for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 13:30:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50040) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hG5Qg-0000jy-NE for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 13:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hG5Qg-00078p-Cy for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 13:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Apr 2019 17:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35062 X-GNU-PR-Package: emacs Original-Received: via spool by 35062-submit@debbugs.gnu.org id=B35062.155534935627352 (code B ref 35062); Mon, 15 Apr 2019 17:30:02 +0000 Original-Received: (at 35062) by debbugs.gnu.org; 15 Apr 2019 17:29:16 +0000 Original-Received: from localhost ([127.0.0.1]:35351 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hG5Pw-000774-6z for submit@debbugs.gnu.org; Mon, 15 Apr 2019 13:29:16 -0400 Original-Received: from forward103j.mail.yandex.net ([5.45.198.246]:57660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hG5Ps-00076h-RI for 35062@debbugs.gnu.org; Mon, 15 Apr 2019 13:29:14 -0400 Original-Received: from mxback16o.mail.yandex.net (mxback16o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::67]) by forward103j.mail.yandex.net (Yandex) with ESMTP id 70F5D6740381; Mon, 15 Apr 2019 20:29:06 +0300 (MSK) Original-Received: from smtp2o.mail.yandex.net (smtp2o.mail.yandex.net [2a02:6b8:0:1a2d::26]) by mxback16o.mail.yandex.net (nwsmtp/Yandex) with ESMTP id UYfxS4rNVG-T66C23ud; Mon, 15 Apr 2019 20:29:06 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1555349346; bh=em3+iRCAgFRoOvweevXIRYC4yv4XSowNSgU0vzXGfmg=; h=In-Reply-To:Cc:To:Subject:From:References:Date:Message-Id; b=wqdJIX6935cabsvVdr+cCMoevCQPjQv9aYsL5DChCCSaZHo9An9XxIL445hGd7ZKm S7Zp6UIfY2b6TiNUanG78l4mbLUL0iioJ4By8RlSJGIH4XIgZnCZu2+wzDekAU5Pc7 9k/YxxHDBGPbONHtwUmT/7Z2e0f2AIhsw4qpbYFU= Authentication-Results: mxback16o.mail.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: by smtp2o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id Nzk9d1gpI2-T5AinSWq; Mon, 15 Apr 2019 20:29:05 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) In-Reply-To: <837ebvi3yn.fsf@gnu.org> X-Mailer: geary/master~g59ef85ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157672 Archived-At: =F7 =F0=CE, =C1=D0=D2 15, 2019 at 20:16, Eli Zaretskii =20 =CE=C1=D0=C9=D3=C1=CC: >> Date: Mon, 15 Apr 2019 20:03:05 +0300 >> From: Konstantin Kharlamov >> Cc: rms@gnu.org, 35062@debbugs.gnu.org >>=20 >> > No, the log message was not the problem. Look at the code=20 >> changes, >> > they were the ones I modified. >>=20 >> The line that I changed is exactly the same. What you did is=20 >> cleaning >> up the function even further, however that didn't touch my >> modifications. Your modification is not strictly relevant to my=20 >> patch. >=20 > That's your perspective, but not mine. My perspective is that you > changed one line, whereas I changed 3, and by that also changed the > overall logic of the tests. Right, does that contradict to my statement? Your changes and mine are=20 independent entities that can exist one without the other. =