From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.bugs Subject: bug#35062: [PATCH v2] min_cols/rows is always 0, remove noop actions Date: Sun, 07 Apr 2019 05:03:33 +0300 Message-ID: <1554602613.12841.0@yandex.ru> References: <87ef6lic84.fsf@gmail.com> <20190402002327.28219-1-Hi-Angel@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1251; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="26307"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35062@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 07 04:04:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hCxAJ-0006gG-ET for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Apr 2019 04:04:11 +0200 Original-Received: from localhost ([127.0.0.1]:33058 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCxAI-0002xc-Fi for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Apr 2019 22:04:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCxAB-0002xV-HN for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2019 22:04:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hCxAA-00014T-AO for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2019 22:04:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34074) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hCxAA-00014O-5F for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2019 22:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hCxA9-0005PK-Vr for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2019 22:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Apr 2019 02:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35062 X-GNU-PR-Package: emacs Original-Received: via spool by 35062-submit@debbugs.gnu.org id=B35062.155460262820760 (code B ref 35062); Sun, 07 Apr 2019 02:04:01 +0000 Original-Received: (at 35062) by debbugs.gnu.org; 7 Apr 2019 02:03:48 +0000 Original-Received: from localhost ([127.0.0.1]:47618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCx9v-0005Om-Hy for submit@debbugs.gnu.org; Sat, 06 Apr 2019 22:03:47 -0400 Original-Received: from forward106o.mail.yandex.net ([37.140.190.187]:53376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCx9t-0005OY-1V for 35062@debbugs.gnu.org; Sat, 06 Apr 2019 22:03:46 -0400 Original-Received: from mxback2o.mail.yandex.net (mxback2o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::1c]) by forward106o.mail.yandex.net (Yandex) with ESMTP id 9E1F55060555; Sun, 7 Apr 2019 05:03:36 +0300 (MSK) Original-Received: from smtp3p.mail.yandex.net (smtp3p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:8]) by mxback2o.mail.yandex.net (nwsmtp/Yandex) with ESMTP id 4YORK7h2hO-3aFCO2hV; Sun, 07 Apr 2019 05:03:36 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1554602616; bh=/YBXyU1q1ILSgh3b8hyNYsS0GockMi0GOIJkIdMUgtU=; h=In-Reply-To:Cc:To:Subject:From:References:Date:Message-Id; b=tqFxJponiU5p3HfNpSKabdzCYEKPFOoRzrIzk5/9P3e8WINj1MmXSTPSL6uFb5ivW b+VMytDg/hjFH24docaJAlVuujn68NCdEpCnnFcn+aoyVWMCCf4zByooX/RwEQ185H kDTxjG4bwgev8DU5b6UyfFmZmBl8f4lCxBjHR4rk= Authentication-Results: mxback2o.mail.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: by smtp3p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id 92VBYhx9MY-3ZjuU0vN; Sun, 07 Apr 2019 05:03:35 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) In-Reply-To: <83zhp3a9up.fsf@gnu.org> X-Mailer: geary/master~g59ef85ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157295 Archived-At: =C2 =D1=E1, =E0=EF=F0 6, 2019 at 10:09, Eli Zaretskii =20 =ED=E0=EF=E8=F1=E0=EB: >> Date: Sat, 06 Apr 2019 01:18:38 +0300 >> From: Konstantin Kharlamov >> Cc: 35062@debbugs.gnu.org >>=20 >> >> * src/gtkutil.c: >> >> remove "always false" comparison >> >> remove multiplication by zero, it's a noop anyway >> >> remove min_cols and min_rows as it's now unused >> >> >> >> Fixes LGTM warnings: >> >> * Comparison is always false because min_cols <=3D 0. >> >> * Comparison is always false because min_rows <=3D 0. >> >> --- >> >> v2: remove the min_rows/min_cols whatsoever >> > >> > Thanks, pushed. Please in the future write the commit log=20 >> messages in >> > the ChangeLog-like style, see CONTRIBUTE for the details. I did=20 >> that >> > this time, you can look at what I pushed to see an example of that >> > style in action. >>=20 >> Thanks, so, I'm looking right now to modify the rest of series and >> resend it here, and=85 I think I miss something: the only=20 >> difference of >> my commit from CONTRIBUTE file is that I forgot to list the=20 >> functions >> changed. >=20 > That's right. And also the lack of the bug number, see below. >=20 >> I think I misunderstand something, because you completely rewrote=20 >> the >> commit messages compared to mine. Titles now are more vague, and for >> some reason you removed a note that one of patches fixes warnings in >> the code. >=20 > That's just my personal preferences of style, as there's always a > judgment call regarding the description of the changes. We don't have > to agree about that, and if your log message was in the right format, > I probably wouldn't have bothered changing their text. >=20 > I can explain my preference: your text described in a very detailed > form something that was acutely visible from the diffs themselves, > whereas my text only describes the motivation, leaving the rest to the > diffs which speak for themselves. Thanks! > The part about LGTM warnings didn't seem important enough to me: LGTM > is not a compiler, and without a reference to what it is, the text is > a small riddle in itself. More importantly, I don't think we need any > justification for removing variables initialized to zero and never > changed. Well, one can find what LGTM through a search engine, or for that=20 matter by using "BUG#XXX" to find this discussion. But whatever. > Again, these are my personal preferences, not something we require > from each contributor. So if you disagree, you can keep your style, > and only adjust the form. >=20 >> And then you also added "Bug#35062", even though there's no >> bug (the report existence is incidental, it's because bugtracker is >> used to track patches in Emacs. >=20 > References to bug numbers should always be in the log message, because > that allows an easy way of reading relevant discussions recorded by > the bug tracker. This _is_ in CONTRIBUTE, btw. Oh, thanks, I missed that. >> But writing "Bug" will only confuse readers =97 there's no bug). >=20 > "Bug" here doesn't mean a literal bug, it means an issue recorded by > the bug tracker. I see, still it doesn't mean arbitrary readers won't be confused.=20 git-logs are being read by lots of different people, most of them are=20 not even contributors, could be e.g. users wondering whether it's worth=20 to re-build their Emacs-from-git. =