From: Konstantin Kharlamov <hi-angel@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line
Date: Sun, 17 Mar 2019 00:12:36 +0300 [thread overview]
Message-ID: <1552770756.27232.0@yandex.ru> (raw)
In-Reply-To: <83lg1eyecw.fsf@gnu.org>
В Сб, мар 16, 2019 at 7:26 ПП (PM), Eli Zaretskii
<eliz@gnu.org> написал:
>> Date: Sat, 16 Mar 2019 18:42:44 +0300
>> From: Konstantin Kharlamov <hi-angel@yandex.ru>
>> Cc: emacs-devel@gnu.org
>>
>> >> - (and (eq selective-display t)
>> >> - (looking-at "\^m")
>> >> - (forward-char 1))
>> >> (beginning-of-line)))
>> >
>> > Did you actually try this change with selective-display in effect?
>> > Because I'm not sure it is correct in that case.
>> >
>> > Thanks.
>>
>> Hmm… I will try a bit later, but the code seems really
>> straightforward:
>> 1. if current character is ^M, then step forward
>> 2. step to the beginnig of the line
>>
>> The 2 undoes 1.
>
> ^M has special meaning in selective-display mode.
Thanks, so, I just tried playing with the mode, and I haven't even
found ^M anywhere. I wonder if the ^M being added by the mode is in the
past, that just no longer happening.
Specifically, I did:
1. wrote in scratch buffer
test
test
test
2. evaluated (set-selective-display 1) which transformed the look of
the text to
test...
3.α Tried searching for ^M by pressing C-s C-q C-m. It's failing to
find anything.
3.β Put the caret before the triple dot, as in "test|...", and
evaluated (char-after (point)) and (char-after (+ 1 (point))). The
first returns "C-j" character, i.e. a newline; the second returns
"space character". They're both the exact characters that actually are
in text, as if I didn't enable selective-display.
So, even disregarding my patches (because I haven't managed to test
this possible corner-case), the need for ^M workarounds is just no
longer needed.
next prev parent reply other threads:[~2019-03-16 21:12 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-16 1:53 [PATCH 1/3] lisp/progmodes/etags.el clean up code by removing a temporary Konstantin Kharlamov
2019-03-16 1:53 ` [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line Konstantin Kharlamov
2019-03-16 12:43 ` Eli Zaretskii
2019-03-16 15:42 ` Konstantin Kharlamov
2019-03-16 16:00 ` Stefan Monnier
2019-03-16 16:26 ` Eli Zaretskii
2019-03-16 21:12 ` Konstantin Kharlamov [this message]
2019-03-16 21:47 ` Konstantin Kharlamov
2019-03-17 3:36 ` Eli Zaretskii
2019-03-17 3:41 ` Konstantin Kharlamov
2019-03-17 15:17 ` Eli Zaretskii
2019-03-17 15:52 ` Stefan Monnier
2019-03-17 16:13 ` Eli Zaretskii
2019-03-17 17:36 ` Stefan Monnier
2019-03-17 21:14 ` Eradicating selective-display == t (was: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line) Stefan Monnier
2019-03-17 21:32 ` Konstantin Kharlamov
2019-03-18 1:12 ` Eradicating selective-display == t Stefan Monnier
2019-03-18 9:16 ` Konstantin Kharlamov
2019-03-18 12:10 ` Stefan Monnier
2019-03-17 19:06 ` [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line Konstantin Kharlamov
2019-03-17 19:22 ` Eli Zaretskii
2019-03-17 19:29 ` Konstantin Kharlamov
2019-03-17 20:21 ` Eli Zaretskii
2019-03-17 20:27 ` Konstantin Kharlamov
2019-03-17 20:40 ` Eli Zaretskii
2019-03-17 20:44 ` Konstantin Kharlamov
2019-03-18 3:34 ` Eli Zaretskii
2019-03-18 9:43 ` Konstantin Kharlamov
2019-03-18 9:57 ` Konstantin Kharlamov
2019-03-18 17:00 ` Eli Zaretskii
2019-03-18 19:15 ` Konstantin Kharlamov
2019-03-18 19:25 ` Konstantin Kharlamov
2019-03-18 20:16 ` Eli Zaretskii
2019-03-18 21:45 ` Konstantin Kharlamov
2019-03-18 23:13 ` Konstantin Kharlamov
2019-03-18 23:38 ` Konstantin Kharlamov
2019-03-19 1:46 ` Stefan Monnier
2019-03-19 6:47 ` Eli Zaretskii
2019-03-16 1:53 ` [PATCH 3/3] lisp/progmodes/etags.el improve match by string trimming Konstantin Kharlamov
2019-03-16 2:13 ` [PATCH v2] " Konstantin Kharlamov
2019-03-16 12:46 ` Eli Zaretskii
2019-03-16 15:38 ` Konstantin Kharlamov
2019-03-16 16:29 ` Eli Zaretskii
2019-03-17 2:38 ` [PATCH v3] " Konstantin Kharlamov
2019-03-19 6:55 ` [PATCH v2] lisp/progmodes/etags.el clean up code by removing a temporary Konstantin Kharlamov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1552770756.27232.0@yandex.ru \
--to=hi-angel@yandex.ru \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.