all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: John Lee <jjl@pobox.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: org-habit: allow overriding org-scheduled-past-days and always including time of day
Date: Sun, 03 Feb 2019 15:53:11 +0000	[thread overview]
Message-ID: <1549209191.1791775.1649835912.01048935@webmail.messagingengine.com> (raw)
In-Reply-To: <87k1ladke0.fsf@nicolasgoaziou.fr>

On Sun, 18 Nov 2018, at 23:40, Nicolas Goaziou wrote:
> * lisp/org-habit.el (org-habit-scheduled-past-days): New variable.
> 
> >  	    (when (or (and (> ddays 0) (< diff ddays))
> > -		      (> diff org-scheduled-past-days)
> > +		      (> diff (if habitp
> > +				  (or org-habit-scheduled-past-days
> > +				      org-scheduled-past-days)
> > +				org-scheduled-past-days))
> 
> Nitpick:
> 
>     (or (and habitp org-habit-scheduled-past-days)
>         org-scheduled-past-days)

Oops, I just remembered that 0 is not "falsy" in elisp.  So I'll make this change after all and submit that first patch again, again...

      parent reply	other threads:[~2019-02-03 15:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-05  0:31 org-habit: allow overriding org-scheduled-past-days and always including time of day John Lee
2018-11-05 13:01 ` [PATCH] " John Lee
2018-11-18 23:40 ` Nicolas Goaziou
2019-02-02 18:50   ` John Lee
2019-02-02 21:45     ` Nicolas Goaziou
2019-02-03 15:53   ` John Lee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1549209191.1791775.1649835912.01048935@webmail.messagingengine.com \
    --to=jjl@pobox.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.