From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Brian Leung Newsgroups: gmane.emacs.bugs Subject: bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map Date: Mon, 19 Jul 2021 16:57:11 +0200 (CEST) Message-ID: <1533263297.2069981.1626706630967@ichabod.co-bxl> References: <89178870.2006793.1626665845848@ichabod.co-bxl> <87eebupi5k.fsf@gnus.org> <835yx678fj.fsf@gnu.org> Reply-To: Brian Leung Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26722"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 49632@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 19 16:58:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5Uij-0006jd-Li for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Jul 2021 16:58:13 +0200 Original-Received: from localhost ([::1]:38536 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5Uii-0005zL-Lv for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Jul 2021 10:58:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38844) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5UiY-0005wy-Kr for bug-gnu-emacs@gnu.org; Mon, 19 Jul 2021 10:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48215) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m5UiY-00044H-D7 for bug-gnu-emacs@gnu.org; Mon, 19 Jul 2021 10:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m5UiY-00065O-9a for bug-gnu-emacs@gnu.org; Mon, 19 Jul 2021 10:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Brian Leung Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Jul 2021 14:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49632-submit@debbugs.gnu.org id=B49632.162670664223341 (code B ref 49632); Mon, 19 Jul 2021 14:58:02 +0000 Original-Received: (at 49632) by debbugs.gnu.org; 19 Jul 2021 14:57:22 +0000 Original-Received: from localhost ([127.0.0.1]:59760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5Uhu-00064O-2d for submit@debbugs.gnu.org; Mon, 19 Jul 2021 10:57:22 -0400 Original-Received: from wilbur.contactoffice.com ([212.3.242.68]:47094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5Uhs-00064B-Hd for 49632@debbugs.gnu.org; Mon, 19 Jul 2021 10:57:20 -0400 Original-Received: from ichabod.co-bxl (ichabod.co-bxl [10.2.0.36]) by wilbur.contactoffice.com (Postfix) with ESMTP id CA59BCBC; Mon, 19 Jul 2021 16:57:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1626706634; s=20210208-e7xh; d=mailfence.com; i=leungbk@mailfence.com; h=Date:From:Reply-To:Cc:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding; l=1991; bh=4zQY8wpeJYLkbR59uYiXnVr5bEwUH9pmda65AF3Tnq0=; b=VgRK3Q84YPeBLhAczk/qPeUCkmuUlgAnL8SWdi+qQYaf1HC2O4rVnk9iH5mu3PK/ QQNdUgvLJllACyViTRGozuvFqTC1/WB/5lq6udqv/XkYxT/hqT39QfsJDnleOjFAww4 w+gWkDR4j/Bb5n0Fc6dqsp0fOyGYmxqe7jexhfWha3BPwLz8T1szFAxb6hT8dUBBIKQ ChlRKjEbayg+LBOkBBKT0qarwxZIuuhl7NuwVdnab0MqXRgqm3socp5QRXXr9Xa8TP6 7ZBST+uWSVUPnydJIwPA2Igz+PdOFXXzCI6fDJvGeBObqDzi+FKm5IPhEqSAAaGqb34 IoYCAI35PA== In-Reply-To: <835yx678fj.fsf@gnu.org> X-Priority: 3 X-Mailer: ContactOffice Mail X-ContactOffice-Account: com:225491745 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210252 Archived-At: > I admit I don't understand the rationale for the patch at all. > "M-x gdb" already repeats these commands when you type just RET > into the interaction buffer, so what exactly does this change > do, and how can I see its effect? RET can repeat only the last command (afaik). If instead I want to run, in = order: 1. continue 2. next 3. next 4. stepi then without this patch, I would need to press 1. C-x C-a C-r 2. C-x C-a C-n 3. C-x C-a C-n 4. C-x C-a C-i if using M-x gdb. With the patch, I can press: 1. C-x C-a C-r 2. n 3. n 4. i since the new repeat-mode defines the appropriate repeat map. > ---------------------------------------- > From: Eli Zaretskii > Sent: Mon Jul 19 15:13:52 CEST 2021 > To: Lars Ingebrigtsen > Cc: , <49632@debbugs.gnu.org>, > Subject: Re: bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-= map >=20 >=20 > > From: Lars Ingebrigtsen > > Date: Mon, 19 Jul 2021 15:06:31 +0200 > > Cc: 49632@debbugs.gnu.org, Juri Linkov > >=20 > > Brian Leung writes: > >=20 > > > * lisp/progmodes/gdb-mi.el (gdb): Populate gud-repeat-map. This is > > > copied from the gud-gdb command. > >=20 > > Instead of copying the code, perhaps it should be separated out into it= s > > own function and then called from both places? > >=20 > > But I don't quite understand why gud-repeat-map is populated in the > > normal way -- i.e., in `gud-repeat-map' so that users can > > redefine/override entries as usual. >=20 > I admit I don't understand the rationale for the patch at all. > "M-x gdb" already repeats these commands when you type just RET > into the interaction buffer, so what exactly does this change > do, and how can I see its effect? --=C2=A0 Sent with https://mailfence.com Secure and private email --=20 Mailfence.com Private and secure email