all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nikolaus Rath <nikolaus@rath.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Andreas Schwab <schwab@suse.de>, 21057@debbugs.gnu.org
Subject: bug#21057: [PATCH] nnimap.el: add support for IMAP namespaces
Date: Tue, 03 Jul 2018 08:40:59 +0100	[thread overview]
Message-ID: <1530603659.1377875.1428249096.0D7BA8A9@webmail.messagingengine.com> (raw)
In-Reply-To: <1527766712.3634038.1391649040.3CF55CA8@webmail.messagingengine.com>

*ping*

Could someone take a look at the revised patch?

Thanks!
-Nikolaus

--
GPG Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F

             »Time flies like an arrow, fruit flies like a Banana.«

On Thu, 31 May 2018, at 12:38, Nikolaus Rath wrote:
> Hi,
> 
> On Wed, 27 Dec 2017, at 22:10, Lars Ingebrigtsen wrote:
> > Looks good, but a couple of niggles:
> > 
> > > +(setq nnimap-namespaces nil)
> > 
> > This should be a defvar, or rather, a defvoo.
> > 
> > [...]
> > 
> > > +  (let* ((prefix (cadr (assoc (nnoo-current-server 'nnimap)
> > > +                              nnimap-namespaces)))
> > > +         (inbox (substring prefix 0 -1)))
> > 
> > And then you could just set nnimap-namespaces without maintaining a
> > per-server alist, since that's what the voo machinery does for you
> > (switching out variables on a per-server basis).
> 
> Updated patches attached (and rebased onto current master).
> 
> Best,
> -Nikolaus
> 
> --
> GPG Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F
> 
>              »Time flies like an arrow, fruit flies like a Banana.«
> Email had 3 attachments:
> + 0001-nnimap.el-factor-out-nnimap-group-to-imap.patch
>   9k (text/x-patch)
> + 0002-nnimap.el-Add-support-for-IMAP-namespaces.patch
>   10k (text/x-patch)
> + 0003-Turn-nnimap-namespaces-into-a-defvoo-to-make-it-per-.patch
>   4k (text/x-patch)





  reply	other threads:[~2018-07-03  7:40 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-13  1:52 bug#21057: [PATCH] nnimap.el: add support for IMAP namespaces Nikolaus Rath
2017-01-26 19:40 ` Lars Ingebrigtsen
2017-09-05 15:18 ` Nikolaus Rath
2017-09-05 15:26   ` Nikolaus Rath
2017-09-05 15:36     ` Andreas Schwab
2017-09-07 16:01       ` Nikolaus Rath
2017-09-13 17:30         ` Lars Ingebrigtsen
2017-09-17  8:16           ` Nikolaus Rath
2017-12-06 14:25             ` Nikolaus Rath
2017-12-27 21:10             ` Lars Ingebrigtsen
2018-05-31 11:38               ` Nikolaus Rath
2018-07-03  7:40                 ` Nikolaus Rath [this message]
2018-07-07  9:12                   ` Eli Zaretskii
2018-07-17 19:43                     ` Nikolaus Rath
2018-07-20  9:43                       ` Eli Zaretskii
2018-07-20 19:16                         ` Nikolaus Rath
2018-07-20 19:50                           ` Eli Zaretskii
2018-07-22 13:31                 ` Lars Ingebrigtsen
2018-07-23  6:00                   ` Eric Abrahamsen
2018-07-23  7:03                     ` Lars Ingebrigtsen
2018-07-23  7:22                       ` Nikolaus Rath
2018-07-23  7:39                         ` Lars Ingebrigtsen
2018-07-23  8:58                           ` Nikolaus Rath
2018-07-23  9:00                             ` Lars Ingebrigtsen
2018-07-23  9:01                             ` Lars Ingebrigtsen
2018-07-23  9:53                               ` Nikolaus Rath
2018-07-23 11:28                                 ` Robert Pluim
2018-07-23 18:00                                   ` Nikolaus Rath
2018-07-27  7:54                                     ` Nikolaus Rath
2018-08-05  9:54                                       ` Nikolaus Rath
2018-08-11  7:49                                         ` Eli Zaretskii
2018-07-23 16:47                                 ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1530603659.1377875.1428249096.0D7BA8A9@webmail.messagingengine.com \
    --to=nikolaus@rath.org \
    --cc=21057@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.