From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#15899: 24.3.50; regression: `region' overlay is lower priority than default Date: Fri, 15 Nov 2013 07:51:38 -0800 (PST) Message-ID: <1519bff5-bf9d-42bc-8993-d96153f0004f@default> References: <20137354-f982-4314-9c09-21a5fbc36557@default> <83ob5mi02j.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1384530740 22735 80.91.229.3 (15 Nov 2013 15:52:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 15 Nov 2013 15:52:20 +0000 (UTC) Cc: 15899@debbugs.gnu.org To: Stefan Monnier , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 15 16:52:24 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VhLgx-0002K3-P8 for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Nov 2013 16:52:20 +0100 Original-Received: from localhost ([::1]:60901 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhLgx-0002m6-9E for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Nov 2013 10:52:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhLgn-0002lm-Jd for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2013 10:52:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VhLgg-0007St-EN for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2013 10:52:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42081) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhLgg-0007Sm-An for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2013 10:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VhLgf-0006UV-T8 for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2013 10:52:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Nov 2013 15:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15899 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15899-submit@debbugs.gnu.org id=B15899.138453071224933 (code B ref 15899); Fri, 15 Nov 2013 15:52:01 +0000 Original-Received: (at 15899) by debbugs.gnu.org; 15 Nov 2013 15:51:52 +0000 Original-Received: from localhost ([127.0.0.1]:56100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VhLgV-0006U5-Gj for submit@debbugs.gnu.org; Fri, 15 Nov 2013 10:51:51 -0500 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:21293) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VhLgS-0006Tp-CJ for 15899@debbugs.gnu.org; Fri, 15 Nov 2013 10:51:48 -0500 Original-Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id rAFFpfKx024428 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 15 Nov 2013 15:51:42 GMT Original-Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rAFFpdpm000092 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 15 Nov 2013 15:51:40 GMT Original-Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rAFFpdFN025447; Fri, 15 Nov 2013 15:51:39 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:80600 Archived-At: > > In Emacs 24.3, the region highlight was not done by an overlay, > > but by special code in C. Now it is an overlay, so the issue > > of priority creeps in. >=20 > Indeed. OTOH, I'm not convinced it's a bug, since this "bug" was > also the fix for another bug. Which other bug? Was that bug there ever since the Emacs region could be highlighted (i.e., several decades old)? Or was that bug introduced recently, as the result of some other change? Maybe there is more than one change that needs to be reverted? Oh, I see that Dmitry has now answered that question:=20 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D15618 Which was NOT a bug, IMO. It should not have been "fixed". The fact that face `region' highlights "on top of" other highlighting is _on purpose_, i.e., by design. Countering that is folly, IMO. What next? Someone wants to see "theme" highlighting on top of Isearch overlays? And someone eagerly jumps in to "fix" that "bug" too? > It's a change, there's no doubt about that. Whether it's better > or worse is not so clear. Are you saying that you think it might not be a bug (regression) to use an overlay rather than a text property? That would be a reasonable question. Or are you suggesting that it might not be a bug that selecting text does not show the selection face throughout the selection? The latter would be unreasonable. When you select text you should always be able to see which text you selected - all of it, even if it is only one character. This should be a no-brainer. The whole point of having a `region' face is to highlight what is in the region. (FWIW, I'm not sure I'm in favor of the change to using an overlay from using a text property either, but that is not what this bug report is about. Using the region to select text, and then replacing face `region' text property with another face or another text property, or otherwise making use of the property, can be useful. Sure, you can make do without `region' as a text property, but why should you have to? Why did this behavior suddenly need to be changed, after four decades or so of use?) Please: 1. If you keep the use of an overlay, at *least* give users a choice (e.g. a user option) of whether face `region' is to be applied as a text property or used for an overlay. 2. When it is used for an overlay, please make its priority higher than others, with the exception of isearch overlays (yes, there can sometimes be a use for continuing to show the region while isearching). If there are any other exceptions needed to bring the behavior back to pre-regression, those would apply also. (I can't think of any other exceptions, right now). These kinds of changes should first be the subject of proposal and discussion in emacs-devel, and perhaps a user poll. They should not be made willy nilly when fixing a bug. IMHO.