From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Newsgroups: gmane.emacs.bugs Subject: bug#30377: 27.0.50; Missing and misspelled SHR/CSS colors Date: Wed, 07 Feb 2018 10:45:02 +0100 Message-ID: <1517996702.2358.0@smtp.gmail.com> References: <87eflxii72.fsf@tcd.ie> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="=-nFVcLn3ohlF64kYmLSYL" X-Trace: blaine.gmane.org 1517996680 1832 195.159.176.226 (7 Feb 2018 09:44:40 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 7 Feb 2018 09:44:40 +0000 (UTC) Cc: Julien Danjou , Tom Tromey , 30377@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 07 10:44:35 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ejMH0-0007Sd-1K for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 Feb 2018 10:44:14 +0100 Original-Received: from localhost ([::1]:42367 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejMJ1-0003Pg-6D for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 Feb 2018 04:46:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40245) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejMIp-0003LE-LA for bug-gnu-emacs@gnu.org; Wed, 07 Feb 2018 04:46:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ejMIk-0001Ae-O1 for bug-gnu-emacs@gnu.org; Wed, 07 Feb 2018 04:46:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52988) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ejMIk-0001AF-K9 for bug-gnu-emacs@gnu.org; Wed, 07 Feb 2018 04:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ejMIk-0008Tg-A2 for bug-gnu-emacs@gnu.org; Wed, 07 Feb 2018 04:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Feb 2018 09:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30377 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 30377-submit@debbugs.gnu.org id=B30377.151799671432519 (code B ref 30377); Wed, 07 Feb 2018 09:46:02 +0000 Original-Received: (at 30377) by debbugs.gnu.org; 7 Feb 2018 09:45:14 +0000 Original-Received: from localhost ([127.0.0.1]:60885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ejMHy-0008SR-Ee for submit@debbugs.gnu.org; Wed, 07 Feb 2018 04:45:14 -0500 Original-Received: from mail-lf0-f43.google.com ([209.85.215.43]:42098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ejMHw-0008S9-5U for 30377@debbugs.gnu.org; Wed, 07 Feb 2018 04:45:12 -0500 Original-Received: by mail-lf0-f43.google.com with SMTP id q17so407256lfa.9 for <30377@debbugs.gnu.org>; Wed, 07 Feb 2018 01:45:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=3XON7dBdw7aXJe6kJK9BeAEriciaD1OagMyzITnpqEU=; b=VOAo+iOq88BUGmN1zyNdwypohVk5DJqPVw797TXNBaDG5e0YNztW7NwgJ4/bgfnKmj bBQ+FQIafuhRgEGElt3ijknK1Q9gCoSa54gKmSoP4g4+usmcFlL5+R0PChlf/luF/kKU KwdTJeIQFa1SE9IwOSo1+NLyri6ZBA49T0hpsEU4yUsMk7nvI3k1+9N8VsdjM1SCSFOK CAAmMfu1iEjdlG7dbWik4yjP5BLBZk+O1oE35AR4YVCZGo+MRKJ8GH53Gg+9jXKPdhPi wjTYoHiggDezs0rRQmQ5EBTn712rFEquMgYN4+2iIHVuAj7fzU/bYOdUf3nlVlF+vn/8 N6ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=3XON7dBdw7aXJe6kJK9BeAEriciaD1OagMyzITnpqEU=; b=su96kTYzoOxzGgh8cmI8MkDNvQImB41K1HyviLgiy21Nel86HPgU1VvBMpAvhqsFia XDaDSAxe9Q4radEpoS3gHQye/TAzHGDmJ5ast5cGmhipWk6QWK1CzpwejtHaZObpk9tJ CANajW0SfI+TLyOClgwTWxoc/zjBhH6fmAN0JjpQr8iqswtlHRlYYNgE7bre4KxsVbmA esXUTthp4rMFt5WuWFhAFKjeak41xMAE6QyHbDOiSE04mZb3mh0Mv+4Fth93nd/tlQ7+ Dt8htEOFn14fASLz5iO4KrpWJxl6y9bnfmNg61G/picdpapdsTmAeXnMUi9+Jmq62nLi S/JA== X-Gm-Message-State: APf1xPCxwwOEsfIWFjCpEIu4PRCkN+7q4qKx/4ATDji/kU0qo0rqcC58 /hmd66oZVTYhEmeN5/uX3Vk= X-Google-Smtp-Source: AH8x224YiDGy2ZTwBKhyfoEQ4UisFmaGenWmdbdAY24N3XG/x9utWHd1ADMj+Xqth0ExRNTNFg63fA== X-Received: by 10.25.75.132 with SMTP id y126mr3714013lfa.122.1517996706034; Wed, 07 Feb 2018 01:45:06 -0800 (PST) Original-Received: from [10.0.1.70] (2.54.213.193.static.cust.telenor.com. [193.213.54.2]) by smtp.gmail.com with ESMTPSA id l6sm196843ljb.80.2018.02.07.01.45.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 Feb 2018 01:45:05 -0800 (PST) In-Reply-To: <87eflxii72.fsf@tcd.ie> X-Mailer: geary/0.12-dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143003 Archived-At: --=-nFVcLn3ohlF64kYmLSYL Content-Type: text/plain; charset=us-ascii; format=flowed Thanks Basil, good catches. The patch looks good to me. I suppose it's OK for emacs-26, Eli? I agree that it looks like the two color lists can easily be unified later and that there seems to be more opportunities for reuse by css-mode.el in shr-color.el. -- Simen --=-nFVcLn3ohlF64kYmLSYL Content-Type: text/html; charset=us-ascii
Thanks Basil, good catches. The patch looks good to me. I suppose it's
OK for emacs-26, Eli?

I agree that it looks like the two color lists can easily be unified
later and that there seems to be more opportunities for reuse by
css-mode.el in shr-color.el.

-- Simen
--=-nFVcLn3ohlF64kYmLSYL--