From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Reitter Newsgroups: gmane.emacs.devel Subject: Re: Apparent regression on the undo command Date: Sat, 21 Nov 2015 19:55:22 -0500 Message-ID: <1512E415-81ED-4C4D-B03E-4ED0EE29D34C@gmail.com> References: <87bnarsdfy.fsf@russet.org.uk> <871tbm9v83.fsf@russet.org.uk> <87wpte6slz.fsf@russet.org.uk> <87io4xpio3.fsf@red-bean.com> <87y4drllg8.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Mac OS X Mail 9.0 \(3094\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1448153763 29983 80.91.229.3 (22 Nov 2015 00:56:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 22 Nov 2015 00:56:03 +0000 (UTC) Cc: 21968@debbugs.gnu.org, emacs-devel To: Phillip Lord Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 22 01:55:48 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a0IwU-0005RT-So for ged-emacs-devel@m.gmane.org; Sun, 22 Nov 2015 01:55:47 +0100 Original-Received: from localhost ([::1]:54305 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0IwU-0006qG-BC for ged-emacs-devel@m.gmane.org; Sat, 21 Nov 2015 19:55:46 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59960) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0IwC-0006pp-8c for emacs-devel@gnu.org; Sat, 21 Nov 2015 19:55:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0Iw9-0001iK-2Q for emacs-devel@gnu.org; Sat, 21 Nov 2015 19:55:28 -0500 Original-Received: from mail-qg0-x232.google.com ([2607:f8b0:400d:c04::232]:34244) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0Iw8-0001i5-To for emacs-devel@gnu.org; Sat, 21 Nov 2015 19:55:24 -0500 Original-Received: by qgeb1 with SMTP id b1so96079174qge.1 for ; Sat, 21 Nov 2015 16:55:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=omGASVBu+9inUdB9x/GQeNM3o+xKamoRdtb01sKDQng=; b=akntxyS6Zvrb+OrAM55QbX3+yKPqNqsHliPs6Xv4cwhi6br9h56MHJFmHDezcSxchs LWiuPm1ZPsgLYSbXzcqDAh+5tfUIVqXJGEO5n24oyqN4xSMwMl7GJCxrH1KgvhJpQ4nD Uut9K1VXDgTLkbRA8WHpDmuBrYqxrmind0y1RC5GLjd0qD4ntKiggoK2SkQoGceln7Er wh4ylnmvKBVHEgDeiiKbTOSMrWHJpU3/emaq7YYeDqMzqMUdXa8L4cXoVP+k+IPtJGCY GnhWl4b+XPSQs8WxQah2402UdOcx4eSnd5RXasuhFYAkCvYkE3CoX0fUrDO7OHaUznj+ VYuw== X-Received: by 10.140.31.73 with SMTP id e67mr21032398qge.46.1448153724409; Sat, 21 Nov 2015 16:55:24 -0800 (PST) Original-Received: from [10.0.1.23] (c-71-58-212-112.hsd1.pa.comcast.net. [71.58.212.112]) by smtp.gmail.com with ESMTPSA id c48sm1450950qge.49.2015.11.21.16.55.22 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 21 Nov 2015 16:55:23 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3094) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c04::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194973 Archived-At: Phil, I tried your fix. It works for backward-kill-word, but for kill-word = (forward), the cursor ends up in the wrong place (after the word, not = where it was initially). - David > On Nov 21, 2015, at 6:18 AM, Artur Malabarba = wrote: >=20 > I can't speak for the code, but I just tested your fix and looks like = it works. >=20 > Thanks Phil. >=20 > 2015-11-21 10:02 GMT+00:00 Phillip Lord : >=20 > I have a possible fix for this now, currently on the > branch fix/undo-point-in-wrong-place. I waiting for some other = feedback > on my code before I squash and merge it, but if you have the chance it > would be good to know if it works. >=20 > Phil >=20 >=20 > Artur Malabarba writes: >=20 > > No problem Phil. > > Thanks for looking into this. > > On 20 Nov 2015 7:51 am, "Phillip Lord" = wrote: > > > >> > >> It is my commit after all. I will work on it as soon as I can. Had = a nasty > >> cold for the last few days. > >> > >> Phil > >> ________________________________________ > >> From: emacs-devel-bounces+phillip.lord=3Dnewcastle.ac.uk@gnu.org > >> [emacs-devel-bounces+phillip.lord=3Dnewcastle.ac.uk@gnu.org] on = behalf of > >> Karl Fogel [kfogel@red-bean.com] > >> Sent: 20 November 2015 01:24 > >> To: Phillip Lord > >> Cc: Artur Malabarba; emacs-devel > >> Subject: Re: Apparent regression on the undo command > >> > >> phillip.lord@russet.org.uk (Phillip Lord) writes: > >> >Artur Malabarba writes: > >> >> 2015-11-19 9:47 GMT+00:00 Phillip Lord = : > >> >>> I'll try and see if I can automate the problem and > >> >>> run a bisect. > >> >> > >> >> The following works for me. When called on the *scratch* buffer = it > >> >> returns non-nil if the problem occurs. > >> >> > >> >> (progn > >> >> (kmacro-call-macro nil nil nil [134217788 11 14 14 11 = 67108911]) > >> >> (equal (point-min) (point))) > >> >> > >> >> That macro simply calls M-< C-k C-n C-n C-k C-/ > >> > > >> > > >> >I tried various combinations -- works interactively but fails in = batch > >> >either because *scratch* hasn't been initialized, or undo appears = to > >> >work wrongly. > >> > > >> >No worries, it's easy enough to test by hand, and am doing so. > >> > >> Any luck? FWIW I'm noticing the bug too, in emacs-25 branch built = from > >> commit c210b8b128c. > >> > >> Best regards, > >> -Karl > >> > >> >=20