From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Rankin Newsgroups: gmane.emacs.bugs Subject: bug#28844: 26.0.90; display-line-numbers-mode should call window-configuration-change-hook Date: Sun, 10 Dec 2017 01:30:41 +1000 Message-ID: <1512833441.1115759.1199488160.6523D7E7@webmail.messagingengine.com> References: <1508054203.3504379.1139170720.0D0E99E9@webmail.messagingengine.com> <59E32D49.4030007@gmx.at> <1508065717.3534312.1139251176.600E646A@webmail.messagingengine.com> <59E350AE.3060005@gmx.at> <1508074073.3557079.1139314312.4BFE5BC2@webmail.messagingengine.com> <83o9p8h2yv.fsf@gnu.org> <1508124120.3709085.1139805520.1F653A1C@webmail.messagingengine.com> <87efq37knc.fsf@gmail.com> <1508130850.3734431.1139876192.21CE8281@webmail.messagingengine.com> <83zi8rf8rx.fsf@gnu.org> <1508200557.2705080.1141019864.6A2B8BD5@webmail.messagingengine.com> <83bml6fqbv.fsf@gnu.org> <1508213954.647567.1141167720.1CC00459@webmail.messagingengine.com> <06925BCF-6C99-423B-AB13-E7331E22B867@gnu.org> <1508224426.2790345.1141279648.61B955E6@webmail.messagingengine.com> <87a7yuey7i.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1512833469 24915 195.159.176.226 (9 Dec 2017 15:31:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 9 Dec 2017 15:31:09 +0000 (UTC) To: Noam Postavsky , Eli Zaretskii , 28844@debbugs.gnu.org, agrambot@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 09 16:31:05 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNh5k-0006LC-4q for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Dec 2017 16:31:04 +0100 Original-Received: from localhost ([::1]:41725 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eNh5r-0008D7-Au for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Dec 2017 10:31:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55296) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eNh5l-0008D1-SJ for bug-gnu-emacs@gnu.org; Sat, 09 Dec 2017 10:31:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eNh5h-0005EO-UH for bug-gnu-emacs@gnu.org; Sat, 09 Dec 2017 10:31:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45314) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eNh5h-0005EK-Pw for bug-gnu-emacs@gnu.org; Sat, 09 Dec 2017 10:31:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eNh5h-0002dF-J7 for bug-gnu-emacs@gnu.org; Sat, 09 Dec 2017 10:31:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Paul Rankin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Dec 2017 15:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28844 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28844-submit@debbugs.gnu.org id=B28844.151283344510094 (code B ref 28844); Sat, 09 Dec 2017 15:31:01 +0000 Original-Received: (at 28844) by debbugs.gnu.org; 9 Dec 2017 15:30:45 +0000 Original-Received: from localhost ([127.0.0.1]:53995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNh5Q-0002ck-Ni for submit@debbugs.gnu.org; Sat, 09 Dec 2017 10:30:44 -0500 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:59573) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNh5P-0002cd-Eu for 28844@debbugs.gnu.org; Sat, 09 Dec 2017 10:30:43 -0500 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 1B5242012A; Sat, 9 Dec 2017 10:30:42 -0500 (EST) Original-Received: from web5 ([10.202.2.215]) by compute3.internal (MEProxy); Sat, 09 Dec 2017 10:30:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paulwrankin.com; h=content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=f6OSkLkcqjzHHYtSkZatBigfMp4TC 8UklzMzE7kkSDg=; b=qmls8y/NtA0hn24KGEXdA64cJU41cGtwMSIguCv0DdEZ6 jdIGBn3PQIcGGrUYoZIl9bquJ53m2xVdCNT2B0L4UxJC+I3P72y/Yirgj9kze8PV Nty4dfpL9e8yT0hfnGLnqRevLIywh6nskmu7r5glcFjfDcKY6dRrCswqf+Cgqtok OouDH71cpZZkxTtMZStRPxj5GZUCgktb2uxQBVCI1WpnSHVPTnpsZCh5RGjRAusp BHyKusg2/FTboVxZd6vVL+1029AR1nmXJ/Yt9WetseNWKMxvpAUMSpT7wkCM9ZDY 1VNRDE4sNhJaVe4lt9AoIXjvwEb487lGN7Eo+aEHQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=f6OSkL kcqjzHHYtSkZatBigfMp4TC8UklzMzE7kkSDg=; b=dsALPd09p9AMuV3EhXm4J5 5PTZDxBvfuxxhhwcokQQ53GBLxD7D4jyqIBDMw66jLZyPSCEHnbO7umCbCPpeB67 l+5QLSzMqAab2ZICDCkzgDXMchuGYgBS8GbneWgbLe+rXDYqaCTDdiTCCrY2zrKI +p60opsp21CM64zwe2J7p7f0MQTYZNFNwGtLYRohPS6/NgOUcPt5PtEDXnQNPcSP BwmJfHG1JI4CdLzqgCZDBnHagYemSLA6LiS5xxMcGaKIWRMbsl3LedJ+Y3Hn2g5h vAMH7Yo3I9D+CrvfkZhk/+n2vIg5l/VWE1Zvhud71Fq1pCjmXZBy5tzNiUDGzJ4Q == X-ME-Sender: Original-Received: by mailuser.nyi.internal (Postfix, from userid 99) id D8F989E094; Sat, 9 Dec 2017 10:30:41 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface - ajax-c9e5630e In-Reply-To: <87a7yuey7i.fsf@users.sourceforge.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140858 Archived-At: I=E2=80=99d like to acknowledge how much of an ass I=E2=80=99ve been toward= s Eli in this thread. I=E2=80=99ve emailed Eli personally, but I think I owe him a public apology, and an apology to everyone else whom I made uncomfortable with my increasingly rude and condescending responses towards him. I had misinterpreted Eli=E2=80=99s earlier responses to me as dismissive, a= nd thought he was biased in favour of his own code and was dismissing my concerns in order to avoid fixing something I thought was wrong/broken. I made the assumption that post-command-hook would be called many, many more times than window-configuration-change- hook, an assumption I made without testing the theory, and then continued attacking him. Now I realise he wasn=E2=80=99t suggesting post-command-hook as a lazy quick fix, but this would in fact improve my code. I=E2=80=99m sorry Eli, and everyone else in this thread. I should have shown gratitude for your help instead of such arrogance. > I'm willing to do more, and propose working code, but being unfamiliar > with your package, I need some help understanding what is the expected > behavior when certain display-related attributes change. For example, > what should happen if the user enlarges or makes smaller the default > face's font with the likes of "C-x +=E2=80=9D? The basic idea of the package is to take a text body width value (integer or float) and keep the margins balanced on either side in each window the buffer is displayed. Whenever anything display-related changes, the package calls olivetti-set-environment. This function calls olivetti-scale-width to account for any changes to the font size. > I'm asking this because the effect on the display margins is similar, > so I wanted to look what the package does in that case, but it seems > to do nothing: the margin dimensions are not changed as I'd expect > them to. So I couldn't do more than just suggest a way to solve this. > Maybe I missed some setting or knob. I=E2=80=99m going to implement post-command-hook as you suggested, and once= the API for line-number-display-width is locked I will call that to account for display-line-numbers. You know, the silly thing is... olivetti is designed for prose writing, most people will never use it in conjunction with line numbers...