From: Paul Rankin <hello@paulwrankin.com>
To: 28844@debbugs.gnu.org
Subject: bug#28844: 26.0.90; display-line-numbers-mode should call window-configuration-change-hook
Date: Fri, 08 Dec 2017 12:14:02 +1000 [thread overview]
Message-ID: <1512699242.3658603.1198014544.7EB49FB0@webmail.messagingengine.com> (raw)
In-Reply-To: <1508054203.3504379.1139170720.0D0E99E9@webmail.messagingengine.com>
Eli, I understand that your blindness to this bug is probably due to your own bias. I get it, you wrote the code, you enjoyed the previously mentioned reddit upvotes for it, I understand you don’t want to admit that your code has flaws. But you need to understand that your way of seeing things is subjective and not universal.
The bug is that when the user scrolls up or down, past a point where the width of the line numbers changes from e.g. 99 to the number width from 2 to 3 thus making the width of line number display change from 4 to 5, display-line-numbers-mode necessarily changes the window display configuration to accommodate this character.
However, display-line-numbers-mode doesn’t appear to tell the rest of Emacs about this change, so even if we all wanted to accommodate your display changes, as far as I can tell, we cannot.
It’s nice that you added the token function line-number-display-width, but aside from the bug with its return value being off by 2 (#29597), this function is not useful unless other lisp programs know *when* to call it.
The easiest solution, the one that baffles me why you haven’t just included already rather than continue to argue with me, is that when display-line-numbers-mode changes the window, you run window-configuration-change-hook.
If, for some Eli-reason, you don’t want to run window-configuration-change-hook, you can add a simple hook, which gets run whenever display-line-numbers-mode needs to change the window configuration. Then other lisp programs can call line-number-display-width, and provided its bug gets fixed and it returns the correct width, everyone is happy.
Is there anything about this that’s not clear to you?
next prev parent reply other threads:[~2017-12-08 2:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-15 7:56 bug#28844: 26.0.90; display-line-numbers-mode should call window-configuration-change-hook Paul Rankin
2017-10-15 9:41 ` martin rudalics
2017-10-15 11:08 ` Paul Rankin
2017-10-15 12:12 ` martin rudalics
2017-10-15 13:27 ` Paul Rankin
2017-10-15 14:59 ` Eli Zaretskii
2017-10-16 3:22 ` Paul Rankin
2017-10-16 4:59 ` Alex
2017-10-16 5:14 ` Paul Rankin
2017-10-16 14:48 ` Eli Zaretskii
2017-10-17 0:35 ` Paul Rankin
2017-10-17 2:41 ` Eli Zaretskii
2017-10-17 4:19 ` Paul Rankin
2017-10-17 5:44 ` Eli Zaretskii
2017-10-17 7:13 ` Paul Rankin
2017-10-17 8:33 ` Eli Zaretskii
2017-10-20 9:42 ` Eli Zaretskii
2017-12-08 2:43 ` Noam Postavsky
2017-12-08 14:48 ` Eli Zaretskii
2017-12-09 15:30 ` Paul Rankin
2017-12-09 16:01 ` Eli Zaretskii
2017-10-15 14:47 ` Eli Zaretskii
2017-10-16 7:41 ` martin rudalics
2017-10-22 7:20 ` Paul Rankin
2017-10-22 14:27 ` Eli Zaretskii
2017-12-08 2:14 ` Paul Rankin [this message]
2017-12-08 15:22 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512699242.3658603.1198014544.7EB49FB0@webmail.messagingengine.com \
--to=hello@paulwrankin.com \
--cc=28844@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.