From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Rankin Newsgroups: gmane.emacs.bugs Subject: bug#28844: 26.0.90; display-line-numbers-mode should call window-configuration-change-hook Date: Mon, 16 Oct 2017 15:14:10 +1000 Message-ID: <1508130850.3734431.1139876192.21CE8281@webmail.messagingengine.com> References: <1508054203.3504379.1139170720.0D0E99E9@webmail.messagingengine.com> <59E32D49.4030007@gmx.at> <1508065717.3534312.1139251176.600E646A@webmail.messagingengine.com> <59E350AE.3060005@gmx.at> <1508074073.3557079.1139314312.4BFE5BC2@webmail.messagingengine.com> <83o9p8h2yv.fsf@gnu.org> <1508124120.3709085.1139805520.1F653A1C@webmail.messagingengine.com> <87efq37knc.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1508130918 23768 195.159.176.226 (16 Oct 2017 05:15:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 16 Oct 2017 05:15:18 +0000 (UTC) Cc: 28844@debbugs.gnu.org To: Alex Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 16 07:15:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3xk5-00053s-Ie for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Oct 2017 07:15:09 +0200 Original-Received: from localhost ([::1]:59372 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3xkB-0002km-46 for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Oct 2017 01:15:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55513) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3xk2-0002kC-HH for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 01:15:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e3xjz-0001do-9r for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 01:15:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33636) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e3xjz-0001dh-5k for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 01:15:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e3xjx-0004He-QR for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 01:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Rankin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Oct 2017 05:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28844 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28844-submit@debbugs.gnu.org id=B28844.150813085316383 (code B ref 28844); Mon, 16 Oct 2017 05:15:01 +0000 Original-Received: (at 28844) by debbugs.gnu.org; 16 Oct 2017 05:14:13 +0000 Original-Received: from localhost ([127.0.0.1]:42316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3xjA-0004GB-WC for submit@debbugs.gnu.org; Mon, 16 Oct 2017 01:14:13 -0400 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:56905) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3xj9-0004G1-Er for 28844@debbugs.gnu.org; Mon, 16 Oct 2017 01:14:11 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id C5A9920BBB; Mon, 16 Oct 2017 01:14:10 -0400 (EDT) Original-Received: from web5 ([10.202.2.215]) by compute3.internal (MEProxy); Mon, 16 Oct 2017 01:14:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paulwrankin.com; h=cc:content-transfer-encoding:content-type:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=5D0YB4UPEUsp0f94U uhlnR96O7seGIxfHJxrNaPWWMg=; b=dOu7X+DHaZK7TXjMRHMFpQkdBq56dHjVC O3oYP2K/BCcDA6xb3B1tjjGXEA1Whg7G4u2IN+KtkErNeIL03Arqkgat1xDA4UFj Cej5rOWbmN+0qTpF/MkPlcTGh/h7S8KBwoRqkfV78/CAmsOF7wjnCwdK/scTtWxY mualJprKY+h2hL1oaCHvwnYU8Vg1NP4/XW17+LQHhbyQFuCnYAQ6zsYEGwXLnzLL bZ/SyfKUzORq+J7h1jysXVpbN2CIM8Z1Os1e6aBHGEFMA20wu8y58G3iFWYoL+tx 3artRj12b9W+3ByRXiC0HT9J9xmqSOuxbfFhZkZgU0RLB4anJ0RkA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=5D0YB4 UPEUsp0f94UuhlnR96O7seGIxfHJxrNaPWWMg=; b=CQPb9ozcO/bvZ05Ga1lsPQ QSHmjtWswvf7vtT5IHceEn6CotyDR802a6E+6OubhQOiww70EpudJZLMrId8rQY9 nBNnQMl316Zy5kEQNk4f8Ec+IxsVVyGlUuf3Gq/GhKjypCiW+S3xDKMMvHOzMxGa lnTV4/HGbMLiJ+USVtR+vPV8cKc5ySKNeIb9uydn5np8Gn7OPRUHb8fZ3SMOfXOY nS724jgPb7EkU03ZK5UtZyVPl1rTTUWvd8gfTGApx10z1jUiaI4HMhhJSTg2OHvI NiSd4l4SQbAdrtmQiUyQBZVCJFR7GRJqKssz3UlLkfFN87e72Z7Pqm3j2Yd1FBQg == X-ME-Sender: Original-Received: by mailuser.nyi.internal (Postfix, from userid 99) id 8A7BD9E2FE; Mon, 16 Oct 2017 01:14:10 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface - ajax-26fdae60 In-Reply-To: <87efq37knc.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138498 Archived-At: On Mon, 16 Oct 2017, at 02:59 PM, Alex wrote: > Actually, I'd recommend (boundp 'display-line-numbers), since the > feature `display-line-numbers' isn't loaded automatically in Emacs. It > should be noted that `display-line-numbers-mode' is just a minor mode > wrapper around the variable `display-line-numbers', which actually does > the work. >=20 > This also means that the hook `display-line-numbers-hook' isn't actually > enough to determine whether or not line numbers have been toggled (since > one can just toggle the variable instead). I'd say its main use is in > user configurations. >=20 > To see if line numbers are present in a buffer (and to make it > compatible with older Emacsen), you should use something like: >=20 > (bound-and-true-p display-line-numbers) Sweet, thanks! I=E2=80=99ve encountered another bug with this mode #28855, = so I think until it gets its house in order, the best thing to go with is: (if (bound-and-true-p display-line-numbers) (display-line-numbers-mode 0)) I=E2=80=99ve just discovered that linum-mode.el has been fixed to respect e= xisting margins, so big love & thanks to whoever did that work. So, if linu= m-mode can be a good lisp citizen, so too can display-line-numbers-mode!