all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Paul Rankin <hello@paulwrankin.com>
To: Alex <agrambot@gmail.com>
Cc: 28844@debbugs.gnu.org
Subject: bug#28844: 26.0.90; display-line-numbers-mode should call window-configuration-change-hook
Date: Mon, 16 Oct 2017 15:14:10 +1000	[thread overview]
Message-ID: <1508130850.3734431.1139876192.21CE8281@webmail.messagingengine.com> (raw)
In-Reply-To: <87efq37knc.fsf@gmail.com>

On Mon, 16 Oct 2017, at 02:59 PM, Alex wrote:
> Actually, I'd recommend (boundp 'display-line-numbers), since the
> feature `display-line-numbers' isn't loaded automatically in Emacs. It
> should be noted that `display-line-numbers-mode' is just a minor mode
> wrapper around the variable `display-line-numbers', which actually does
> the work.
> 
> This also means that the hook `display-line-numbers-hook' isn't actually
> enough to determine whether or not line numbers have been toggled (since
> one can just toggle the variable instead). I'd say its main use is in
> user configurations.
> 
> To see if line numbers are present in a buffer (and to make it
> compatible with older Emacsen), you should use something like:
> 
> (bound-and-true-p display-line-numbers)

Sweet, thanks! I’ve encountered another bug with this mode #28855, so I think until it gets its house in order, the best thing to go with is:
(if (bound-and-true-p display-line-numbers) (display-line-numbers-mode 0))

I’ve just discovered that linum-mode.el has been fixed to respect existing margins, so big love & thanks to whoever did that work. So, if linum-mode can be a good lisp citizen, so too can display-line-numbers-mode!





  reply	other threads:[~2017-10-16  5:14 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-15  7:56 bug#28844: 26.0.90; display-line-numbers-mode should call window-configuration-change-hook Paul Rankin
2017-10-15  9:41 ` martin rudalics
2017-10-15 11:08   ` Paul Rankin
2017-10-15 12:12     ` martin rudalics
2017-10-15 13:27       ` Paul Rankin
2017-10-15 14:59         ` Eli Zaretskii
2017-10-16  3:22           ` Paul Rankin
2017-10-16  4:59             ` Alex
2017-10-16  5:14               ` Paul Rankin [this message]
2017-10-16 14:48                 ` Eli Zaretskii
2017-10-17  0:35                   ` Paul Rankin
2017-10-17  2:41                     ` Eli Zaretskii
2017-10-17  4:19                       ` Paul Rankin
2017-10-17  5:44                         ` Eli Zaretskii
2017-10-17  7:13                           ` Paul Rankin
2017-10-17  8:33                             ` Eli Zaretskii
2017-10-20  9:42                               ` Eli Zaretskii
2017-12-08  2:43                             ` Noam Postavsky
2017-12-08 14:48                               ` Eli Zaretskii
2017-12-09 15:30                               ` Paul Rankin
2017-12-09 16:01                                 ` Eli Zaretskii
2017-10-15 14:47       ` Eli Zaretskii
2017-10-16  7:41         ` martin rudalics
2017-10-22  7:20 ` Paul Rankin
2017-10-22 14:27   ` Eli Zaretskii
2017-12-08  2:14 ` Paul Rankin
2017-12-08 15:22   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1508130850.3734431.1139876192.21CE8281@webmail.messagingengine.com \
    --to=hello@paulwrankin.com \
    --cc=28844@debbugs.gnu.org \
    --cc=agrambot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.