From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Matthew Plant Newsgroups: gmane.emacs.devel Subject: Re: Emacs26: Quick thoughts on display-line-numbers-mode Date: Thu, 05 Oct 2017 13:07:37 -0700 Message-ID: <1507234057.15251.23.camel@gmail.com> References: <1507229521.6891.6.camel@gmail.com> <83fuaxwgql.fsf@gnu.org> <1507232129.15251.12.camel@gmail.com> <83efqhwezk.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1507241487 28563 195.159.176.226 (5 Oct 2017 22:11:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 5 Oct 2017 22:11:27 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 06 00:11:23 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0EMR-0006W2-Oe for ged-emacs-devel@m.gmane.org; Fri, 06 Oct 2017 00:11:19 +0200 Original-Received: from localhost ([::1]:42175 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0EMZ-0007i6-1J for ged-emacs-devel@m.gmane.org; Thu, 05 Oct 2017 18:11:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0CQo-0004fx-Lx for emacs-devel@gnu.org; Thu, 05 Oct 2017 16:07:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0CQn-0007s9-JX for emacs-devel@gnu.org; Thu, 05 Oct 2017 16:07:42 -0400 Original-Received: from mail-pf0-x22b.google.com ([2607:f8b0:400e:c00::22b]:45286) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e0CQl-0007p7-Uk; Thu, 05 Oct 2017 16:07:40 -0400 Original-Received: by mail-pf0-x22b.google.com with SMTP id z84so8462007pfi.2; Thu, 05 Oct 2017 13:07:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=zzxh9kLjz/qcQmU5r6tAwWawXfHa+U/dECAD9QKWEzk=; b=dXYUstNFTGXproQSzFnW/k2lUO4h0HdLYChNF1Y71lsPgx6hkTEZOxmvnw2+BRCmi4 CvphQeFUdXQUyj7pK2n8bTjn6Re8qwtYE1v6bbyB0J/JcC7ybnFAwBs4vdOtVhGRMR1S eakH/FFxeObf9Q0ypX4+LFprBsbP51FWtiUgQMqzczzfjI1mg2d5YYkZjYq2jasKM5cr YZ1E+VudL5A5ibr5VgL/lCAo3P72aHndl+NOhawV1Owx0mlVif1bYKkfV3w3sPWkUMA7 0EatJ6Yc/33a8iGEVXi6AHmyDyuUh275srQjGU+4faM+xu0wr2x4XNfxGFU7goeaPcHL DR6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=zzxh9kLjz/qcQmU5r6tAwWawXfHa+U/dECAD9QKWEzk=; b=EYbCzJsjX/7nqIronENmvNZjCXJQvdDnasf+XKSEw2NsSc/1m0wOb7yoPwkeJq5syg pBdI1XZp5Gr+wPo9nNtkUXgOri06fdWea4HVDLErultj2GdOCjZKx2lwGVHfsuUqExld CCv696V7EwVSRKPJZKnl9i8UqFT8qWvfn+FckuPv9xKfP6ynChaPgYFUpEVc02tqVtWQ rUUJRUtk21vKcX0NUi5lzSNkTY8xqNXyumelwpx04g7q8dfNBsU7edIW0Ply3XnNrtAX BNJ+NtX9plsKpeuEsL/bnQD0EG9Jl4QEU/NcwGQyQyuHzAXKMBRuKlUr5FM85roYzbNp GkEg== X-Gm-Message-State: AMCzsaVmJUeACwHjSdyxj+qWBWnHeKhin1hvwwI2TQIPyyHTU/bYSwaH yqgc74U5eIcbork8Q3MaN67JrOEB X-Google-Smtp-Source: AOwi7QCES4U5YLQiwnbqkCg3uwuyBqsHhOepE5JTP0R9muXBw/+9a9WLfXd2qV0ZpBmkt3zyE6t3kw== X-Received: by 10.159.216.151 with SMTP id s23mr13204448plp.176.1507234058368; Thu, 05 Oct 2017 13:07:38 -0700 (PDT) Original-Received: from Monolith ([2601:647:4e00:bb4b:da0a:30ed:edf:f4e9]) by smtp.googlemail.com with ESMTPSA id r18sm20451120pge.2.2017.10.05.13.07.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Oct 2017 13:07:37 -0700 (PDT) In-Reply-To: <83efqhwezk.fsf@gnu.org> X-Mailer: Evolution 3.24.5 (3.24.5-1.fc26) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::22b X-Mailman-Approved-At: Thu, 05 Oct 2017 18:10:35 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219151 Archived-At: On Thu, 2017-10-05 at 22:50 +0300, Eli Zaretskii wrote: > > From: Matthew Plant > > Date: Thu, 05 Oct 2017 12:35:29 -0700 > > > > My apologies, I did not notice that line-number face existed > > because it > > is not part of the display line numbers group. This does exactly > > what I > > want. > > > > That being said, shouldn't this face be part of the group display- > > line- > > number? Faces for compilation errors are part of the the > > compilation > > group. > > My reasoning was that this is one of the basic faces we provide, so > it's in the basic faces group. > Hmm... Ok. > > Being able to specify which side the line numbers appear I imagine > > would be useful for editing right to left languages. > > When the paragraph direction is right-to-left, the numbers > automatically appear on the right. You should be able to see that if > you visit TUTORIAL.he with display-line-numbers-mode turned on. > > > That being said I can't find one editor that supports this feature > > Well, Emacs does ;-) > I was silently wondering if this was the case. Oops, my bad. > > You said in a separate reply that separation between the numbers > > and > > the text is kept with a white-space glyph. Why not just let this be > > a > > buffer or mode local string specified by the user? > > There's a technical problem with doing that, which I couldn't solve. > It would also slow down redisplay, while performance was high on my > priority list when working on this feature. If you can elaborate on the technical problem I can give it a look. If the glyph is limited to one character and is properly cached I don't see why this would be a specificaly worrisome performance hit. I can see it being an issue if the glyph is changed a lot, but I don't think this is a common use case. I'm making some assumptions about the display code, I'll take a look at the implementation.