From: Yuan Fu <casouri@gmail.com>
To: Noah Peart <noah.v.peart@gmail.com>
Cc: 68054@debbugs.gnu.org
Subject: bug#68054: [PATCH] Add tree-sitter indent rule for lexical decls in js/typescript
Date: Sat, 30 Dec 2023 12:31:20 -0800 [thread overview]
Message-ID: <14DD6D3A-B9F5-4E5F-B85B-0A8DF6961723@gmail.com> (raw)
In-Reply-To: <797AC075-B0C8-4269-B8E3-A1F2C69FA955@gmail.com>
> On Dec 29, 2023, at 8:24 PM, Yuan Fu <casouri@gmail.com> wrote:
>
>
>
>> On Dec 26, 2023, at 10:21 PM, Noah Peart <noah.v.peart@gmail.com> wrote:
>>
>> Tags: patch
>>
>> * Bug: `js-ts-mode` and `typescript-ts-mode` are missing indentation
>> rules for lexical declarations that span multiple lines.
>>
>> Recipe to reproduce:
>>
>> Using the following function to configure js-ts-mode and indent the
>> buffer:
>>
>> (defun try-indent ()
>> (interactive)
>> (js-ts-mode)
>> (setq-local indent-tabs-mode nil)
>> (setq-local js-indent-level 4)
>> (indent-region (point-min) (point-max)))
>>
>> Add the following example to a buffer and call `try-indent`.
>>
>> let foo = 1,
>> bar = 2; // no indent rule matches this line
>>
>> No indentation is applied to the second line.
>>
>> This patch adds a simple indentation rules for `js-ts-mode` and
>> `typescript-ts-mode` to handle the multi-line lexical declarations.
It seems that js-mode indents bar to align with foo, rather than indenting one level. I feel that we should do the same, WDYT?
Yuan
next prev parent reply other threads:[~2023-12-30 20:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 6:21 bug#68054: [PATCH] Add tree-sitter indent rule for lexical decls in js/typescript Noah Peart
2023-12-30 4:24 ` Yuan Fu
2023-12-30 20:31 ` Yuan Fu [this message]
2023-12-31 0:31 ` Dmitry Gutov
2023-12-31 5:35 ` Noah Peart
2023-12-31 13:41 ` Dmitry Gutov
2024-01-01 4:56 ` Yuan Fu
2024-04-17 20:21 ` Noah Peart
2024-04-23 5:07 ` Yuan Fu
2024-04-24 0:15 ` Dmitry Gutov
2024-04-24 2:36 ` Noah Peart
2024-04-24 23:15 ` Dmitry Gutov
2024-04-25 22:48 ` Noah Peart
2024-04-26 1:06 ` Dmitry Gutov
2024-05-02 13:26 ` Noah Peart
2024-05-02 13:38 ` Noah Peart
2024-05-18 8:29 ` Eli Zaretskii
2024-06-09 2:52 ` Dmitry Gutov
2024-06-09 2:48 ` Dmitry Gutov
2024-06-09 6:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14DD6D3A-B9F5-4E5F-B85B-0A8DF6961723@gmail.com \
--to=casouri@gmail.com \
--cc=68054@debbugs.gnu.org \
--cc=noah.v.peart@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.