From: Yuan Fu <casouri@gmail.com>
To: Theodor Thornhill <theo@thornhill.no>
Cc: bruce.stephens@isode.com, eliz@gnu.org, 60496@debbugs.gnu.org,
59686@debbugs.gnu.org
Subject: bug#60496: 29.0.60; c-ts-mode: Broken indentation with linux style conditionals
Date: Sun, 15 Jan 2023 01:23:45 -0800 [thread overview]
Message-ID: <14D85B96-4968-45D9-8296-819E440F01C3@gmail.com> (raw)
In-Reply-To: <91001d1f8d7fe3db33aefffaa0829f26@sadiqpk.org>
Yuan Fu <casouri@gmail.com> writes:
>> On Dec 3, 2022, at 3:08 AM, Theodor Thornhill <theo@thornhill.no> wrote:
>>
>>
>>
>> On 3 December 2022 11:48:34 CET, Yuan Fu <casouri@gmail.com> wrote:
>>>
>>> Theodor Thornhill <theo@thornhill.no> writes:
>>>
>>>> Bruce Stephens <bruce.stephens@isode.com> writes:
>>>>
>>>>> On 02/12/2022 08:39, Eli Zaretskii wrote:
>>>>>
>>>>>> FWIW, this is an unusual style, so I see no catastrophe if it is not 110%
>>>>>> according to expectations. Users can easily fix that by tweaking their BOLs
>>>>>> where important.
>>>>>
>>>>>
>>>>> The example I gave would be unusual, I think, but I'd argue that the
>>>>> situations where I saw the problem are quite natural.
>>>>>
>>>>> For example,
>>>>>
>>>>> } else if ( MYSTRCMP (attname, SOME_PREFIX_X400ADDRESS) ||
>>>>> MYSTRCMP (attname, SOME_PREFIX_X400) ) {
>>>>> FOO_ptr orp = foo_std2foo (val);
>>>>>
>>>>> or a function declaration with several arguments with types that are
>>>>> rather long.
>>>>>
>>>>> I agree it's not a critical bug but if there's no appropriate general
>>>>> fix it would be helpful to have some guidance for users to resolve our
>>>>> specific cases.
>>>>
>>>> This is the case I was thinking of. In the for-loop a grand-parent-bol
>>>> on compound_statement rule would match the 'for' keyword, so the
>>>> indentation will be correct, but this one will not, IIRC. I plan to dig
>>>> into this some more soon, but motivation left me a little on that issue.
>>>> Maybe we could make a preset like:
>>>>
>>>> ```
>>>> (seq
>>>> (parent-is "compound_statement") parent (parent-is "for_statement") bol)
>>>> ```
>>>>
>>>>
>>>> In other words, make other presets execute sequentially, move point,
>>>> check again, and if all are true, pick indent offset. Or allow multiple
>>>> captures, like so:
>>>>
>>>> ```
>>>> (for_statement @offset-anchor
>>>> body: (compound_statement (_) @to-indent))
>>>> ```
>>>>
>>>> Here the @to-indent capture would get the new indent level based on
>>>> treesit-node-start of for_statement.
>>>>
>>>> What do you think, Yuan?
>>>
>>> I think we can just test for the grandparent, there is an
>>> (undocumented) matcher n-p-gp which matches parent and grandparent.
>>>
>>> Yuan
>>
>> Yeah I know, but that doesn't work in every case we see this behavior.
>
> I see, but at least it fixes common cases that I can think of right now, namely if, for, while. What are some other cases?
I just pushed a change (189d976dbae) that I think fixes this kind of
problems. Instead of trying to figure out the right anchor, we simply
count the number of {} blocks between the node at point and the root
node, and use that number (multiplied by c-ts-mode-indent-offset) as the
indentation.
If you think about it, both
for (a;b;c)
{
|
}
and
for (a;
b;
c)
{
|
}
are one block-level deep. So multi-line conditions is not an issue
anymore.
And
int main()
{
if ()
{
|
}
}
is 2 block-level deep, etc.
Yuan
prev parent reply other threads:[~2023-01-15 9:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-02 15:57 bug#60496: 29.0.60; c-ts-mode: Broken indentation with linux style conditionals Mohammed Sadiq
2023-01-02 22:29 ` Yuan Fu
2023-01-03 9:09 ` Mohammed Sadiq
2023-01-07 12:18 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-15 9:23 ` Yuan Fu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14D85B96-4968-45D9-8296-819E440F01C3@gmail.com \
--to=casouri@gmail.com \
--cc=59686@debbugs.gnu.org \
--cc=60496@debbugs.gnu.org \
--cc=bruce.stephens@isode.com \
--cc=eliz@gnu.org \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.