From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Rankin Newsgroups: gmane.emacs.bugs Subject: bug#27634: 25.2.1; C-g does not quit register-read-with-preview Date: Mon, 10 Jul 2017 13:58:54 +1000 Message-ID: <1499659134.3804557.1035526184.45B0CA20@webmail.messagingengine.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1499659224 6755 195.159.176.226 (10 Jul 2017 04:00:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 10 Jul 2017 04:00:24 +0000 (UTC) To: 27634@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 10 06:00:18 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUPrp-00010z-30 for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Jul 2017 06:00:13 +0200 Original-Received: from localhost ([::1]:38369 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUPrr-0002DE-Ag for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Jul 2017 00:00:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33105) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUPri-00028d-Bk for bug-gnu-emacs@gnu.org; Mon, 10 Jul 2017 00:00:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUPrf-0005aL-25 for bug-gnu-emacs@gnu.org; Mon, 10 Jul 2017 00:00:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56760) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dUPre-0005aF-VN for bug-gnu-emacs@gnu.org; Mon, 10 Jul 2017 00:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dUPre-000101-Ow for bug-gnu-emacs@gnu.org; Mon, 10 Jul 2017 00:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Rankin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Jul 2017 04:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 27634 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.14996591493716 (code B ref -1); Mon, 10 Jul 2017 04:00:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 10 Jul 2017 03:59:09 +0000 Original-Received: from localhost ([127.0.0.1]:59437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUPqn-0000xr-IH for submit@debbugs.gnu.org; Sun, 09 Jul 2017 23:59:09 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42007) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUPql-0000xe-Ni for submit@debbugs.gnu.org; Sun, 09 Jul 2017 23:59:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUPqf-0005AM-KI for submit@debbugs.gnu.org; Sun, 09 Jul 2017 23:59:02 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:35485) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dUPqf-0005AI-Ga for submit@debbugs.gnu.org; Sun, 09 Jul 2017 23:59:01 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32974) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUPqe-00020v-Aj for bug-gnu-emacs@gnu.org; Sun, 09 Jul 2017 23:59:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUPqb-00059D-4L for bug-gnu-emacs@gnu.org; Sun, 09 Jul 2017 23:59:00 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:32897) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dUPqa-000593-P7 for bug-gnu-emacs@gnu.org; Sun, 09 Jul 2017 23:58:57 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id CB5D8206C7 for ; Sun, 9 Jul 2017 23:58:54 -0400 (EDT) Original-Received: from web5 ([10.202.2.215]) by compute3.internal (MEProxy); Sun, 09 Jul 2017 23:58:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paulwrankin.com; h=content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=P35Hym6djxV2DLLcQNtYHEavItH5688Gh7Zr4sTq0AU=; b=LrwTDYaw cuQpoVuUQ6iMrNmHam55MV/xcvfnR05WDEK2kFk7Q6jIUqMF658IVA90t1Fb3GPR SYgKFXU1HTa9MYJOxfdO/q6H22FD4YV8mtFYFxXIccCq5b2HytFoCLtGi+xAyqQz E2CRC8U3fzsuJ4qVTjFhDw2OHt/vV7bl7v4xODPGeAu3j0qWlXNKR3Rr924piTxF gdSb2LALgq5i0Fn//HrewPCiSUlPpmoh529Y6VPA8AgaILbqV27BN/ZdUR1I+zKA MBGPDqOqLr/yp/u0nxtS2gwrYnnzvL+L9K8HXM+UutsZlxZ/JkasyNR1kQSQDDom WCXudn/p/TdgFA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=P35Hym6djxV2DLLcQNtYHEavItH56 88Gh7Zr4sTq0AU=; b=ZWQKiTqqKTe/EwVwjHW4raEyYcqrqo0oeicdPUqdvcSnT rEYgV8WyFoQRrrLaHK0U5/Bz2nJT0PVVE8/bmm/fU99+lOp2vCv8a+AE1UWlRJik G1uKfgyQLa5Qk27S1hWvEvQ7fYZ283dMMHHfNRQkqxGOqdqmvbTt24zMVzlWbRa8 R30srEz6eL7LjLXbA0SzA0685L//83LxkixQWiMy1wzw97SBrYeXKRCR82p4oJa9 MW+BlgW2O0/7doZXB8t74dADAB9V9Ulh3dAGxg89EF9unvfI0ZNweNHB8wdczjoP kkBWBxAz1Lsb8ssCyjD+TUUbLPFNIO5oblUKDLp4g== X-ME-Sender: Original-Received: by mailuser.nyi.internal (Postfix, from userid 99) id 9925A9E2A4; Sun, 9 Jul 2017 23:58:54 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface - ajax-6ef673f5 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134385 Archived-At: When saving to a register C-g does not quit but instead saves to the regist= er "C-g". To reproduce: 1. $ emacs -Q 2. M-x point-to-register [C-x r SPC] 3. C-g Expected results: C-g should call keyboard-quit and escape point-to-register Actual results: Point marker is saved to register "C-g". This runs counter to expected behaviour with both quitting from saving a re= gister, and in quitting from recalling a register, e.g. by attempting to qu= it from saving a point to register in buffer-A with C-g, when the user then= attempts to keyboard-quit from jump-to-register [C-x r j C-g] he/she will = be returned to point in buffer-A. The root of the problem appears to be that register-read-with-preview only = tests input with characterp: (characterp ?^G) -> t This appears to conflict with the Emacs manual entry on registers, which st= ates that registers can be a letters or numbers: > Each register has a name that consists of a single character, which > we will denote by R; R can be a letter (such as =E2=80=98a=E2=80=99) or a= number (such > as =E2=80=981=E2=80=99); case matters, so register =E2=80=98a=E2=80=99 is= not the same as register =E2=80=98A=E2=80=99. (info "(emacs) Registers") I have worked around this with the following patch to register.el.gz: @@ -164,7 +164,7 @@ help-chars) (unless (get-buffer-window buffer) (register-preview buffer 'show-empty))) - (if (characterp last-input-event) last-input-event + (if (< 31 last-input-event 127) last-input-event (error "Non-character input-event"))) (and (timerp timer) (cancel-timer timer)) (let ((w (get-buffer-window buffer))) However, I think this will not work on international keyboards and so is pr= obably a poor fix. Configuration: GNU Emacs 25.2.1 (x86_64-apple-darwin16.6.0, NS appkit-1504.83 Version 10.1= 2.5 (Build 16F73)) of 2017-06-06 macOS 10.12.5 (16F73) MacBook Pro (Retina, 15-inch, Mid 2014) 2.2 GHz Intel Core i7 16 GB 1600 MHz DDR3 Intel Iris Pro 1536 MB -- www.paulwrankin.com