From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Newsgroups: gmane.emacs.bugs Subject: bug#27392: 26.0.50; [css-mode] Completion fails after "grid" is typed out Date: Fri, 16 Jun 2017 20:23:29 +0200 Message-ID: <1497637409.28243.1@smtp.gmail.com> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-JH/lPF9erINPXcwBbFse" X-Trace: blaine.gmane.org 1497637458 14827 195.159.176.226 (16 Jun 2017 18:24:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 16 Jun 2017 18:24:18 +0000 (UTC) Cc: 27392@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 16 20:24:14 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dLvuj-0003U3-R7 for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Jun 2017 20:24:09 +0200 Original-Received: from localhost ([::1]:60273 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dLvuo-0001xW-Vq for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Jun 2017 14:24:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dLvug-0001xG-QY for bug-gnu-emacs@gnu.org; Fri, 16 Jun 2017 14:24:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dLvuc-00046f-Qp for bug-gnu-emacs@gnu.org; Fri, 16 Jun 2017 14:24:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48992) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dLvuc-00046b-Ku for bug-gnu-emacs@gnu.org; Fri, 16 Jun 2017 14:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dLvub-0001c3-Vi for bug-gnu-emacs@gnu.org; Fri, 16 Jun 2017 14:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Jun 2017 18:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27392 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27392-submit@debbugs.gnu.org id=B27392.14976374206165 (code B ref 27392); Fri, 16 Jun 2017 18:24:01 +0000 Original-Received: (at 27392) by debbugs.gnu.org; 16 Jun 2017 18:23:40 +0000 Original-Received: from localhost ([127.0.0.1]:51669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dLvuF-0001bN-MJ for submit@debbugs.gnu.org; Fri, 16 Jun 2017 14:23:39 -0400 Original-Received: from mail-lf0-f41.google.com ([209.85.215.41]:33474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dLvuD-0001b8-ED for 27392@debbugs.gnu.org; Fri, 16 Jun 2017 14:23:38 -0400 Original-Received: by mail-lf0-f41.google.com with SMTP id m77so29400202lfe.0 for <27392@debbugs.gnu.org>; Fri, 16 Jun 2017 11:23:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=uYqEN9iaL8Fbc6/1ae2zxNAkHgnniBaVqXDh75ezYUo=; b=GimypofpSp02M0gBSSi18xng/ezHVY1t39/HI5f4D3FoB5Epu0xkZyaJp7N/fDgMOz kY98qgAUzmF+Yzq94woopYTa0jHWFydH3PO2rGQDKf4KPUbK/lB1WPl4J2kHxwaJmhw2 I9zN93S6SzUBH51xaZW/s8+ukAK0RoxyIQa+o07TaoAtWzg5B50Xqp4zm23dtSP/HHC9 1++S/qQk8Wm41KM9mC6EjzCmn4NfBmczAK2NojfvEw76I9kqFwq1A/Kfmd+O8j8w8bCL S+vIxLJcLZXGf1WAqP2mkaFeTqN2vVawjUQoHpDd29xxU7IgziIIY4WRhtDDclOizfDx NoKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=uYqEN9iaL8Fbc6/1ae2zxNAkHgnniBaVqXDh75ezYUo=; b=nGZmfM6WYzz+s53XbqEF7KJpTrhg62HKRh5geoASIKwGuDO1vt/UvCohXl36LwPrN9 p3hbHARfZLtoYQ0TUOWPArBLEgymQoyOmamlsgGWdTEsJ6253UcSzCsQt9qr/WflRMwV yNxWtofvwlW7RZBZkRA4OuZhPAWSRYl1wELVgBqRBvPUAMRdzHyImI/m4kOOJ7rnOKJz AIYguR+GxBv35fcjdlKNhyRc+Uw9Wu8tPff1XeId9nFdnz+m6Z8ZxlYJOkzMxR7R85gn syFVWtpojQp2b4kfv+xNfMKuL+pydzhZloUIt0iI3T/47mChdVav2NxE6I5g4+PDe29Q ytIw== X-Gm-Message-State: AKS2vOwqoujpdbYeo6vDV0lWpMEzzZXGEiKwyaYr6MfNzYYcemMjp3Wg s3INZmT4oWEwVg== X-Received: by 10.25.221.198 with SMTP id w67mr4439168lfi.144.1497637411542; Fri, 16 Jun 2017 11:23:31 -0700 (PDT) Original-Received: from [192.168.100.8] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id g190sm776745lfe.11.2017.06.16.11.23.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 16 Jun 2017 11:23:30 -0700 (PDT) In-Reply-To: X-Mailer: geary/0.11.3 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133659 Archived-At: --=-JH/lPF9erINPXcwBbFse Content-Type: text/plain; charset=utf-8; format=flowed It seems to be because 'css--complete-property-value' is a bit too eager. Can you try with the following patch? If it's sufficent I'll install it with some test cases. -- Simen --=-JH/lPF9erINPXcwBbFse Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-WIP-Make-css-complete-property-value-less-eager.patch >From baf93870893be37e4f214963bdb31659d7514af7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simen=20Heggest=C3=B8yl?= Date: Fri, 16 Jun 2017 20:19:56 +0200 Subject: [PATCH] WIP: Make css--complete-property-value less eager --- lisp/textmodes/css-mode.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index 0beaaaa32f..3c3c38afc9 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -1292,7 +1292,8 @@ css--complete-property-value (let ((property-end (point))) (skip-chars-backward "-[:alnum:]") (let ((property (buffer-substring (point) property-end))) - (car (member property css-property-ids))))))) + (and (eq (char-after property-end) ?:) + (car (member property css-property-ids)))))))) (when property (let ((end (point))) (save-excursion -- 2.11.0 --=-JH/lPF9erINPXcwBbFse--