From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Jarno Malmari Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix potentially hanging url-auth tests Date: Sun, 16 Apr 2017 14:21:45 +0300 Message-ID: <1492341705.2601170.945983808.1744BCC1@webmail.messagingengine.com> References: <83fuhop8ed.fsf@gnu.org> <1492247564-13556-1-git-send-email-jarno@malmari.fi> <87zifhvg2g.fsf@yandex.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1492341718 8583 195.159.176.226 (16 Apr 2017 11:21:58 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 16 Apr 2017 11:21:58 +0000 (UTC) Cc: emacs-devel@gnu.org To: Colin Baxter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 16 13:21:53 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cziFb-000268-SC for ged-emacs-devel@m.gmane.org; Sun, 16 Apr 2017 13:21:52 +0200 Original-Received: from localhost ([::1]:60010 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cziFh-0002rO-KA for ged-emacs-devel@m.gmane.org; Sun, 16 Apr 2017 07:21:57 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cziFb-0002r6-Hh for emacs-devel@gnu.org; Sun, 16 Apr 2017 07:21:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cziFY-0005fu-DZ for emacs-devel@gnu.org; Sun, 16 Apr 2017 07:21:51 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:57589) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cziFX-0005f5-U6 for emacs-devel@gnu.org; Sun, 16 Apr 2017 07:21:48 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 0F938207BB; Sun, 16 Apr 2017 07:21:46 -0400 (EDT) Original-Received: from web6 ([10.202.2.216]) by compute6.internal (MEProxy); Sun, 16 Apr 2017 07:21:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=malmari.fi; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=aRwyMsArsq1jrgTiuhxTKl4CQYG1B Bo5A/jW3XB5h8M=; b=R0cnurCBmFB4MMQOtp2Ad4c3K2VG80/teAzPuNUvD4RmS 5Vu07nObP7PSwDqhug0Na0YMcLuGQ7Nk6pTOX9YbvZEO4ECwLIiNtYyISHBr2qd5 gYhKD+sxGOhA9Jpg7CVskul9YzpOZ6ycwG7epW4OHbM6NGt0jTv0LwMY8YtMUV1l 2kiB03/GzV+MrMFoR6fQlUCiDI7KtBl0Kw8mEYoTZziX/mG1moUSg+FpInnsh2Hh pCrM0Sll1USTGKkD0W0IMqJRHZgiy3N9ylUiSVBP+++H9F65M3IlGE/fgf18Gx3J +IJqxhCYraYBaLzP49yY4LDL0EeLCnU1+9I0kIhIg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=aRwyMs Arsq1jrgTiuhxTKl4CQYG1BBo5A/jW3XB5h8M=; b=Kz4879hJFBHkovoMTzAOB+ KUjrFu82TVP2njoo/1rHKaWEAFLndNZYe5fLqpOMafYtsE/2xXqbkZzfv8SSUfvs wuaxEV8Sb1Lb59y2eGf3Yw3p3s/vMHhZ2GTT5A1NgxvjhG4vrz5i+yb9MISsnaML DOtH06jAqQic7itp1BbfQ5W5pXsDBog6efDAIhZPCyME73/JFoK8REh6RNAxhtSc KzKrShy0C3voqZIpnZaxKFeKi7+1y0o4A3+xReRECsXtj46qztBfpix7GiOxUJOd NImZlgTeQlUOm1HwgUrunN0nzbLytgolE6/eHoJB5mBg8icbai2/ulfC+MYXOSJA == X-ME-Sender: Original-Received: by mailuser.nyi.internal (Postfix, from userid 99) id D2B0548004; Sun, 16 Apr 2017 07:21:45 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface - ajax-0b509d77 In-Reply-To: <87zifhvg2g.fsf@yandex.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.25 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213995 Archived-At: On Sat, 15 Apr 2017, at 18:36, Colin Baxter wrote: > This patch works for me. Great. Thank you. Good to hear. Thanks for testing. As you can see, the fix is local to the test itself. I think this is the right approach since it is the responsibility of the test to know what side effects the function calls have (reading the file .authinfo in this case). The thing I'm not happy about is the possibility of reintroducing the issue in the future. There's no check for that, but hopefully the code comments give a clue what to avoid. Sure, other testing facilities discussed earlier (customized HOME, or a way to detect if run inside a test) might be useful but probably not warranted solely by the issue here.