Re: [PATCH] Fix potentially hanging url-auth tests

[Jarno Malmari <jarno@malmari.fi>]

On Sat, 15 Apr 2017, at 18:36, Colin Baxter wrote:
> This patch works for me. Great. Thank you.

Good to hear. Thanks for testing.

As you can see, the fix is local to the test itself. I think this is the
right approach since it is the responsibility of the test to know what
side effects the function calls have (reading the file .authinfo in this
case). The thing I'm not happy about is the possibility of reintroducing
the issue in the future. There's no check for that, but hopefully the
code comments give a clue what to avoid.

Sure, other testing facilities discussed earlier (customized HOME, or a
way to detect if run inside a test) might be useful but probably not
warranted solely by the issue here.