From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: For insertion in trunk Date: Tue, 26 Jun 2012 21:24:01 -0400 Message-ID: <148vf9pmxa.fsf@fencepost.gnu.org> References: <87sjfyqzhc.fsf@gmx.de> <87ty0dzdy0.fsf@gmx.de> <87fw9l5b2j.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1340760252 14566 80.91.229.3 (27 Jun 2012 01:24:12 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 27 Jun 2012 01:24:12 +0000 (UTC) Cc: Lars Magne Ingebrigtsen , Chong Yidong , emacs-devel@gnu.org To: Katsumi Yamaoka Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 27 03:24:11 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SjgzJ-0005rd-U0 for ged-emacs-devel@m.gmane.org; Wed, 27 Jun 2012 03:24:10 +0200 Original-Received: from localhost ([::1]:39744 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjgzJ-000436-OA for ged-emacs-devel@m.gmane.org; Tue, 26 Jun 2012 21:24:09 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjgzG-00042w-Jp for emacs-devel@gnu.org; Tue, 26 Jun 2012 21:24:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SjgzE-00071q-T2 for emacs-devel@gnu.org; Tue, 26 Jun 2012 21:24:06 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:43469) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjgzE-00071l-PV for emacs-devel@gnu.org; Tue, 26 Jun 2012 21:24:04 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1SjgzB-0004mV-6K; Tue, 26 Jun 2012 21:24:01 -0400 X-Spook: Syria ammunition Fortezza Peking Mena S Box threat Majic X-Ran: [w%BZ]'aTlO2bHj"X")DI-%gtAR5zX:.TPQ?uK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151204 Archived-At: Katsumi Yamaoka wrote: > I've set no-byte-compile and no-update-autoloads in those files. OK, that works as a stopgap. > (I'm going to try rebuilding now, though it takes time on Cygwin.) Hydra will do it for you: http://hydra.nixos.org/jobset/gnu/emacs-trunk It's a nice service, although it has a few too many false build failures (full disk, missing dependency, some other glitch, etc). >> In any case surely these test files should be under test/, not lisp/? > > Currently those modules are of no use for the run time I believe. > I only did sync of Ma Gnus and Emacs. I don't understand. Not being used at runtime means they should go in test/, like every other test file (including gnus-test.el). They are no use at all in Emacs if they rely on parts of Gnus that are not present though (whatever gnus-load is). Also (my pet peeve) the license headers are obviously wrong in two of them: ;; This file is not part of GNU Emacs. [...] ;; If not, write to the Free Software Foundation, Inc., 51 Franklin ;; Street, Fifth Floor, Boston, MA 02110-1301, USA. The modern version uses a URL instead of a street address.