all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: Katsumi Yamaoka <yamaoka@jpl.org>
Cc: Lars Magne Ingebrigtsen <larsi@gnus.org>,
	Chong Yidong <cyd@gnu.org>,
	emacs-devel@gnu.org
Subject: Re: For insertion in trunk
Date: Tue, 26 Jun 2012 21:24:01 -0400	[thread overview]
Message-ID: <148vf9pmxa.fsf@fencepost.gnu.org> (raw)
In-Reply-To: b4mmx3pwpge.fsf@jpl.org

Katsumi Yamaoka wrote:

> I've set no-byte-compile and no-update-autoloads in those files.

OK, that works as a stopgap.

> (I'm going to try rebuilding now, though it takes time on Cygwin.)

Hydra will do it for you:
http://hydra.nixos.org/jobset/gnu/emacs-trunk

It's a nice service, although it has a few too many false build failures
(full disk, missing dependency, some other glitch, etc).

>> In any case surely these test files should be under test/, not lisp/?
>
> Currently those modules are of no use for the run time I believe.
> I only did sync of Ma Gnus and Emacs.

I don't understand. Not being used at runtime means they should go in
test/, like every other test file (including gnus-test.el).

They are no use at all in Emacs if they rely on parts of Gnus that are
not present though (whatever gnus-load is).


Also (my pet peeve) the license headers are obviously wrong in two of
them:

  ;; This file is not part of GNU Emacs.
  [...]
  ;; If not, write to the Free Software Foundation, Inc., 51 Franklin
  ;; Street, Fifth Floor, Boston, MA 02110-1301, USA.

The modern version uses a URL instead of a street address.



  reply	other threads:[~2012-06-27  1:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-20 13:55 For insertion in trunk Michael Albinus
2012-04-21  2:12 ` Stefan Monnier
2012-04-21  8:23   ` Michael Albinus
2012-04-21  8:11 ` Lars Magne Ingebrigtsen
2012-04-21  8:28   ` Michael Albinus
2012-04-21  9:34     ` Andreas Schwab
2012-04-23  2:01       ` Katsumi Yamaoka
2012-04-23  8:41         ` Lars Magne Ingebrigtsen
2012-04-23  9:23           ` Katsumi Yamaoka
2012-06-22 11:46             ` Katsumi Yamaoka
2012-06-24  9:11               ` Chong Yidong
2012-06-26 22:55                 ` Katsumi Yamaoka
2012-06-27  0:09                   ` Glenn Morris
2012-06-27  0:47                     ` Katsumi Yamaoka
2012-06-27  1:24                       ` Glenn Morris [this message]
2012-06-27  3:49                         ` Katsumi Yamaoka
2012-06-27  6:58                           ` Glenn Morris
2012-06-29  4:16                             ` Katsumi Yamaoka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=148vf9pmxa.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=cyd@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=yamaoka@jpl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.