From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Newsgroups: gmane.emacs.bugs Subject: bug#25525: 25.1.90; add color highlighting to css mode Date: Thu, 26 Jan 2017 19:25:13 +0100 Message-ID: <1485455113.4245.1@smtp.gmail.com> References: <87mvefh8br.fsf@tromey.com> <1485375833.1960.0@smtp.gmail.com> <"Simen \=\?utf-8\?Q\?Heggest\?\= \=\?utf-8\?Q\?\=C3\=B8yl\=22's\?\= message of "Wed, 25 Jan 2017 21:23:53 +0100"> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed X-Trace: blaine.gmane.org 1485455193 13043 195.159.176.226 (26 Jan 2017 18:26:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 26 Jan 2017 18:26:33 +0000 (UTC) Cc: 25525@debbugs.gnu.org To: Tom Tromey Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 26 19:26:28 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cWokN-0001oN-Pn for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Jan 2017 19:26:11 +0100 Original-Received: from localhost ([::1]:40497 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWokT-000794-1t for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Jan 2017 13:26:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57689) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWokJ-00077N-Dy for bug-gnu-emacs@gnu.org; Thu, 26 Jan 2017 13:26:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWokF-0001vT-CO for bug-gnu-emacs@gnu.org; Thu, 26 Jan 2017 13:26:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47718) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cWokF-0001vM-8c for bug-gnu-emacs@gnu.org; Thu, 26 Jan 2017 13:26:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cWokE-0007Vu-RE for bug-gnu-emacs@gnu.org; Thu, 26 Jan 2017 13:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Jan 2017 18:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25525 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25525-submit@debbugs.gnu.org id=B25525.148545512428765 (code B ref 25525); Thu, 26 Jan 2017 18:26:02 +0000 Original-Received: (at 25525) by debbugs.gnu.org; 26 Jan 2017 18:25:24 +0000 Original-Received: from localhost ([127.0.0.1]:45901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cWojc-0007Tq-Bo for submit@debbugs.gnu.org; Thu, 26 Jan 2017 13:25:24 -0500 Original-Received: from mail-lf0-f50.google.com ([209.85.215.50]:36212) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cWoja-0007TW-Gu for 25525@debbugs.gnu.org; Thu, 26 Jan 2017 13:25:23 -0500 Original-Received: by mail-lf0-f50.google.com with SMTP id z134so150019903lff.3 for <25525@debbugs.gnu.org>; Thu, 26 Jan 2017 10:25:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=6vyiEQ22mLgaF0D/UyrDToTNnX2iqYaGchCi0O2L5Ns=; b=L2ADxZMBtq62r9P7cRpDG14TrbvbhyKbhH2CFQNhiBPuzT8JpmE6ymj+942f8YhbIi bAQLMl3hbbP2YSkx4X7kkr+q7b/cgAVcFrqisQTZJZnGqyfoczn/e3zeklSthIhK0HIi X9LeSTgJ+NRsYaIOQfQKZWq1i3yly7iz4+Y8QMizOZgPZUz7OXJkNs/Lb0AZf9JiUBrm p7H+useRqFsUQICx5KPFvLKd++CxNNV9H1DPxiGpr5aD/BbZmemtQ+KHibZFBV4IjFpq fdOa38oOGW5IlM+nVcpNfQSybIwZRXBpnI8R1lL8cmR97Bg/DkV57a8UEGTeqJL9DzSn BJzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=6vyiEQ22mLgaF0D/UyrDToTNnX2iqYaGchCi0O2L5Ns=; b=J06lWJfLDWd6RkNlZVolWnZiC5JLRYzsBf5soewsFo0+/9h/4TxHUIftYulfAmAulS JnpNmttA5JrzK8zYyL5ya5K7LlxbRAzo8aSB2Z/a6OHHBHX0yXDT3d7li7wGVdsWDAjX wE895cHd5KawR+MdV8UuWlMtV6odyPx8SNZXjBtUFMhqVSKo6A/xWHJld1KpA8bmHWDX OML2DmD4rv3u/kASKlslaMgxaXjEwfUAiuejE8zPE1SoKeERY3Cvgz0E5nZPycV7+96L pUscsEyyixm8yanMUy4TtJUqgP7sWpLQ3GBwpm/q97eBSrPCrx/c4mznoGbjzlWtkW0S zeLQ== X-Gm-Message-State: AIkVDXJ161k1NZoQMtDCDF0CbUuOvSvriQ1ZKF96zDMCvWYJc1fQf6qcUdG8DgEs+Z/4TQ== X-Received: by 10.46.69.7 with SMTP id s7mr1622128lja.44.1485455116148; Thu, 26 Jan 2017 10:25:16 -0800 (PST) Original-Received: from [192.168.100.10] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id l133sm676443lfg.40.2017.01.26.10.25.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Jan 2017 10:25:15 -0800 (PST) In-Reply-To: <877f5ihge5.fsf@tromey.com> X-Mailer: geary/0.11.3 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128581 Archived-At: On Thu, Jan 26, 2017 at 12:24 AM, Tom Tromey wrote: > Simen> Thanks Tom, this looks to be a very nice addition to CSS mode! > Simen> Some comments: > [...] > > I think this version addresses all the review comments. Thanks Tom, that seems to fix all the issues I mentioned. I've come across one new problem when testing with the newest patch: Sometimes, in buffers that are long enough to scroll in, some colors aren't fontified until the line that contains the color is edited. I'm able to reproduce it in https://www.gnu.org/software/emacs/layout.css for instance, by opening the file and searching for "#". -- Simen