all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Simen Heggestøyl" <simenheg@gmail.com>
To: sunshavi@fastmail.fm, Michael Mauger <michael@mauger.com>
Cc: 25236@debbugs.gnu.org
Subject: bug#25236: 26.0.50; sql-postgres not working on master
Date: Fri, 30 Dec 2016 19:17:53 +0100	[thread overview]
Message-ID: <1483121873.22754.0@smtp.gmail.com> (raw)
In-Reply-To: <87vauftgz2.fsf@caral.i-did-not-set--mail-host-address--so-tickle-me>

This bug seems to be caused by a change I made in
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24646, making
`sql-postgres` able to complete the database name by looking at the
result of `psql -ltX`.

psql exits with status code 2 if the connection to the server went
bad, for instance if permissions are missing [1].

I think we can fix this by being more lax in
`sql-postgres-list-databases`, and just don't provide any completions
should the command fail. Then we'd also need to change the value of
the `REQUIRE-MATCH` parameter to `completing-read` on line 2966, since
requiring a match when there are no completions would make it
impossible to continue.

What do you think, Michael?

-- Simen

[1] 
https://www.postgresql.org/docs/current/static/app-psql.html#AEN98634






  reply	other threads:[~2016-12-30 18:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-20  3:30 bug#25236: 26.0.50; sql-postgres not working on master sunshavi
2016-12-30 18:17 ` Simen Heggestøyl [this message]
2017-01-04  3:16   ` Michael Mauger
2017-02-18 17:01     ` Simen Heggestøyl
2017-05-04 19:57       ` erreina
2017-07-29 16:26     ` Simen Heggestøyl
2017-07-29 17:15       ` bug#25236: new mail address (was: bug#25236: 26.0.50; sql-postgres not working on master) andrés ramírez
2017-08-07  1:01       ` bug#25236: 26.0.50; sql-postgres not working on master Michael Mauger
     [not found]         ` <a5m7xFNQkeRpgX_47Xz0JyMFjnO9mnKQXGyJcUcNrsv4THBUs3MB-WRw95G3uMKydbmO6iqKmCjp Nw-fgmo4vg==@protonmail.com>
2017-08-10 21:26           ` Simen Heggestøyl
2017-09-02 13:09             ` Eli Zaretskii
2017-09-05  0:18               ` Michael Mauger
     [not found]                 ` <Q9cdamlTWxEGS1Mjo7CPiTh35FxxlG4lWUukF0rR8xem_cIYrZKxQNoZtk0gBkPL393mVJg0kbSA 1hMZFvOoTQ==@protonmail.com>
2017-09-05 18:36                   ` Simen Heggestøyl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1483121873.22754.0@smtp.gmail.com \
    --to=simenheg@gmail.com \
    --cc=25236@debbugs.gnu.org \
    --cc=michael@mauger.com \
    --cc=sunshavi@fastmail.fm \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.