From: Paul Rankin <hello@paulwrankin.com>
To: 24073@debbugs.gnu.org
Subject: bug#24073: 24.5; outline-on-heading-p sees any invisible text property as outline inviisble
Date: Tue, 26 Jul 2016 18:12:33 +1000 [thread overview]
Message-ID: <1469520753.418402.676896009.00AAC0DE@webmail.messagingengine.com> (raw)
When attempting to use `outline' to collapse a heading that begins with a character with any invisible text property, the heading is mistakenly treated as invisible, when only a heading with the `outline' invisible text property should be considered invisible (i.e. collapsed).
To reproduce:
1. emacs -Q
2. insert ";;; heading"
3. M-: (outline-on-heading-p)
=> t
4. C-a
5. M-: (put-text-property (point) (1+ (point)) 'invisible 'foo)
6. M-; (outline-on-heading-p)
=> nil
Expected results:
(outline-on-heading-p)
=> t
Actual results:
(outline-on-heading-p)
=> nil
Solution:
The function outline-on-heading-p checks bolp for an invisible property, but not specifically the `outline' invisible property:
(defun outline-on-heading-p (&optional invisible-ok)
"Return t if point is on a (visible) heading line.
If INVISIBLE-OK is non-nil, an invisible heading line is ok too."
(save-excursion
(beginning-of-line)
(and (bolp) (or invisible-ok (not (outline-invisible-p)))
(looking-at outline-regexp))))
Instead, it should check for only the `outline' invisible text property:
(defun outline-on-heading-p (&optional invisible-ok)
"Return t if point is on a (visible) heading line.
If INVISIBLE-OK is non-nil, an invisible heading line is ok too."
(save-excursion
(beginning-of-line)
(and (bolp) (or invisible-ok (not (eq (outline-invisible-p) 'outline)))
(looking-at outline-regexp))))
--
Paul W. Rankin
www.paulwrankin.com
next reply other threads:[~2016-07-26 8:12 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 8:12 Paul Rankin [this message]
2016-07-26 9:29 ` bug#24073: 24.5; outline-on-heading-p sees any invisible text property as outline inviisble Paul Rankin
2016-07-26 15:14 ` Eli Zaretskii
2016-07-27 5:43 ` Paul Rankin
2016-07-28 4:25 ` bug#24073: 24.5; outline-on-heading-p sees any invisible text property as outline invisible Paul Rankin
2016-07-29 2:07 ` Noam Postavsky
2016-08-01 9:37 ` Paul Rankin
2016-08-01 14:16 ` npostavs
2016-08-02 3:27 ` Paul Rankin
2016-08-02 3:47 ` Noam Postavsky
2016-08-02 4:22 ` Paul Rankin
2016-08-02 14:27 ` Noam Postavsky
2016-08-02 7:20 ` Paul Rankin
2016-08-02 14:31 ` Noam Postavsky
2016-08-03 3:18 ` Paul Rankin
2016-08-31 1:12 ` bug#24073: 25.1-rc2 Paul Rankin
2016-08-31 2:41 ` Eli Zaretskii
2016-08-31 2:56 ` Paul Rankin
2016-08-31 8:59 ` John Wiegley
2016-08-31 9:12 ` Nicolas Petton
2016-08-31 14:25 ` Eli Zaretskii
2016-09-03 4:38 ` Paul Rankin
2016-09-18 14:39 ` Eli Zaretskii
2016-09-18 14:45 ` Nicolas Goaziou
2016-09-18 14:53 ` Eli Zaretskii
2016-09-19 9:40 ` Paul Rankin
2016-09-19 16:48 ` Eli Zaretskii
2016-09-20 5:37 ` Bastien Guerry
2016-09-30 8:06 ` Bastien Guerry
2017-03-30 8:18 ` Paul Rankin
2017-03-31 0:16 ` npostavs
2017-04-01 6:40 ` Paul Rankin
2017-04-01 7:20 ` Andreas Schwab
2017-04-01 8:06 ` Paul Rankin
2017-04-01 8:20 ` Andreas Schwab
2017-04-01 9:11 ` Paul Rankin
2017-04-01 9:37 ` Andreas Schwab
2017-04-01 10:18 ` Paul Rankin
2017-04-01 11:44 ` Eli Zaretskii
2017-04-01 12:05 ` Paul Rankin
2017-04-01 11:48 ` Andreas Schwab
2016-09-18 15:34 ` Bastien Guerry
2016-09-18 15:34 ` Bastien Guerry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469520753.418402.676896009.00AAC0DE@webmail.messagingengine.com \
--to=hello@paulwrankin.com \
--cc=24073@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.