From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thomas Koch Newsgroups: gmane.emacs.devel Subject: Re: Patch queue management systems Date: Mon, 08 Dec 2014 22:49:15 +0100 Message-ID: <14630069.9yU0C9RVCL@x121e> References: <546D2E75.6090701@cs.ucla.edu> <83fvct145r.fsf@gnu.org> <87zjb0ncqo.fsf@lifelogs.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit X-Trace: ger.gmane.org 1418075403 26813 80.91.229.3 (8 Dec 2014 21:50:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 8 Dec 2014 21:50:03 +0000 (UTC) Cc: Ted Zlatanov To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 08 22:49:55 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Xy6Bm-0006P8-7E for ged-emacs-devel@m.gmane.org; Mon, 08 Dec 2014 22:49:54 +0100 Original-Received: from localhost ([::1]:36310 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xy6Bl-0000EH-CE for ged-emacs-devel@m.gmane.org; Mon, 08 Dec 2014 16:49:53 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xy6BQ-0000Bj-OL for emacs-devel@gnu.org; Mon, 08 Dec 2014 16:49:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xy6BG-00037D-4Z for emacs-devel@gnu.org; Mon, 08 Dec 2014 16:49:29 -0500 Original-Received: from mx1.mailbox.org ([80.241.60.212]:55108) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xy6BF-000374-Uk for emacs-devel@gnu.org; Mon, 08 Dec 2014 16:49:22 -0500 Original-Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.mailbox.org (Postfix) with ESMTPS id 85CC9404DA; Mon, 8 Dec 2014 22:49:20 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Original-Received: from smtp1.mailbox.org ([80.241.60.240]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by hefe.heinlein-support.de (hefe.heinlein-support.de [91.198.250.172]) (amavisd-new, port 10030) with ESMTPS id SDxZlctTaVWs; Mon, 8 Dec 2014 22:49:19 +0100 (CET) User-Agent: KMail/4.14.1 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; ) In-Reply-To: <87zjb0ncqo.fsf@lifelogs.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.241.60.212 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:179485 Archived-At: We use gerrit at work so I can comment for it. On Saturday, December 06, 2014 08:12:31 AM Ted Zlatanov wrote: > My wishlist for a patch queue management system (PR/pull request system > for those familiar with the Github model): > > * targeted hydra builds for a specific branch I don't know hydra. We use jenkins which has a very good plugin to integrate with gerrit. Every commit that lands in gerrit triggers a jenkins build and jenkins leaves a vote afterwards in gerrit. Thus a human doesn't need to do a review as long as the jenkins build isn't good. > * a click-and-done way to merge a specific branch into master or emacs-24 This is called 'submit' in gerrit and it's click-and-done. > * maybe a comment system In gerrit you can comment and reply on every line of the commit, the commit message or comment on the whole change. > * maybe debbugs integration (but I do hate debbugs... really hate it...) - easy: link from gerrit changes to debbugs if a bug is referenced in the commit message - a bit more involved: trigger debbugs actions for actions in gerrit (new change, change merged...) > * ability to review the potential ChangeLog entries that will be > generated from the commit The commit message is part of the review. We generate changelogs from commit messages and add an 'ignore:' trailer if a commit should not be included in the changelog. A massive advantage of gerrit over reviewboard as used by the Apache Foundation is the frictionless integration with git. On the other hand gerrit is extremely powerful and customizable which might be a problem for somebody setting it up for the first time. Regards, Thomas Koch