From: "Simen Heggestøyl" <simenheg@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 23357-done@debbugs.gnu.org, dgutov@yandex.ru
Subject: bug#23357: [PATCH] Don't let `css--property-values' return duplicates
Date: Sun, 24 Apr 2016 20:04:24 +0200 [thread overview]
Message-ID: <1461521064.2508.0@smtp.gmail.com> (raw)
In-Reply-To: <jwvy483ukov.fsf-monnier+emacsbugs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 556 bytes --]
On Sun, Apr 24, 2016 at 4:51 PM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
> No they're not. It's the UI code (the code that calls
> completion-at-point-function) which is responsible for the removal
> of duplicates.
Ah, after rereading the conversation I see that I misunderstood it the
first time.
> This said, removal of duplicates within the completion table, like
> your
> patch does, is harmless, so this is not an objection against your
> patch.
OK, then I still find it sensible to tidy up duplicates here. Patch
installed!
-- Simen
[-- Attachment #2: Type: text/html, Size: 846 bytes --]
prev parent reply other threads:[~2016-04-24 18:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-24 12:57 bug#23357: [PATCH] Don't let `css--property-values' return duplicates Simen Heggestøyl
2016-04-24 14:51 ` Stefan Monnier
2016-04-24 18:04 ` Simen Heggestøyl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461521064.2508.0@smtp.gmail.com \
--to=simenheg@gmail.com \
--cc=23357-done@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.