From: Charles Strahan <charles@cstrahan.com>
To: emacs-devel@gnu.org
Subject: Re: support for true-color terminals
Date: Sun, 10 Apr 2016 22:16:24 -0400 [thread overview]
Message-ID: <1460340984.2930993.574696385.6C600EFA@webmail.messagingengine.com> (raw)
In-Reply-To: <1458288319.29675.552786858.0C058E99@webmail.messagingengine.com>
Hello,
Unless I've missed it, I don't think I've received an email regarding
copyright assignment. Could you point me at the requisite paperwork,
please?
Thanks!
-Charles
On Fri, Mar 18, 2016, at 04:05 AM, Charles Strahan wrote:
> On Fri, Mar 11, 2016, at 04:26 AM, Eli Zaretskii wrote:
> > > From: Charles Strahan <charles@cstrahan.com>
> > > Date: Thu, 10 Mar 2016 20:48:54 -0500
> > >
> > > A while back, there was an effort to add support for true-color
> > > terminals (by which I mean terminals supporting 16777216 simultaneous
> > > colors):
> > >
> > > http://emacs.1067599.n5.nabble.com/RFC-Add-tty-True-Color-support-td299962.html
> > >
> > > I've contacted Rüdiger, asking if he wouldn't mind if I pick up from
> > > where he left off, and he said that was fine as he's been too busy to
> > > work on this.
> > >
> > > I've attached to this email the patch that I'm using, based on his work.
> > > Any feedback would be greatly appreciated.
> > >
> > > This is my first (attempted) contribution to Emacs, and I'm very new to
> > > the code base, so there might be some silly mistakes that I'm unaware
> > > of. If we can get this polished enough for inclusion, I'd be more than
> > > happy to assign copyright.
> >
> > Thanks.
> >
> > First, I suggest that you start the legal paperwork rolling right now,
> > because without that, discussing such a non-trivial change would be
> > rather pointless. If you agree, I will send you the form off-list.
>
> Yes, I agree - thank you. I'll get the paperwork filled out as soon as I
> can.
>
> > As for the patch: my first comment is about the changes in
> > tty_look_up_color and in map_tty_color -- why are these needed? The
> > sheer number of the supported colors doesn't necessarily require any
> > changes in the basic design of TTY color support, so I'm not sure what
> > was the motivation for these changes.
> >
> > Also, why do we need the 'true-color' option introduced in
> > tty-colors.el? why isn't 'auto' enough for supporting this terminal?
>
> I'll try to answer your questions in the next day or two when my
> schedule frees up.
>
> -Charles
>
next prev parent reply other threads:[~2016-04-11 2:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 1:48 support for true-color terminals Charles Strahan
2016-03-11 8:26 ` Eli Zaretskii
2016-03-18 8:05 ` Charles Strahan
2016-04-11 2:16 ` Charles Strahan [this message]
2016-04-11 2:37 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460340984.2930993.574696385.6C600EFA@webmail.messagingengine.com \
--to=charles@cstrahan.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.