From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Newsgroups: gmane.emacs.bugs Subject: bug#23053: 25.0.92; error in cc-mode when editing C# file with a generic class inheritance Date: Sat, 26 Mar 2016 08:26:00 +0100 Message-ID: <1458977160.267408.560116754.57732967@webmail.messagingengine.com> References: <1458336813.1207699.553441090.44208CA4@webmail.messagingengine.com> <87wpozbd0r.fsf@acer.localhost.com> <1458372574.1341144.553674538.3D65409A@webmail.messagingengine.com> <1458376039.1351011.553705922.10F4D27F@webmail.messagingengine.com> <20160321122641.GA3641@acm.fritz.box> <1458564356.2685887.555173674.7F6E345D@webmail.messagingengine.com> <20160325185445.GA5003@acm.fritz.box> Reply-To: jostein@kjonigsen.net NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1458977242 8838 80.91.229.3 (26 Mar 2016 07:27:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 26 Mar 2016 07:27:22 +0000 (UTC) Cc: Ingo Lohmar , 23053@debbugs.gnu.org To: Alan Mackenzie , jostein@kjonigsen.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 26 08:27:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ajicp-0001QQ-4g for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Mar 2016 08:27:11 +0100 Original-Received: from localhost ([::1]:59192 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajico-0004Wn-4E for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Mar 2016 03:27:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49811) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajicl-0004Wd-0n for bug-gnu-emacs@gnu.org; Sat, 26 Mar 2016 03:27:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ajicg-0002Li-E5 for bug-gnu-emacs@gnu.org; Sat, 26 Mar 2016 03:27:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41127) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajicg-0002LV-3R; Sat, 26 Mar 2016 03:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ajicf-0003UX-VI; Sat, 26 Mar 2016 03:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Sat, 26 Mar 2016 07:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23053 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: Original-Received: via spool by 23053-submit@debbugs.gnu.org id=B23053.145897716313347 (code B ref 23053); Sat, 26 Mar 2016 07:27:01 +0000 Original-Received: (at 23053) by debbugs.gnu.org; 26 Mar 2016 07:26:03 +0000 Original-Received: from localhost ([127.0.0.1]:38254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ajibj-0003TD-6F for submit@debbugs.gnu.org; Sat, 26 Mar 2016 03:26:03 -0400 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:43620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ajibg-0003Sn-Ua for 23053@debbugs.gnu.org; Sat, 26 Mar 2016 03:26:01 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 5AF8E201CE for <23053@debbugs.gnu.org>; Sat, 26 Mar 2016 03:26:00 -0400 (EDT) Original-Received: from web5 ([10.202.2.215]) by compute5.internal (MEProxy); Sat, 26 Mar 2016 03:26:00 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:content-transfer-encoding :content-type:date:from:in-reply-to:message-id:mime-version :references:reply-to:subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=nvxk6p5Ko4IbMuFgNeI+hwQUbQ0=; b=u4JhOfHYad9aw5hghJeZQs8uDSX4 PShLgYQhK7sCnqLPEPcjAhK1dZ1TDkDRK0/tAEf2DU/Q3o0uPBOURFC0MUsFHuUn OmxnNn9nUvJ75Zb/6Tz0KCuWmq6n4QktGEyGiaO9HPU+USg6vqTYoGTMgiw8IVTR k35TTYAsyV85gU8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :reply-to:subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=nvxk6p 5Ko4IbMuFgNeI+hwQUbQ0=; b=EV3fyc0E3zOwUE4j0XdcbkNnTzTHqPVzcLXe/I j7SjyZLLTTjmg8hq+WCiC6LnLQMtWy5ComdoiQfbYyYJtCkW/p5XqMt06kBM5Mjt v7t7yLKQx0SazhhgDo/GnbQagQv1w8/VL9o044HSrPLRw7426vGglDXAEiLXMLlU Vztqo= Original-Received: by web5.nyi.internal (Postfix, from userid 99) id 28FC5A73179; Sat, 26 Mar 2016 03:26:00 -0400 (EDT) X-Sasl-Enc: 9uF9AiNGjeXKvV2wKSHtlZ6lMrkgBJnCQaUSByxTiMR4 1458977160 X-Mailer: MessagingEngine.com Webmail Interface - ajax-eaa4717d In-Reply-To: <20160325185445.GA5003@acm.fritz.box> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115505 Archived-At: On Fri, Mar 25, 2016, at 07:54 PM, Alan Mackenzie wrote: > Thanks. That was useful, and enabled me to reproduce the problem. It's > a separate bug from the one Saulius reported with csharp-mode, and occurs > only in the Emacs master branch. To be precise, a new variable > introduced in that branch hadn't been given a proper initial value for > Java (or, indeed, C#), so had the default value nil, which led to the > error happening. >=20 > This bug has now been fixed and committed to the master branch of the > Emacs git repository. Would you please get the latest version, and > confirm that the bug has been satisfactorally fixed. Thanks! > I've tested for both java-mode and csharp-mode. Once recompiled/reinstalled from melpa/marmalade csharp-mode loads fine now. Thanks for the fix! >> I'm still getting "wrong argument: stringp, nil" everywhere when >> pressing enter interactively inside Emacs csharp-mode buffers. >=20 > I hope that's now fixed. Indeed it is. > Yes, that is indeed the case. Two variables in master weren't > properly initialised for Java, Pike, ...., and derived modes. Sorry > about that! Shit happens. That's what bug-reports are for :) >> Trying to run a "make test" of csharp-mode against git master, most of >> the tests breaks: >=20 > Please let me know if this still happens. Now 14 tests pass and only 1 test related to fontification breaks. The fontification-tests have historically been somewhat unreliable, so I wouldn't worry too much about that. I'll consider this issue fixed at this point, and look into this single test later. >> Byte-compiling csharp-mode triggers a warning which so far haven't been >> an issue for csharp-mode: >=20 > Yes. Somebody in the Emacs team has decided that the second argument, > previously optional, is now mandatory. I wish people wouldn't do things > like that. The only thing sensible here is to add a second argument, > nil, to each call to looking-back. I've stalled doing this, due to not knowing if I will be changing the semantics of the code. Do you know if inserting this nil-parameter is what implicitly done by the compiler in cases such as these? Is such a change guaranteed "safe"? If you can confirm that, I can update the code to get rid of simple issues like this. > Can I ask you, as maintainer of csharp-mode: > (i) To insert "(eval-when-compile (require 'cc-langs))" near the top of > csharp-mode.el. > (ii) To add something to the manual telling users to compile > csharp-mode.el with the Emacs it's going to be run with. >=20 > (i) should help ensure csharp-mode gets properly compiled. (ii) should > also help ensure csharp-mode is properly compiled. :-) >=20 > --=20 > Alan Mackenzie (Nuremberg, Germany). Consider (i) done. As for (ii) that's usually not done by the user itself, but by Emacs whenever there's an update to the package on MELPA or marmalade. I can add a note to the related bug on the csharp-mode issue-tracker that this issue is resolved by reinstalling/recompiling the package though. Cheers! --=20 Jostein Kj=F8nigsen jostein@kjonigsen.net / jostein@secure.kjonigsen.net