From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Simen =?iso-8859-1?q?Heggest=F8yl?= Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 269d563: Support completion of attribute values in CSS mode Date: Thu, 24 Mar 2016 15:12:32 +0100 Message-ID: <1458828752.7618.0@smtp.gmail.com> References: <20160323180952.31942.96525@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="=-hJFEI2Ig1Aun9JLSElOf" X-Trace: ger.gmane.org 1458828780 7656 80.91.229.3 (24 Mar 2016 14:13:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 24 Mar 2016 14:13:00 +0000 (UTC) Cc: Dmitry Gutov , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 24 15:12:52 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aj60J-0003cS-Mz for ged-emacs-devel@m.gmane.org; Thu, 24 Mar 2016 15:12:51 +0100 Original-Received: from localhost ([::1]:50597 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aj60G-00044g-GC for ged-emacs-devel@m.gmane.org; Thu, 24 Mar 2016 10:12:48 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aj608-00043X-CS for emacs-devel@gnu.org; Thu, 24 Mar 2016 10:12:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aj605-0002fL-51 for emacs-devel@gnu.org; Thu, 24 Mar 2016 10:12:40 -0400 Original-Received: from mail-lb0-x22d.google.com ([2a00:1450:4010:c04::22d]:36776) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aj604-0002fD-TD for emacs-devel@gnu.org; Thu, 24 Mar 2016 10:12:37 -0400 Original-Received: by mail-lb0-x22d.google.com with SMTP id qe11so30946521lbc.3 for ; Thu, 24 Mar 2016 07:12:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=GngBUPWX6S/THkX+HpIYFv0RPljQTrcbyBLz5jQLDwc=; b=M6fDXo+e8jIxT03bE9eMwxdnklDaKwwORmuWOqrEQSIgvFCwH/hzyycRm/QdAh9OUl likrrxGnJD9yDQFCaVRA3EGvJXfgiMjvizsStBaSLBf3lOJ2bpEsHSjV6GhxgaFt9n4X W9/rd0JVfbcIY3/nY3UszH1ckbyM5c6n5ndFvLlJ1sgPQsSJ83hYXQxrQAgOpAba+QFg tXmVSp/vUwxJsuGbJsF4zJDUNm/VL+bh2v1CK/y8/V553+4y5FFZAWDrtZZTJ/YgJid2 NSTgXDL580zs+nkefAmP4rZVIbqAKvzlRN7lAT9iMl4/HvwcAAwMcd8IqVStpWZqnfTy JzmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=GngBUPWX6S/THkX+HpIYFv0RPljQTrcbyBLz5jQLDwc=; b=nBW2TuX7V2uSsWMoBDqny7U2lhiyQKoKDbe/zh0Hc3Fqyq6u5Uae/pmaMTNq0pOaP0 Qq0mcrYPtS+iHuFm8mLkZp+5Dr7R/0kftEOEm7hl0fHf1/7urX1kCbln8asOg+wGdltg p0p7wJ+H8sZmGSfwE6Y1Gc09LcmHJ12PX6FmW6BmCH68IHTHcIz9+jQOfnp3uQK6xPde y8WIKp5Ue0IDcyUjnzME4JO51weAhtB0Czw61gUE/wmu1uVMd+0B8Epujm6oXqzgYo+Q e1Od77bFFIF9NcUxV7pmbTf7KmOoiitiEAOU0HxgnPyA8509RosO+s048cRkN7DdG0Jf deOw== X-Gm-Message-State: AD7BkJJllxrpSFvJNuYvb7cWlr5eZVWMzgIKpSvovEJcPMkmqS/4zQnpZu0No9v6Db+f0w== X-Received: by 10.112.160.199 with SMTP id xm7mr2891221lbb.32.1458828755905; Thu, 24 Mar 2016 07:12:35 -0700 (PDT) Original-Received: from [192.168.100.5] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id r20sm1249305lfd.4.2016.03.24.07.12.34 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 24 Mar 2016 07:12:35 -0700 (PDT) In-Reply-To: X-Mailer: geary/0.10.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c04::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:202172 Archived-At: --=-hJFEI2Ig1Aun9JLSElOf Content-Type: text/plain; charset=utf-8; format=flowed On Wed, Mar 23, 2016 at 10:31 PM, Stefan Monnier wrote: > Does that now fully make company-css obsolete (well, obviously only > for > those users that use the bleeding edge version of Emacs)? Or are there > still some functionality that hasn't yet been ported? It depends on whether we want to support completion of HTML tags in selectors, that's the last remaining functionality that hasn't been ported I think. Personally I don't find much value in it, since I mostly use class names in selectors, and the HTML tags I do use are short and easy to type. But if others find it useful I can port it. Also, in SCSS there's no way of knowing whether the user is going to type a selector or a property (except at top-level), so we'll have to mix HTML tags and CSS property names in the completion list. For that reason I'll probably add an option to turn off HTML tag completion, if we decide to port it. What do you think? -- Simen --=-hJFEI2Ig1Aun9JLSElOf Content-Type: text/html; charset=utf-8 On Wed, Mar 23, 2016 at 10:31 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
Does that now fully make company-css obsolete (well, obviously only for those users that use the bleeding edge version of Emacs)? Or are there still some functionality that hasn't yet been ported?

It depends on whether we want to support completion of HTML tags in
selectors, that's the last remaining functionality that hasn't been
ported I think.

Personally I don't find much value in it, since I mostly use class names
in selectors, and the HTML tags I do use are short and easy to type. But
if others find it useful I can port it.

Also, in SCSS there's no way of knowing whether the user is going to
type a selector or a property (except at top-level), so we'll have to
mix HTML tags and CSS property names in the completion list. For that
reason I'll probably add an option to turn off HTML tag completion, if
we decide to port it.

What do you think?

-- Simen
--=-hJFEI2Ig1Aun9JLSElOf--