From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Newsgroups: gmane.emacs.bugs Subject: bug#22211: [PATCH] Add a face for CSS/SCSS variables Date: Sun, 27 Dec 2015 19:38:30 +0100 Message-ID: <1451241510.20532.1@smtp.gmail.com> References: <1450523545.4477.0@smtp.gmail.com> <1451240392.20532.0@smtp.gmail.com> <"Simen \=\?iso-8859-1\?Q\?He\?\= \=\?iso-8859-1\?Q\?ggest\=F8yl\=22's\?\= message of "Sun, 27 Dec 2015 19:19:52 +0100"> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-88nRGlOvmqQkuYJxr5x1" X-Trace: ger.gmane.org 1451241562 6583 80.91.229.3 (27 Dec 2015 18:39:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 27 Dec 2015 18:39:22 +0000 (UTC) Cc: Stefan Monnier , 22211@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 27 19:39:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aDGDo-0000ry-61 for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Dec 2015 19:39:12 +0100 Original-Received: from localhost ([::1]:42423 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDGDn-0006yY-Kp for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Dec 2015 13:39:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41059) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDGDi-0006yM-EB for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2015 13:39:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aDGDe-0005XS-Ex for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2015 13:39:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37138) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDGDe-0005XO-Az for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2015 13:39:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aDGDe-0005Mr-6l for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2015 13:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Dec 2015 18:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22211 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22211-submit@debbugs.gnu.org id=B22211.145124152620606 (code B ref 22211); Sun, 27 Dec 2015 18:39:02 +0000 Original-Received: (at 22211) by debbugs.gnu.org; 27 Dec 2015 18:38:46 +0000 Original-Received: from localhost ([127.0.0.1]:44740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDGDN-0005MH-3h for submit@debbugs.gnu.org; Sun, 27 Dec 2015 13:38:46 -0500 Original-Received: from mail-lf0-f50.google.com ([209.85.215.50]:34349) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDGDH-0005Lw-Qo for 22211@debbugs.gnu.org; Sun, 27 Dec 2015 13:38:43 -0500 Original-Received: by mail-lf0-f50.google.com with SMTP id y184so189388072lfc.1 for <22211@debbugs.gnu.org>; Sun, 27 Dec 2015 10:38:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version:content-type; bh=3I4jrjBzTvcgJScn/g46BupKtGsKPIRF61jLbcgzLjQ=; b=PwYZWi7iTo11ouddA1H/a0Qv1BUQclaSqp3UlObYl0JZe45jlq8GZWOjcdkQ/Ix0dk 4zS4RC1/8A0Kms3Ax3YVdraN1MWMdmsLwm0ZSva9z4LRO6WzXPKpR7bqwqh03zehtSf9 Rsn958Iozx7nnAiMhUUI8moYd9IHDpx/75nSp+cbJ1Aaf4Ph5p2jwY5h68l35OdxmB3j K6UxC/zeDqR191bR9X308y+FCM8fXQpwu9XQ+HTF/pTdGyEMzRe/tODkHatRXkpR8JPa 5oylmNPlIPAwxrSl1wa+n7AhaZtalmKKjPJaucTMdv45M1Lig8YCT1to/A7m4+m+mjZb L+pw== X-Received: by 10.25.87.12 with SMTP id l12mr18590115lfb.97.1451241514117; Sun, 27 Dec 2015 10:38:34 -0800 (PST) Original-Received: from [192.168.1.6] (77.17.190.234.tmi.telenormobil.no. [77.17.190.234]) by smtp.gmail.com with ESMTPSA id ak1sm9760324lbc.2.2015.12.27.10.38.32 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 27 Dec 2015 10:38:33 -0800 (PST) In-Reply-To: <87d1treog7.fsf@gnus.org> X-Mailer: geary/0.10.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:110823 Archived-At: --=-88nRGlOvmqQkuYJxr5x1 Content-Type: multipart/alternative; boundary="=-33dKJxUKavoc6ZU7y4Qe" --=-33dKJxUKavoc6ZU7y4Qe Content-Type: text/plain; charset=utf-8; format=flowed On Sun, Dec 27, 2015 at 7:28 PM, Lars Ingebrigtsen wrote: > The patch is corrupted. Try including it as an attachment instead. Thanks for catching that, Lars. I've included it as an attachement instead. -- Simen --=-33dKJxUKavoc6ZU7y4Qe Content-Type: text/html; charset=utf-8 On Sun, Dec 27, 2015 at 7:28 PM, Lars Ingebrigtsen <larsi@gnus.org> wrote:
The patch is corrupted. Try including it as an attachment instead.

Thanks for catching that, Lars. I've included it as an attachement instead.

-- Simen
--=-33dKJxUKavoc6ZU7y4Qe-- --=-88nRGlOvmqQkuYJxr5x1 Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Highlight-CSS-variables-with-variable-name-face.patch >From 84bea3c332b32626d0579e8f8be164d832d0a557 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simen=20Heggest=C3=B8yl?= Date: Sun, 27 Dec 2015 19:12:58 +0100 Subject: [PATCH] Highlight CSS variables with variable name face * lisp/textmodes/css-mode.el (css-nmstart-re): Don't match variables. (css--font-lock-keywords): Highlight variables in `font-lock-variable-name-face'. --- lisp/textmodes/css-mode.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index 3e84b43..0bcd1ee 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -215,7 +215,7 @@ css-syntax-propertize-function (defconst css-escapes-re "\\\\\\(?:[^\000-\037\177]\\|[0-9a-fA-F]+[ \n\t\r\f]?\\)") (defconst css-nmchar-re (concat "\\(?:[-[:alnum:]]\\|" css-escapes-re "\\)")) -(defconst css-nmstart-re (concat "\\(?:--\\)?\\(?:[[:alpha:]]\\|" css-escapes-re "\\)")) +(defconst css-nmstart-re (concat "\\(?:[[:alpha:]]\\|" css-escapes-re "\\)")) (defconst css-ident-re ;; (concat css-nmstart-re css-nmchar-re "*") ;; Apparently, "at rules" names can start with a dash, e.g. @-moz-keyframes. (concat css-nmchar-re "+")) @@ -246,6 +246,8 @@ css--font-lock-keywords ;; Since "An at-rule consists of everything up to and including the next ;; semicolon (;) or the next block, whichever comes first." (,(concat "@" css-ident-re) (0 font-lock-builtin-face)) + ;; Variables. + (,(concat "--" css-ident-re) (0 font-lock-variable-name-face)) ;; Selectors. ;; FIXME: attribute selectors don't work well because they may contain ;; strings which have already been highlighted as f-l-string-face and -- 2.6.4 --=-88nRGlOvmqQkuYJxr5x1--