From: Ryan Yeske <ryan@ryanyeske.com>
To: Dave Barker <kzar@kzar.co.uk>
Cc: Leo Liu <sdl.web@gmail.com>,
Artur Malabarba <bruce.connor.am@gmail.com>,
emacs-devel@gnu.org
Subject: Re: PATCH: Add the ability to give rcirc servers an alias name
Date: Tue, 15 Dec 2015 22:16:11 -0800 [thread overview]
Message-ID: <1450246571.999218.468767129.1BD269CA@webmail.messagingengine.com> (raw)
In-Reply-To: <CAH+bdfR1Hkv9p+tZsdpwdyn0xc9VBAWkp-iACMvqAXbpXDZXaQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 840 bytes --]
Hi Dave,
I got a chance to review this. It works fine for me here.
I think it might be good to replace the several instances of `(or server-
alias server)' with calls to a new function `rcirc-server-or-alias`.
Also, what about automatically creating this alias when connecting to a
server multiple times, without requiring the user to come up with an
alias? Like automatically creating the server name `*irc.freenode.net*'
and `*irc.freenode.net<1>'. This would only happen if disambiguating
aliases were not provided via your new mechanism.
What do you think?
Ryan
On Sun, Dec 13, 2015, at 10:23 AM, Dave Barker wrote:
> Any chance someone could look at this for me? I've been using this
> patch with great results since I posted it and it would be nice to see
> it land upstream.
>
> Cheers, Dave.
[-- Attachment #2: Type: text/html, Size: 1295 bytes --]
next prev parent reply other threads:[~2015-12-16 6:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-07 23:00 PATCH: Add the ability to give rcirc servers an alias name Dave Barker
2015-11-08 17:45 ` Dave Barker
2015-11-08 19:22 ` Artur Malabarba
2015-11-08 18:52 ` Ryan Yeske
2015-11-08 19:01 ` Dave Barker
2015-11-18 11:20 ` Dave Barker
2015-12-13 18:23 ` Dave Barker
2015-12-16 6:16 ` Ryan Yeske [this message]
2015-12-16 12:29 ` Dave Barker
2015-12-17 18:40 ` Ryan Yeske
2015-12-18 10:46 ` Dave Barker
2015-12-18 13:34 ` Artur Malabarba
2015-12-18 14:52 ` Dave Barker
2016-01-03 23:11 ` Artur Malabarba
2016-01-07 11:52 ` Dave Barker
2016-01-07 16:12 ` Eli Zaretskii
2016-01-07 19:23 ` Artur Malabarba
2016-01-08 5:57 ` Richard Stallman
2016-01-08 11:07 ` Dave Barker
2016-01-09 3:23 ` Richard Stallman
2016-01-31 14:05 ` Dave Barker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450246571.999218.468767129.1BD269CA@webmail.messagingengine.com \
--to=ryan@ryanyeske.com \
--cc=bruce.connor.am@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=kzar@kzar.co.uk \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.