From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Newsgroups: gmane.emacs.bugs Subject: bug#21798: 25.0.50; [PATCH] Add support for retrieving paths to JSON elements Date: Sun, 08 Nov 2015 13:32:13 +0100 Message-ID: <1446985933.1975.0@smtp.gmail.com> References: <1446281162.2607.0@smtp.gmail.com> <5634CEE7.3070200@yandex.ru> <1446407553.4906.0@smtp.gmail.com> <1446420466.13180.0@smtp.gmail.com> <56381558.7050607@yandex.ru> <1446827488.11140.2@smtp.gmail.com> <563CE043.9060404@yandex.ru> <1446922215.4732.0@smtp.gmail.com> <563E4E73.50702@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="=-081SO8yKnWfC+wfhXb4b" X-Trace: ger.gmane.org 1446986006 31520 80.91.229.3 (8 Nov 2015 12:33:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 8 Nov 2015 12:33:26 +0000 (UTC) Cc: 21798@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 08 13:33:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZvP9k-0004N8-KC for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Nov 2015 13:33:12 +0100 Original-Received: from localhost ([::1]:47122 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvP9j-0001hr-MW for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Nov 2015 07:33:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvP9f-0001hl-NL for bug-gnu-emacs@gnu.org; Sun, 08 Nov 2015 07:33:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZvP9a-0001Ms-N5 for bug-gnu-emacs@gnu.org; Sun, 08 Nov 2015 07:33:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38389) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvP9a-0001Mo-JG for bug-gnu-emacs@gnu.org; Sun, 08 Nov 2015 07:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZvP9a-0000Jk-BZ for bug-gnu-emacs@gnu.org; Sun, 08 Nov 2015 07:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Nov 2015 12:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21798 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 21798-submit@debbugs.gnu.org id=B21798.14469859401161 (code B ref 21798); Sun, 08 Nov 2015 12:33:02 +0000 Original-Received: (at 21798) by debbugs.gnu.org; 8 Nov 2015 12:32:20 +0000 Original-Received: from localhost ([127.0.0.1]:57330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZvP8t-0000Ie-IB for submit@debbugs.gnu.org; Sun, 08 Nov 2015 07:32:20 -0500 Original-Received: from mail-lb0-f179.google.com ([209.85.217.179]:35720) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZvP8q-0000IR-UD for 21798@debbugs.gnu.org; Sun, 08 Nov 2015 07:32:17 -0500 Original-Received: by lbces9 with SMTP id es9so13186830lbc.2 for <21798@debbugs.gnu.org>; Sun, 08 Nov 2015 04:32:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version:content-type; bh=0tBFrArtW7A/gn1LgT1bqMbKyMKGF3070mh6yYB2YtA=; b=pBmODAjq+h4R9oPUSc3ne4RPRH7Sg49ttbzQqbybtswYdZWZnMONtzHVnb6dyhRNu8 SulWXKmLVTi8iPZfPDe3c/9801Oir/X4oQeiXB7qcr7+32z5rPlrJ8Gd63OYKmKl5NcC 4IIGio3SAiw9sNLVbAteYwLFYOrigAeF7DU4CxNeWDmNtH2dlouqMOeDabgxlGp+HHgu 7bQenL7xpGkFo+d5Gnnw1ccRitrCXgapn0S/i6aLxhdNzvwHboL4FfnWEeJvqLPR25l3 CwAR2H+xa5xQiVa4lMbonFHkyKP45vLQjZ7z5glY9H65fuzfucDcgapg9xfWUybkx7Xh 09yQ== X-Received: by 10.112.188.168 with SMTP id gb8mr11379070lbc.6.1446985935832; Sun, 08 Nov 2015 04:32:15 -0800 (PST) Original-Received: from [192.168.100.7] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id re5sm1533891lbb.36.2015.11.08.04.32.14 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Nov 2015 04:32:15 -0800 (PST) In-Reply-To: <563E4E73.50702@yandex.ru> X-Mailer: geary/0.10.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108567 Archived-At: --=-081SO8yKnWfC+wfhXb4b Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Thanks again for your feedback, Dmitry. On Sat, Nov 7, 2015 at 8:18 PM, Dmitry Gutov wrote: > Shouldn't they be called by `json-read' itself? Yes, maybe they should. The only drawback I see is that 'json-read' then needs to accept an optional parameter, which is the JSON key of the current element. A revised patch implementing your suggestion is attached. Benchmarks follow below, with the usual setup! Before the patch: (benchmark-run 100 (json-read-from-string huge-json)) =E2=87=92 (18.782874379000003 1007 5.674178575000008) After the patch: (benchmark-run 100 (json-read-from-string huge-json)) =E2=87=92 (18.233328517999997 1007 4.907621599000008) -- Simen = --=-081SO8yKnWfC+wfhXb4b Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Thanks again for your feedback, Dmitry.

On Sat, No= v 7, 2015 at 8:18 PM, Dmitry Gutov <dgutov@yandex.ru> wrote:
Shouldn't they be called by `json-read' itself?

<= div>
Yes, maybe they should. The only drawback I see is that 'json-read= ' then
needs to accept an optional parameter, which is the JSON k= ey of the
current element.

A revised pat= ch implementing your suggestion is attached.

Bench= marks follow below, with the usual setup!

Before t= he patch:

(benchmark-run 100 (json-read-from-strin= g huge-json))
     =E2=87=92 (18.782874379000003 1= 007 5.674178575000008)

After the patch:
=
(benchmark-run 100 (json-read-from-string huge-json))
<= div>     =E2=87=92 (18.233328517999997 1007 4.90762159900000= 8)

-- Simen

= --=-081SO8yKnWfC+wfhXb4b--