[PATCH] Fix misspelling in flyspell.el

[PATCH] Fix misspelling in flyspell.el

[Keshav Kini]

* flyspell.el (flyspell-goto-next-error): fix misspelling

Copyright-paperwork-exempt: yes
---
 lisp/textmodes/flyspell.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/textmodes/flyspell.el b/lisp/textmodes/flyspell.el
index 6c4a731..fa3fba6 100644
--- a/lisp/textmodes/flyspell.el
+++ b/lisp/textmodes/flyspell.el
@@ -1673,7 +1673,7 @@ FLYSPELL-BUFFER."
     (setq flyspell-old-buffer-error (current-buffer))
     (goto-char pos)
     (if (= pos max)
-	(message "No more miss-spelled word!"))))
+        (message "No more misspelled words!"))))
 
 ;;*---------------------------------------------------------------------*/
 ;;*    flyspell-overlay-p ...                                           */
-- 
2.6.2

Re: [PATCH] Fix misspelling in flyspell.el

[Alan Mackenzie]

Hello, Keshav

On Fri, Nov 06, 2015 at 03:16:23PM -0600, Keshav Kini wrote:
> * flyspell.el (flyspell-goto-next-error): fix misspelling

> Copyright-paperwork-exempt: yes
> ---
>  lisp/textmodes/flyspell.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/lisp/textmodes/flyspell.el b/lisp/textmodes/flyspell.el
> index 6c4a731..fa3fba6 100644
> --- a/lisp/textmodes/flyspell.el
> +++ b/lisp/textmodes/flyspell.el
> @@ -1673,7 +1673,7 @@ FLYSPELL-BUFFER."
>      (setq flyspell-old-buffer-error (current-buffer))
>      (goto-char pos)
>      (if (= pos max)
> -	(message "No more miss-spelled word!"))))
> +        (message "No more misspelled words!"))))
 
>  ;;*---------------------------------------------------------------------*/
>  ;;*    flyspell-overlay-p ...                                           */
> -- 
> 2.6.2

I think there's a good chance that that missssspelling is deliberate, a
little joke, something to irritate people slightly with.  It would be a
shame to correct it.

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: [PATCH] Fix misspelling in flyspell.el

[Ashton Kemerling]

Alan Mackenzie <acm@muc.de> writes:

> Hello, Keshav
>
> On Fri, Nov 06, 2015 at 03:16:23PM -0600, Keshav Kini wrote:
>> * flyspell.el (flyspell-goto-next-error): fix misspelling
>
>> Copyright-paperwork-exempt: yes
>> ---
>>  lisp/textmodes/flyspell.el | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
>> diff --git a/lisp/textmodes/flyspell.el b/lisp/textmodes/flyspell.el
>> index 6c4a731..fa3fba6 100644
>> --- a/lisp/textmodes/flyspell.el
>> +++ b/lisp/textmodes/flyspell.el
>> @@ -1673,7 +1673,7 @@ FLYSPELL-BUFFER."
>>      (setq flyspell-old-buffer-error (current-buffer))
>>      (goto-char pos)
>>      (if (= pos max)
>> -	(message "No more miss-spelled word!"))))
>> +        (message "No more misspelled words!"))))
>  
>>  ;;*---------------------------------------------------------------------*/
>>  ;;*    flyspell-overlay-p ...                                           */
>> -- 
>> 2.6.2
>
> I think there's a good chance that that missssspelling is deliberate, a
> little joke, something to irritate people slightly with.  It would be a
> shame to correct it.


If anything, it should be left as a testament to why flyspell is
necessary.

--
Ashton

Re: [PATCH] Fix misspelling in flyspell.el

[Eli Zaretskii]

> Date: Fri, 6 Nov 2015 21:46:30 +0000
> From: Alan Mackenzie <acm@muc.de>
> Cc: emacs-devel@gnu.org
> 
> > -	(message "No more miss-spelled word!"))))
> > +        (message "No more misspelled words!"))))
>  
> >  ;;*---------------------------------------------------------------------*/
> >  ;;*    flyspell-overlay-p ...                                           */
> > -- 
> > 2.6.2
> 
> I think there's a good chance that that missssspelling is deliberate, a
> little joke, something to irritate people slightly with.  It would be a
> shame to correct it.

Given the person who wrote that code, I agree with Alan.

Re: [PATCH] Fix misspelling in flyspell.el

[David Kastrup]

Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Fri, 6 Nov 2015 21:46:30 +0000
>> From: Alan Mackenzie <acm@muc.de>
>> Cc: emacs-devel@gnu.org
>> 
>> > -	(message "No more miss-spelled word!"))))
>> > +        (message "No more misspelled words!"))))
>>  
>> >  ;;*---------------------------------------------------------------------*/
>> >  ;;*    flyspell-overlay-p ...                                           */
>> > -- 
>> > 2.6.2
>> 
>> I think there's a good chance that that missssspelling is deliberate, a
>> little joke, something to irritate people slightly with.  It would be a
>> shame to correct it.
>
> Given the person who wrote that code, I agree with Alan.

Since flyspell isn't a grammar checker, I'd still advocate replacing
"word" with "words" in the message.  "No more ... word!" seems like
stretching the concept of the joke.

-- 
David Kastrup

Re: [PATCH] Fix misspelling in flyspell.el

[Keshav Kini]

On 11/06/2015 03:46 PM, Alan Mackenzie wrote:
> I think there's a good chance that that missssspelling is deliberate, a
> little joke, something to irritate people slightly with.  It would be a
> shame to correct it.

Hi Alan (and others),

Oops, it didn't cross my mind that it could be a joke!  I think David is
right, though.  As the message stands, it might not be that obvious that
it's a joke -- indeed, I'm living witness to that fact :)  I mistook it
for just an error message written by a non-native English speaker, and
didn't think to run a `git blame` to find out who wrote it.

I'll reroll the patch with a different message that preserves the joke
but makes it more obvious that it's a joke.  That way I'll hopefully
prevent anyone else from writing similar patches in the future ;)

Thanks,
    Keshav

[PATCH v1] Reword message in flyspell.el

[Keshav Kini]

It wasn't abundantly clear that the message "No more miss-spelled word!"
was supposed to be a joke, so I tweaked it a bit.

* flyspell.el (flyspell-goto-next-error): reword message

Copyright-paperwork-exempt: yes
---
 lisp/textmodes/flyspell.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/textmodes/flyspell.el b/lisp/textmodes/flyspell.el
index 6c4a731..a8a36db 100644
--- a/lisp/textmodes/flyspell.el
+++ b/lisp/textmodes/flyspell.el
@@ -1673,7 +1673,7 @@ FLYSPELL-BUFFER."
     (setq flyspell-old-buffer-error (current-buffer))
     (goto-char pos)
     (if (= pos max)
-	(message "No more miss-spelled word!"))))
+        (message "No more missspelled words! ;-)"))))
 
 ;;*---------------------------------------------------------------------*/
 ;;*    flyspell-overlay-p ...                                           */
-- 
2.6.2

Re: [PATCH] Fix misspelling in flyspell.el

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > Oops, it didn't cross my mind that it could be a joke!  I think David is
  > right, though.

We will cast you into Misspelheim for this!

-- 
Dr Richard Stallman
President, Free Software Foundation (gnu.org, fsf.org)
Internet Hall-of-Famer (internethalloffame.org)
Skype: No way! See stallman.org/skype.html.