From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Newsgroups: gmane.emacs.bugs Subject: bug#21465: [PATCH] CC-modes hierarchy Date: Sat, 19 Sep 2015 20:43:14 +0200 Message-ID: <1442688194.3803932.388172161.1040AB59@webmail.messagingengine.com> References: Reply-To: jostein@kjonigsen.net NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1442688265 17599 80.91.229.3 (19 Sep 2015 18:44:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 19 Sep 2015 18:44:25 +0000 (UTC) To: 21465@debbugs.gnu.org, Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 19 20:44:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZdN7M-0005bM-5X for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Sep 2015 20:44:12 +0200 Original-Received: from localhost ([::1]:47361 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZdN7K-0000qK-Lu for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Sep 2015 14:44:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZdN7I-0000qE-7X for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2015 14:44:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZdN7H-0001rg-13 for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2015 14:44:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45699) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZdN7C-0001p3-Qs; Sat, 19 Sep 2015 14:44:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZdN7C-00030K-GM; Sat, 19 Sep 2015 14:44:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Sat, 19 Sep 2015 18:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21465 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: patch Original-Received: via spool by 21465-submit@debbugs.gnu.org id=B21465.144268819811492 (code B ref 21465); Sat, 19 Sep 2015 18:44:02 +0000 Original-Received: (at 21465) by debbugs.gnu.org; 19 Sep 2015 18:43:18 +0000 Original-Received: from localhost ([127.0.0.1]:37909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZdN6T-0002zI-TZ for submit@debbugs.gnu.org; Sat, 19 Sep 2015 14:43:18 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:39076) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZdN6R-0002z9-A4 for 21465@debbugs.gnu.org; Sat, 19 Sep 2015 14:43:16 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C028A201F5 for <21465@debbugs.gnu.org>; Sat, 19 Sep 2015 14:43:14 -0400 (EDT) Original-Received: from web3 ([10.202.2.213]) by compute1.internal (MEProxy); Sat, 19 Sep 2015 14:43:14 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= secure.kjonigsen.net; h=content-transfer-encoding:content-type :date:from:message-id:mime-version:reply-to:subject:to :x-sasl-enc:x-sasl-enc; s=mesmtp; bh=1lK9WTk1Lr04yGOp4vEaaGE1JLs =; b=nMXVMNdgZnCb2qup6UuYVeg6WlwljW8QOYfGquVVU520CBLn5fZmi2HvJDP I2brZsojvDooXkv2jmal1eyJN3bp/V+pTa/eTpv89frFYgUtRHPXu16vq2BgMU6J dchTHsuDa+tiRsPoUZZ2SgElk9rqIWm893RrFglWhwHJyo8g= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:message-id:mime-version:reply-to:subject:to :x-sasl-enc:x-sasl-enc; s=smtpout; bh=1lK9WTk1Lr04yGOp4vEaaGE1JL s=; b=UWLMK+z+SolJx/ItvNMcjg4utE/YTUG6acySPZvNTyQ36b0dZXvMNqjoWW ++FU/uvzL+BK8f+xq9icVCMlM51E/ahlsSXmtshvUnIhFlvJ7gbmB0xoFthGutQI d+uluRfQbj/nwl9TIYhKr1cvS52fGqaeAnChbwVcR+VmCd7fI= Original-Received: by web3.nyi.internal (Postfix, from userid 99) id 9787710601D; Sat, 19 Sep 2015 14:43:14 -0400 (EDT) X-Sasl-Enc: 3GayotLVz/4Zc7To3WiQp/lXDIgKyND50bqc6GTcE+YG 1442688194 X-Mailer: MessagingEngine.com Webmail Interface - ajax-e92f8263 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106708 Archived-At: > Any objection to the patch below? >=20 > It does the following: > - Remove c-make-inherited-keymap, since it's not used any more. >=20 > AFAIK this patch has no issues w.r.t compatibility since it relies on > behavior of define-derived-mode which has existed since "for ever" csharp-mode[1] is not hosted on ELPA or in Emacs core, so I'm not going to blame Emacs developers for not checking it, but it may have issues with this patch. csharp-mode has gone halfway through a transition to use of "make-derive-mode", but it's not 100% there. That means that it currently (still) uses "c-make-inherited-keymap" to configure itself[2]. If fixing it on my end is easy, I guess that will be easier than objecting to this patch. I see there's a suggestion posted[3] which I can try out. Just thought I'd put it out there that there are indeed more 3rd party modules depending on the current implementation. [1] https://github.com/josteink/csharp-mode [2] https://github.com/josteink/csharp-mode/blob/master/csharp-mode.el#L1428-L1= 430 [3] http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D21465#17 -- Jostein Kj=F8nigsen jostein@kjonigsen.net / jostein@secure.kjonigsen.net