Re: [PATCH] Handle output from Emacs byte-compilation properly

["Jostein Kjønigsen" <jostein@secure.kjonigsen.net>]

[-- Attachment #1: Type: text/plain, Size: 1388 bytes --]

The previous patch is not  a good one and there's an error in it. Please
disregard
the previous patch and consider the attached patch instead.

You'll have to take my word for it when I say I -did- test it before
submitting. :)

--
Jostein Kjønigsen
jostein@kjonigsen.net / jostein@secure.kjonigsen.net


On Mon, Sep 14, 2015, at 10:14 PM, Jostein Kjønigsen wrote:
> It's common for module-developers to run Emacs byte-compilation in
> separate build-scripts.
> 
> When invoking byte-compile on Emacs-lisp files you often get the
> following headers:
> 
> - In toplevel form:
> - In end of data:
> 
> When these errors show up in the output of a build-script initiated
> through M-x compile and show up in a compilation-mode buffer, these
> lines gets treated as guile-errors for files which doesn't exist.
> 
> This is due to the following regexp, which is quite frankly extremely
> wide:
> 
>     (guile-file "^In \\(.+\\):\n" 1)
> 
> This breaks prev-error and next-error based navigation because the
> files "toplevel form" and "end of data" doesn't exist.
> 
> This patch ensures those lines are treated as information only before
> getting to the guile-file regexp.
> 
> --
> Jostein Kjønigsen
> jostein@kjonigsen.net / jostein@secure.kjonigsen.net
> Email had 1 attachment:


> * compilation-mode-emacs-lisp.patch
>   2k (text/x-patch)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: compilation-mode-emacs-lisp.patch --]
[-- Type: text/x-patch; name="compilation-mode-emacs-lisp.patch", Size: 1619 bytes --]

From 8a2c39dcd3d2609f571eae9fa1a16d34dba91f3c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jostein=20Kj=C3=B8nigsen?= <jostein@kjonigsen.net>
Date: Mon, 14 Sep 2015 21:43:57 +0200
Subject: [PATCH] Handle output from Emacs byte-compilation properly

It's common for module-developers to run Emacs byte-compilation in
separate build-scripts.

When invoking byte-compile on Emacs-lisp files you often get the
following headers:

- In toplevel form:
- In end of data:

When these errors show up in the output of a build-script initiated
through M-x compile and show up in a compilation-mode buffer, these
lines gets treated as guile-errors for files with the respective names
"toplevel form" and "end of data".

This breaks prev-error and next-error based navigation.

This patch ensures those lines are treated as information only before
getting to the guile-files regexp.
---
 lisp/progmodes/compile.el | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index a6e9ed8..cb5c884 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -477,6 +477,11 @@ File = \\(.+\\), Line = \\([0-9]+\\)\\(?:, Column = \\([0-9]+\\)\\)?"
      ;;
      "^\\([^ \t\r\n(]+\\) (\\([0-9]+\\):\\([0-9]+\\)) "
      1 2 3)
+
+    ;; ensure emacs-info headers are not treated as guile-errors.
+    ;; created using (rx (or "In toplevel form:" "In end of data:"))
+    (elisp-info "\\(?:In \\(?:\\(?:end of data\\|toplevel form\\):\\)\\)" nil nil nil 0)
+
     (guile-file "^In \\(.+\\):\n" 1)
     (guile-line "^ *\\([0-9]+\\): *\\([0-9]+\\)" nil 1 2)
     )
-- 
1.9.1