From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#39290: [PATCH] Correct regexp for flags in 'format' doc string Date: Sun, 26 Jan 2020 15:21:02 +0100 Message-ID: <1435B249-47D1-4546-9B3F-6C67FAD16EB5@acm.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_DE8C5A97-330D-4D1C-8825-0638123C13C1" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="98033"; mail-complaints-to="usenet@ciao.gmane.io" To: 39290@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 26 15:22:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ivinl-000PTH-Lp for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Jan 2020 15:22:13 +0100 Original-Received: from localhost ([::1]:34232 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ivink-0007kN-Qo for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Jan 2020 09:22:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42301) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ivinb-0007k9-Jq for bug-gnu-emacs@gnu.org; Sun, 26 Jan 2020 09:22:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ivina-0004wf-Iz for bug-gnu-emacs@gnu.org; Sun, 26 Jan 2020 09:22:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50679) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ivina-0004vz-5X for bug-gnu-emacs@gnu.org; Sun, 26 Jan 2020 09:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ivina-0000jO-1j for bug-gnu-emacs@gnu.org; Sun, 26 Jan 2020 09:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Jan 2020 14:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 39290 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15800484762749 (code B ref -1); Sun, 26 Jan 2020 14:22:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 26 Jan 2020 14:21:16 +0000 Original-Received: from localhost ([127.0.0.1]:56652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivimq-0000iH-6i for submit@debbugs.gnu.org; Sun, 26 Jan 2020 09:21:16 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:47039) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivimn-0000i8-7b for submit@debbugs.gnu.org; Sun, 26 Jan 2020 09:21:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42216) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iviml-0007ZL-Vl for bug-gnu-emacs@gnu.org; Sun, 26 Jan 2020 09:21:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ivimk-0003gK-O5 for bug-gnu-emacs@gnu.org; Sun, 26 Jan 2020 09:21:11 -0500 Original-Received: from mail76c50.megamailservers.eu ([91.136.10.86]:41994 helo=mail70c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ivimk-0003dI-6p for bug-gnu-emacs@gnu.org; Sun, 26 Jan 2020 09:21:10 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1580048465; bh=AQg2+twX73CKR2wL20INOLPWkhRByBE38JOYVNcI2eo=; h=From:Subject:Date:To:From; b=QeGYj0M01H6KJTbmJyHcLqjfTksqbBKQOigMKA/659NvH35DAkHEohEpVeoHnyWLd 4SYxnOkPzB4Jb0pOs3QBIOIoDh7k9yM20L3WkxSkylgC8IhQT4706WxF9BVNKhjeEZ phVKcae48Pyy8XDzBorXdSFNsLpZy5Am/OaT6JHo= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail70c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 00QEL3LO009167 for ; Sun, 26 Jan 2020 14:21:05 +0000 X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0214.5E2DA051.0004, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=c6bVvi1l c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=M51BFTxLslgA:10 a=48AkvT27whSlDIdDpAkA:9 a=CjuIK1q_8ugA:10 a=1EqHv2zIUh71slR-qCUA:9 a=B2y7HmGcmWMA:10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175298 Archived-At: --Apple-Mail=_DE8C5A97-330D-4D1C-8825-0638123C13C1 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii The doc string for 'format' contains where field is [0-9]+ followed by a literal dollar "$", flags is [+ #-0]+, width is [0-9]+, and precision is a literal period "." followed by [0-9]+. The spec for flags isn't a correct regexp; the hyphen should be last. = This matters, because people copy it into their code without thinking = (observed in the wild). Patch acceptable for emacs-27? --Apple-Mail=_DE8C5A97-330D-4D1C-8825-0638123C13C1 Content-Disposition: attachment; filename=0001-Correct-regexp-for-flags-in-format-doc-string.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Correct-regexp-for-flags-in-format-doc-string.patch" Content-Transfer-Encoding: quoted-printable =46rom=205245a818d978a96c17c3ec7b99d93e32a07f90e6=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Sun,=2026=20Jan=202020=2015:07:45=20+0100=0A= Subject:=20[PATCH]=20Correct=20regexp=20for=20flags=20in=20`format'=20= doc=20string=0A=0A*=20src/editfns.c=20(Fformat):=20Use=20the=20correct=20= regexp=20for=20describing=20the=0Aflags=20in=20a=20%-sequence=20(place=20= the=20hyphen=20last).=0A---=0A=20src/editfns.c=20|=202=20+-=0A=201=20= file=20changed,=201=20insertion(+),=201=20deletion(-)=0A=0Adiff=20--git=20= a/src/editfns.c=20b/src/editfns.c=0Aindex=204e35784e55..3f1b3aa4b7=20= 100644=0A---=20a/src/editfns.c=0A+++=20b/src/editfns.c=0A@@=20-3031,7=20= +3031,7=20@@=20DEFUN=20("format",=20Fformat,=20Sformat,=201,=20MANY,=20= 0,=0A=20=20=20%character=0A=20=0A=20= where=20field=20is=20[0-9]+=20followed=20by=20a=20literal=20dollar=20= "$",=20flags=20is=0A-[+=20#-0]+,=20width=20is=20[0-9]+,=20and=20= precision=20is=20a=20literal=20period=20"."=0A+[+=20#0-]+,=20width=20is=20= [0-9]+,=20and=20precision=20is=20a=20literal=20period=20"."=0A=20= followed=20by=20[0-9]+.=0A=20=0A=20If=20a=20%-sequence=20is=20numbered=20= with=20a=20field=20with=20positive=20value=20N,=20the=0A--=20=0A2.21.0=20= (Apple=20Git-122.2)=0A=0A= --Apple-Mail=_DE8C5A97-330D-4D1C-8825-0638123C13C1--