From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Jeffrey C Honig" Newsgroups: gmane.emacs.devel Subject: Re: 23.1: Is delete-windows-on supposed to change the current buffer? Date: Fri, 31 Jul 2009 11:49:52 -0400 Message-ID: <14318.1249055392@schlepp.honig.net> References: <30354.1248991980@schlepp.honig.net> <4A72B471.5030701@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1249071804 28447 80.91.229.12 (31 Jul 2009 20:23:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 31 Jul 2009 20:23:24 +0000 (UTC) Cc: emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 31 22:23:17 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MWydI-0003Sj-7I for ged-emacs-devel@m.gmane.org; Fri, 31 Jul 2009 22:23:16 +0200 Original-Received: from localhost ([127.0.0.1]:43940 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWydH-0002EX-EY for ged-emacs-devel@m.gmane.org; Fri, 31 Jul 2009 16:23:15 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MWuMu-0007NY-L9 for emacs-devel@gnu.org; Fri, 31 Jul 2009 11:50:04 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MWuMq-0007Fk-6r for emacs-devel@gnu.org; Fri, 31 Jul 2009 11:50:04 -0400 Original-Received: from [199.232.76.173] (port=55247 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWuMp-0007FU-WE for emacs-devel@gnu.org; Fri, 31 Jul 2009 11:50:00 -0400 Original-Received: from firewall.honig.net ([66.152.121.24]:42258) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MWuMp-00034N-Ad for emacs-devel@gnu.org; Fri, 31 Jul 2009 11:49:59 -0400 Original-Received: from schlepp.honig.net (shlepp.HONIG.NET [172.25.29.34]) by firewall.honig.net (8.14.1/8.14.1/Debian-8ubuntu1) with ESMTP id n6VFnreZ029293 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 31 Jul 2009 11:49:54 -0400 Original-Received: from schlepp.honig.net (schlepp.honig.net [127.0.0.1]) by schlepp.honig.net (8.14.3/8.14.3/Debian-4) with ESMTP id n6VFnqoX014321; Fri, 31 Jul 2009 11:49:53 -0400 In-reply-to: Message from martin rudalics on Fri, 31 Jul 2009 11:08:01 +0200.<4A72B471.5030701@gmx.at> X-Mailer: MH-E 8.2; nmh 1.2; GNU Emacs 23.1.1 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEXMnHK1jHX257A2GQY+ AQD2yp+TalXrsYfLpNnfAAACHUlEQVR4nG3TwYrbMBAG4NFCrKu1UO+1FZhc1zioD+DSc2oY fLUJq16VgDKv31+W5aTtKoFl9WVGM2OZfvy/Ons2hsp/w+kzGPq0CrgHpO1HhBv/gkfIzx2G 3nn/OfiaQKchn3gr0LtaJJDfzhledpi1YEEyvG7QO5LIiKkua8zw8nWDRQszRPm1gHL44Gbh 0UJCc1mBc8TgSdjalqeg1vPdmKH3Om5AHiFDZ48FtgihBqf4jxX6k1sQkRZANZduGjP0gLRt J8JS/rdFtFrB5FR09zNRMz9AEWlrj/FIwagn6Crv52gnTGtStVp2mCvM9jAKfoyCpXqKaMjc ONRX4jNxNUIyNJWfOQqJAMYmAWVoMEVNMkk8a/a3Au9UaQkIQIdBi99TfQ9BYgBxix7F7fCO fQ5x0jE1Hx7gzjoiPb7IJdcVwgoBgFSoCnB3tkBPAKUpPS+enqFGUUYTmTe2XBUwBsOVatE6 qDcM495t4DFBZoVnMlF8BqRyI58rQan8L9xaDoSEuERttezl9v2rZUFl+FhufJINPvCUJM1W J/Bfdug4YD+2ARUAzGivGRxjC90F3Z4BixkLHEKdrrU6MG4poFYZljrgNtg0YswAnS0FFqmj bSfBqyDXBCb3YZb05qQFegKPP7ilyIWDRuWXxuS7q4w5IMK2ggZbkxfhjb0a85Y6TEH2WwG3 pNHXSB/TkKwpgHOQymB33f9V4A+X8QoMXFv/KAAAAABJRU5ErkJggg== X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-Mailman-Approved-At: Fri, 31 Jul 2009 16:19:12 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:113483 Archived-At: martin rudalics wrote: > > I'm debugging a problem with mh-e with 23.1. In particular > > (mh-yank-cur-msg) in lisp/mh-e/mh-letter.el. > > > > In 23.1, unlike prior releases, this sequence changes the current > > buffer: > > > > (if mh-delete-yanked-msg-window-flag > > (delete-windows-on mh-show-buffer))) > > > > Is this change in behavior expected so that we should fix mh-e? Or is > > this a bug in emacs 23.1 that I should report? >=20 > What is your window configuration like before and after that form gets > executed? In my case (which is not standard mh-e as I pop up new frames for draft buffers): Before: Current buffer: mh-sent-from-folder Main Frame: mh-sent-from-folder mh-show-buffer New Frame: draft-1 After: Current buffer: draft-1 Main Frame: mh-sent-from-folder New Frame draft-1 So the surprise is that the current buffer changed at all. The issue with the current buffer changing is that we are relying on mh-show-buffer not changing, which is a buffer local variable. This is easy to fix in mh-e. But if this is an unexpected change in the behavior of emacs it should probably be fixed there instead. > `delete-windows-on' deletes all windows showing `mh-show-buffer'. If, > for example, `mh-show-buffer' is shown in the selected window and that > window is the only window on its frame, and that frame is the only > frame, another buffer is shown in that window and becomes the current > buffer. window_loop handles this as >=20 > if (EQ (window, selected_window)) > Fset_buffer (w->buffer); >=20 > unchanged since the past release. A similar behavior applies when the > frame can be deleted or there's another window on the frame. >=20 > Can you exclude that there was some change in the `mh-' part handling > this? This code has not changed in three years, so yes, something has changed in emacs. I've also been running the current mh-e code (from emacs CVS) with emacs 22 up until yesterday). Thanks (=E8=B0=A2=E8=B0=A2). Jeff --=20 Jeffrey C. Honig http://www.honig.net/jch GnuPG ID:14E29E13