all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Simen Heggestøyl" <simenheg@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 20256-done@debbugs.gnu.org
Subject: bug#20256: 25.0.50; css-mode: filling multi-line comments
Date: Mon, 27 Apr 2015 22:32:31 +0200	[thread overview]
Message-ID: <1430166751.5441.0@smtp.gmail.com> (raw)
In-Reply-To: <jwvbniaqkia.fsf-monnier+emacsbugs@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 894 bytes --]

On Mon, Apr 27, 2015 at 6:11 AM, Stefan Monnier 
<monnier@iro.umontreal.ca> wrote:
>>  +(defun prog-fill-paragraph (&optional justify)
> [...]
>>  +        ;; Filling inside a comment whose comment-end marker is not
>>  +        ;; \n.  This code is meant to be generic, so that it works 
>> for
>>  +        ;; all modes.
> 
> Hmm... so the code doesn't handle the case of comments that end with 
> \n?
> 
> 
>         Stefan

No, I don't think so. When the comment-end marker is \n,
`forward-comment' will leave point at the beginning of the next line,
causing the whole filling code to be skipped. Even when tweaking the
predicate so that the code is run anyway, it doesn't fill the comment
properly. Was it ever intended to do so? I assumed from the comment
that you quoted that it wasn't.

Those kinds of comments seem to be handled well by the default
`fill-paragraph', though.

-- Simen

[-- Attachment #2: Type: text/html, Size: 1154 bytes --]

  reply	other threads:[~2015-04-27 20:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-04 13:12 bug#20256: 25.0.50; css-mode: filling multi-line comments Simen Heggestøyl
2015-04-07 18:26 ` Stefan Monnier
2015-04-09 18:51   ` Simen Heggestøyl
2015-04-10  1:25     ` Stefan Monnier
2015-04-10 18:45       ` Simen Heggestøyl
2015-04-13 14:28         ` Stefan Monnier
2015-04-18 10:02           ` Simen Heggestøyl
2015-04-18 14:06             ` Stefan Monnier
2015-04-18 18:33               ` Simen Heggestøyl
2015-04-20 16:09                 ` Stefan Monnier
2015-04-21 19:08                   ` Simen Heggestøyl
2015-04-21 20:26                     ` Stefan Monnier
2015-04-26 20:56                   ` Simen Heggestøyl
2015-04-27  4:11                     ` Stefan Monnier
2015-04-27 20:32                       ` Simen Heggestøyl [this message]
2015-04-27 22:46                         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430166751.5441.0@smtp.gmail.com \
    --to=simenheg@gmail.com \
    --cc=20256-done@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.