From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Newsgroups: gmane.emacs.bugs Subject: bug#20256: 25.0.50; css-mode: filling multi-line comments Date: Sat, 04 Apr 2015 15:12:31 +0200 Message-ID: <1428153151.17305.0@smtp.gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="=-W2k7oSWHbA490DYVH6D8" X-Trace: ger.gmane.org 1428155902 2670 80.91.229.3 (4 Apr 2015 13:58:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 4 Apr 2015 13:58:22 +0000 (UTC) To: 20256@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 04 15:58:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YeOUu-0001TZ-Tv for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Apr 2015 15:52:29 +0200 Original-Received: from localhost ([::1]:33051 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YeOUp-0005JX-9D for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Apr 2015 09:52:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44512) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YeOTg-0002zA-C3 for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2015 09:51:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YeOTW-0006E8-To for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2015 09:51:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54832) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YeOTW-0006E4-Pt for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2015 09:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YeOTW-0004fc-Io for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2015 09:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Apr 2015 13:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 20256 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.142815545217920 (code B ref -1); Sat, 04 Apr 2015 13:51:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 Apr 2015 13:50:52 +0000 Original-Received: from localhost ([127.0.0.1]:44605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YeOTL-0004ey-Kw for submit@debbugs.gnu.org; Sat, 04 Apr 2015 09:50:52 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:58158) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YeOTH-0004eg-55 for submit@debbugs.gnu.org; Sat, 04 Apr 2015 09:50:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YeOT7-0005rf-1R for submit@debbugs.gnu.org; Sat, 04 Apr 2015 09:50:41 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:32964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YeOT6-0005rP-SE for submit@debbugs.gnu.org; Sat, 04 Apr 2015 09:50:36 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42763) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YeOT2-0001e9-2I for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2015 09:50:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YeOM8-0002Xr-6W for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2015 09:43:27 -0400 Original-Received: from mail-la0-x22c.google.com ([2a00:1450:4010:c03::22c]:36434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YeOM7-0002Xn-Ne for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2015 09:43:24 -0400 Original-Received: by lagv1 with SMTP id v1so18089179lag.3 for ; Sat, 04 Apr 2015 06:43:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:subject:to:message-id:mime-version:content-type; bh=UIOlLUJv8CpfhUNjDcFiisysZnBccuYNLGyMZ9ogTdc=; b=O5zjYxWhDwyWd29kWfhOeo5MAGLt/mUhheriR4tyVtt5ZsinMDvSfhS1czBBo6hQ3S Xrc4/R8xaVQVaNeXFGxvYHHztBYQp9dHk4OVxhvtQquKUq75deRBXA2I6vUP4Ax8z2+A 4kTQLLTCikvu/b9lJLBnY/zvnundj5hSZazre6ltwCMiJ3S/JDZdN0oqUX8zrVE8wFKY rZN9H+4XLyf8P7Xjr35scFqdHtyxHtvL9sQ3vbir3cbNaP4wF8t8GX4zXtl2ngC6MMIT NEUNQHWQE4MBX2SlKeSMLjHOFuSuiZZG6TvxWsjpPDf0kuwNxCZh05LNscXqLr/LRpJV mJ9w== X-Received: by 10.112.141.106 with SMTP id rn10mr6118985lbb.100.1428153154824; Sat, 04 Apr 2015 06:12:34 -0700 (PDT) Original-Received: from [192.168.1.114] (cm-84.215.44.110.getinternet.no. [84.215.44.110]) by mx.google.com with ESMTPSA id h3sm122350lbj.19.2015.04.04.06.12.33 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Apr 2015 06:12:33 -0700 (PDT) X-Mailer: geary/0.8.2 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:101181 Archived-At: --=-W2k7oSWHbA490DYVH6D8 Content-Type: text/plain; charset=utf-8; format=flowed Filling multi-line comments in `css-mode' is broken. Consider for instance the following comment: /* * Multi-line comment here. * This comment spans * multiple * lines. * Better fill it! */ Filling it with a `fill-column' of 70, I'd expect the following result: /* * Multi-line comment here. This comment spans multiple lines. * Better fill it! */ But as of now, what we get is this: /* * Multi-line comment here. * This comment spans * multiple * lines. * Better fill it! */ From this comment in `css-fill-paragraph', it sounds like it is supposed to work, or has been working some time before: ;; Filling inside a comment whose comment-end marker is not \n. ;; This code is meant to be generic, so that it works not only for ;; css-mode but for all modes. Could someone fill me in? Alternatively, we could let `css-mode' borrow comment filling code from `cc-mode', like `js-mode' and `js2-mode' do. Please let me know if that would be an acceptable fix. -- Simen --=-W2k7oSWHbA490DYVH6D8 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Filling multi-line comments in `css-mode' is broken. Consider for
instance the following comment:

  /*
   * Multi-line comment here.
   * Th= is comment spans
   * multiple
   *= lines.
   * Better fill it!
   */<= /div>

Filling it with a `fill-column' of 70, I'd expect = the following
result:

  /*
   * Multi-line comment here.  This comment spans multiple= lines.
   * Better fill it!
   */<= /div>

But as of now, what we get is this:

=
  /* * Multi-line comment here.  * This comment spans = * multiple *
  lines.  * Better fill it!  */
=

From this comment in `css-fill-paragraph', it sounds li= ke it is
supposed to work, or has been working some time before:<= /div>

  ;; Filling inside a comment whose comment-e= nd marker is not \n.
  ;; This code is meant to be generic, = so that it works not only for
  ;; css-mode but for all mode= s.

Could someone fill me in?

<= div>Alternatively, we could let `css-mode' borrow comment filling code
from `cc-mode', like `js-mode' and `js2-mode' do. Please let me know<= /div>
if that would be an acceptable fix.

-- S= imen
= --=-W2k7oSWHbA490DYVH6D8--