From: Samer Masterson <samer@samertm.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 19391@debbugs.gnu.org
Subject: bug#19391: [PATCH] bug#19391: 25.0.50; eshell-buffer-shorthand breaks command dollar expansion
Date: Tue, 03 Mar 2015 23:50:34 -0800 [thread overview]
Message-ID: <1425455434.1450.1@mail.samertm.com> (raw)
In-Reply-To: <83a8zuqdle.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1837 bytes --]
On Tue, Mar 3, 2015 at 7:56 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> Can you explain why we should lose this user option? I understand
> that it causes trouble in this scenario, but can we solve the bug
> without losing the option? If not, why having the limitation
> documented in the doc string is not good enough?
>
> Thanks.
I think the strongest reason for losing the option is that it currently
doesn't work: If you type "echo hello > '*scratch" into eshell and
press enter, eshell adds a newline without evaluating the command
because it thinks it's in a string because of the unmatched single
quote. Its implementation also makes eshell more complex, because
eshell-get-target *only* checks for symbols if the option is selected,
and then gets-or-creates a buffer with the symbol name.
I think having a shorthand for buffers in eshell is a good thing, but
it should be different in three ways:
- The syntax for the shorthand should be distinct from any other lisp
objects, so that we don't have to put out fires when people try to do
things that are valid but overlap with the shorthand (e.g. this bug was
caused by eshell's external shell feature redirecting to a symbol.)
Something like #<name-of-buffer> would work.
- The shorthand should be processed as a buffer (similar to how
#<buffer name-of-buffer> is processed). That means the shorthand won't
require extra code anywhere except for the reader.
- The shorthand should be on by default, and probably shouldn't have
an option to disable it. The reason for this is that the shorthand
would be universally beneficial and backwards compatible, and making it
controlled by an option is inviting bugs when we shouldn't be.
Let me know what you think of the above, and I can add more detail to
the proposal and submit it to emacs-devel.
Best,
Samer
[-- Attachment #2: Type: text/html, Size: 2073 bytes --]
next prev parent reply other threads:[~2015-03-04 7:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 4:35 bug#19391: 25.0.50; eshell-buffer-shorthand breaks command dollar expansion dylan
2015-02-24 10:59 ` bug#19391: [PATCH] " Samer Masterson
2015-03-03 15:56 ` Eli Zaretskii
2015-03-04 7:50 ` Samer Masterson [this message]
2015-03-04 17:28 ` Eli Zaretskii
2017-11-27 2:42 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425455434.1450.1@mail.samertm.com \
--to=samer@samertm.com \
--cc=19391@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.