all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: era eriksson <era+emacs@iki.fi>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 19768@debbugs.gnu.org
Subject: bug#19768: json.el: end-of-file errors untrappable
Date: Thu, 05 Feb 2015 13:51:30 +0200	[thread overview]
Message-ID: <1423137090.527204.223447373.25D98B2F@webmail.messagingengine.com> (raw)
In-Reply-To: <jwvh9v18zdg.fsf-monnier+emacsbugs@gnu.org>

On Wed, Feb 4, 2015, at 17:34, Stefan Monnier wrote:
> > I'm not sure what the proper fix should be.  Maybe these occurrences
> > could be changed to json-end-of-file or something?
> 
> That sounds right.  If we define json-end-of-file as an error which as
> `end-of-file' as parent, it should give us the best of both worlds.

https://github.com/tripleee/emacs/tree/bug19768 contains a simple patch
which implements this, but I am uncertain how to test it.  Also, I am
having second thoughts about defining the new error symbol as a child of
'end-of-file when all the other error symbols neatly inherit from
'json-error.  Anyway, feel free to review and/or pull and/or ignore. (-:

/* era */

-- 
If this were a real .signature, it would suck less.  Well, maybe not.





  reply	other threads:[~2015-02-05 11:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-04 13:59 bug#19768: json.el: end-of-file errors untrappable era eriksson
2015-02-04 15:34 ` Stefan Monnier
2015-02-05 11:51   ` era eriksson [this message]
2015-02-05 19:52     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423137090.527204.223447373.25D98B2F@webmail.messagingengine.com \
    --to=era+emacs@iki.fi \
    --cc=19768@debbugs.gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.