From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Newsgroups: gmane.emacs.bugs Subject: bug#19263: 25.0.50; scss-mode: interpolated variable indentation Date: Fri, 12 Dec 2014 21:18:53 +0100 Message-ID: <1418415533.9295.0@smtp.gmail.com> References: <1417632302.20176.0@smtp.gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="=-tbm+aa6y24J8HM/CJp8g" X-Trace: ger.gmane.org 1418415631 12872 80.91.229.3 (12 Dec 2014 20:20:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 12 Dec 2014 20:20:31 +0000 (UTC) To: 19263@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 12 21:20:24 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XzWhJ-0006k7-BT for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Dec 2014 21:20:21 +0100 Original-Received: from localhost ([::1]:59362 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzWhI-0002Hu-TI for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Dec 2014 15:20:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzWh7-0002Fp-W7 for bug-gnu-emacs@gnu.org; Fri, 12 Dec 2014 15:20:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XzWh0-0001YT-Eq for bug-gnu-emacs@gnu.org; Fri, 12 Dec 2014 15:20:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34846) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzWh0-0001Xr-Bg for bug-gnu-emacs@gnu.org; Fri, 12 Dec 2014 15:20:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XzWgz-0003k2-M4 for bug-gnu-emacs@gnu.org; Fri, 12 Dec 2014 15:20:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <1417632302.20176.0@smtp.gmail.com> Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Dec 2014 20:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19263 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19263-submit@debbugs.gnu.org id=B19263.141841554514308 (code B ref 19263); Fri, 12 Dec 2014 20:20:01 +0000 Original-Received: (at 19263) by debbugs.gnu.org; 12 Dec 2014 20:19:05 +0000 Original-Received: from localhost ([127.0.0.1]:44212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzWg5-0003ih-Cl for submit@debbugs.gnu.org; Fri, 12 Dec 2014 15:19:05 -0500 Original-Received: from mail-wi0-f170.google.com ([209.85.212.170]:49163) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzWg2-0003iC-SM for 19263@debbugs.gnu.org; Fri, 12 Dec 2014 15:19:03 -0500 Original-Received: by mail-wi0-f170.google.com with SMTP id bs8so5562739wib.1 for <19263@debbugs.gnu.org>; Fri, 12 Dec 2014 12:18:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:subject:to:message-id:mime-version:content-type; bh=EtiMj51DtG5UC0M+5U667fz4NYj1S1O1U6I3mkzYDGk=; b=gg5VF31m3ROyZlMzvvWzGv/qqIxrY7h+ko0AHqcQr5Kl/ClNYOiLKT6p7MbYGT3/xo WrvpfbVF8Klux7sxfsCWCYUzHtwwRZFlBBwDb1U/WbSp4fVMIR4vt6KNDIIljEYTpIQO Cp7TR6rutIdD7TeDw4NmgdNQyK7k8+iFpCdu4/idAz2hjjjeUW4dYSkJNr7xsZ9FzjIz OSpFJ17Xq9Th2BWKl83M1Dm3ahvMYwxlY6whuqB+HCJzKE6vM4F1Y9pt7nNqC6NO5KVq hWYOGJgjyBIVZXGrFGE6fJr3e3bWjp1tz7Mj2wDh3x2QDAdNmnC33S19X87Zaxs9Ry3q zZ6Q== X-Received: by 10.180.198.211 with SMTP id je19mr10502586wic.27.1418415537224; Fri, 12 Dec 2014 12:18:57 -0800 (PST) Original-Received: from [192.168.1.114] (cm-84.215.25.128.getinternet.no. [84.215.25.128]) by mx.google.com with ESMTPSA id p5sm3228467wix.7.2014.12.12.12.18.55 for <19263@debbugs.gnu.org> (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Dec 2014 12:18:56 -0800 (PST) X-Mailer: geary/0.8.2 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:97274 Archived-At: --=-tbm+aa6y24J8HM/CJp8g Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable The bug seems to be fixed by the following patch: diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index 1759643..e94b11f 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -450,7 +450,7 @@ (defun scss-smie--not-interpolation-p () (save-excursion (forward-char -1) - (or (zerop (skip-chars-backward "[:alnum:]")) + (or (zerop (skip-chars-backward "-[:alnum:]")) (not (looking-back "#{\\$" (- (point) 3)))))) ;;;###autoload (add-to-list 'auto-mode-alist '("\\.scss\\'" .=20 scss-mode)) I wanted to add a test case for this as well, but I couldn't understand how the indentation tests work. Are the files in =E2=80=98test/indent/=E2=80=99 supposed to exemplify correct indentation? I= n that case, the indentation in =E2=80=98test/indent/scss-mode.scss=E2=80=99 seems= to be wrong given the default indent offset of 4. = --=-tbm+aa6y24J8HM/CJp8g Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
The bug seems to be fixed by the following patch:

=
diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el
index 1759643..e94b11f 100644
--- a/lisp/textmodes/css-m= ode.el
+++ b/lisp/textmodes/css-mode.el
@@ -450,7 +450,= 7 @@
 (defun scss-smie--not-interpolation-p ()
&nb= sp;  (save-excursion
     (forward-char -1)
-    (or (zerop (skip-chars-backward "[:alnum:]"))
=
+    (or (zerop (skip-chars-backward "-[:alnum:]"))
         (not (looking-back "#{\\$" (- (point) 3= ))))))
 
 ;;;###autoload (add-to-list 'auto-m= ode-alist '("\\.scss\\'" . scss-mode))

I wanted to= add a test case for this as well, but I couldn't
understand how = the indentation tests work. Are the files in
=E2=80=98test/indent= /=E2=80=99 supposed to exemplify correct indentation? In that
cas= e, the indentation in =E2=80=98test/indent/scss-mode.scss=E2=80=99 seems to= be
wrong given the default indent offset of 4.
= --=-tbm+aa6y24J8HM/CJp8g--